Skip to content

fix(traits): Remove expression references from index suggestions - #162437

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
NuclEnergy:fix/suggest_dereferencing_index
Sep 10, 2026
Merged

fix(traits): Remove expression references from index suggestions#162437
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
NuclEnergy:fix/suggest_dereferencing_index

Conversation

@NuclEnergy

@NuclEnergy NuclEnergy commented Sep 7, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

Fix issue: #162419

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 7, 2026
@rustbot

rustbot commented Sep 7, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the pull request, and welcome! The Rust Project has assigned @jieyouxu (or someone else) to review your changes, you should hear from them (or someone else) within the next two weeks.

Please see the contribution instructions and our LLM policy for more information.

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 75 candidates
  • Random selection from 20 candidates

jieyouxu
jieyouxu requested changes Sep 8, 2026
View reviewed changes
Comment thread tests/ui/suggestions/suggest-remove-reference-index.rs Outdated
Comment thread compiler/rustc_trait_selection/src/error_reporting/traits/suggestions.rs Outdated
Comment thread compiler/rustc_trait_selection/src/error_reporting/traits/suggestions.rs Outdated
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 8, 2026
@rustbot

rustbot commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@NuclEnergy

NuclEnergy commented Sep 8, 2026

Copy link
Copy Markdown
Contributor Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 8, 2026
jieyouxu
jieyouxu reviewed Sep 9, 2026
View reviewed changes

@jieyouxu jieyouxu left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, one nit
@rustbot author

View changes since this review

Comment thread compiler/rustc_trait_selection/src/error_reporting/traits/suggestions.rs Outdated
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 9, 2026
@NuclEnergy
NuclEnergy requested a review from jieyouxu September 9, 2026 13:13
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 9, 2026
jieyouxu
jieyouxu approved these changes Sep 10, 2026
View reviewed changes

@jieyouxu jieyouxu left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

View changes since this review

@jieyouxu

jieyouxu commented Sep 10, 2026

Copy link
Copy Markdown
Member

@bors squash

@rust-bors

This comment has been minimized.

Sign in to view
@NuclEnergy
fix(traits): Remove expression references from index suggestions
21b046d 
* fix(traits): Remove expression references from index suggestions
* Use expression spans for index reference removal suggestions
* refactor(trait-selection): Simplify dereference suggestion guard
@rust-bors

rust-bors Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

🔨 3 commits were squashed into 21b046d.

@rust-bors
rust-bors Bot force-pushed the fix/suggest_dereferencing_index branch from f7d99b1 to 21b046d Compare September 10, 2026 09:21
@jieyouxu

jieyouxu commented Sep 10, 2026

Copy link
Copy Markdown
Member

@bors r+ rollup

@rust-bors

rust-bors Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 21b046d has been approved by jieyouxu

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 10, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Sep 10, 2026
@JonathanBrouwer
Rollup merge of rust-lang#162437 - NuclEnergy:fix/suggest_dereferenci…
de8c650 
…ng_index, r=jieyouxu

fix(traits): Remove expression references from index suggestions

Fix issue: rust-lang#162419
@JonathanBrouwer JonathanBrouwer mentioned this pull request Sep 10, 2026
Closed
rust-bors Bot pushed a commit that referenced this pull request Sep 10, 2026
@bors
Auto merge of #162582 - JonathanBrouwer:rollup-99AfBfl, r=JonathanBro…
c3b13ab 
…uwer

Rollup of 3 pull requests

Successful merges:

 - #162581 (Subtree sync for rustc_codegen_cranelift)
 - #160831 (re-equate the object bound's trait ref with the goal's when considering object bounds)
 - #162437 (fix(traits): Remove expression references from index suggestions)
rust-bors Bot pushed a commit that referenced this pull request Sep 10, 2026
@bors
Auto merge of #162582 - JonathanBrouwer:rollup-99AfBfl, r=JonathanBro…
f20d155 
…uwer

Rollup of 3 pull requests

Successful merges:

 - #162581 (Subtree sync for rustc_codegen_cranelift)
 - #160831 (re-equate the object bound's trait ref with the goal's when considering object bounds)
 - #162437 (fix(traits): Remove expression references from index suggestions)
rust-bors Bot pushed a commit that referenced this pull request Sep 10, 2026
@bors
Auto merge of #162582 - JonathanBrouwer:rollup-99AfBfl, r=JonathanBro…
1cf9486 
…uwer

Rollup of 3 pull requests

Successful merges:

 - #162581 (Subtree sync for rustc_codegen_cranelift)
 - #160831 (re-equate the object bound's trait ref with the goal's when considering object bounds)
 - #162437 (fix(traits): Remove expression references from index suggestions)
rust-bors Bot pushed a commit that referenced this pull request Sep 10, 2026
@bors
Auto merge of #162582 - JonathanBrouwer:rollup-99AfBfl, r=JonathanBro…
edff014 
…uwer

Rollup of 3 pull requests

Successful merges:

 - #162581 (Subtree sync for rustc_codegen_cranelift)
 - #160831 (re-equate the object bound's trait ref with the goal's when considering object bounds)
 - #162437 (fix(traits): Remove expression references from index suggestions)
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Sep 10, 2026
@JonathanBrouwer
Rollup merge of rust-lang#162437 - NuclEnergy:fix/suggest_dereferenci…
82c2424 
…ng_index, r=jieyouxu

fix(traits): Remove expression references from index suggestions

Fix issue: rust-lang#162419
@JonathanBrouwer JonathanBrouwer mentioned this pull request Sep 10, 2026
Closed
rust-bors Bot pushed a commit that referenced this pull request Sep 10, 2026
@bors
Auto merge of #162589 - JonathanBrouwer:rollup-8IiiIPF, r=JonathanBro…
9073adf 
…uwer

Rollup of 6 pull requests

Successful merges:

 - #162581 (Subtree sync for rustc_codegen_cranelift)
 - #160831 (re-equate the object bound's trait ref with the goal's when considering object bounds)
 - #162057 (Some cleanups around fatal errors and delayed bugs)
 - #162437 (fix(traits): Remove expression references from index suggestions)
 - #162534 (Fix run-make/prune-link-args to work with MinGW)
 - #162576 (doc: Fix external mention of signum() return value regarding NaNs)
rust-bors Bot pushed a commit that referenced this pull request Sep 10, 2026
@bors
Auto merge of #162589 - JonathanBrouwer:rollup-8IiiIPF, r=JonathanBro…
2dd95b5 
…uwer

Rollup of 6 pull requests

Successful merges:

 - #162581 (Subtree sync for rustc_codegen_cranelift)
 - #160831 (re-equate the object bound's trait ref with the goal's when considering object bounds)
 - #162057 (Some cleanups around fatal errors and delayed bugs)
 - #162437 (fix(traits): Remove expression references from index suggestions)
 - #162534 (Fix run-make/prune-link-args to work with MinGW)
 - #162576 (doc: Fix external mention of signum() return value regarding NaNs)
@JonathanBrouwer JonathanBrouwer mentioned this pull request Sep 10, 2026
Merged
rust-bors Bot pushed a commit that referenced this pull request Sep 10, 2026
@bors
Auto merge of #162592 - JonathanBrouwer:rollup-3q5U3Oo, r=JonathanBro…
018018e 
…uwer

Rollup of 7 pull requests

Successful merges:

 - #162581 (Subtree sync for rustc_codegen_cranelift)
 - #160831 (re-equate the object bound's trait ref with the goal's when considering object bounds)
 - #162057 (Some cleanups around fatal errors and delayed bugs)
 - #162437 (fix(traits): Remove expression references from index suggestions)
 - #162534 (Fix run-make/prune-link-args to work with MinGW)
 - #162554 (Attemped fix for home dir problem on `dist-aarch64-llvm-mingw`)
 - #162576 (doc: Fix external mention of signum() return value regarding NaNs)
@rust-bors
rust-bors Bot merged commit f9e8678 into rust-lang:main Sep 10, 2026
13 checks passed
@rustbot rustbot added this to the 1.100.0 milestone Sep 10, 2026
rust-bors Bot pushed a commit that referenced this pull request Sep 10, 2026
@bors
Unrolled build for #162437 in rollup 162592
29faec6 
Rollup merge of #162437 - NuclEnergy:fix/suggest_dereferencing_index, r=jieyouxu

fix(traits): Remove expression references from index suggestions

Fix issue: #162419
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.100.0

Development

Successfully merging this pull request may close these issues.

3 participants

@NuclEnergy @rustbot @jieyouxu