Small x perf improvements - #162473
Merged
Merged
Conversation
rustbot
added
S-waiting-on-review
JonathanBrouwer
approved these changes
Sep 8, 2026
Contributor
rust-bors
Bot
added
S-waiting-on-bors
panstromek
reviewed
Sep 8, 2026
|
|
||
| /// Performs profiling using `rustc-perf` on a built version of the compiler. | ||
| pub fn perf(builder: &Builder<'_>, args: &PerfArgs) { | ||
| pub fn perf(builder: &Builder<'_>, args: &PerfArgs, trailing_args: &[String]) { |
Contributor
There was a problem hiding this comment.
❤️❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Sep 8, 2026
Small `x perf` improvements Tiny improvements I found while using this command locally. r? JonathanBrouwer
This was referenced Sep 8, 2026
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 8, 2026
…uwer Rollup of 9 pull requests Successful merges: - #157738 (Support move expressions in coroutine closures) - #160219 (Implement `Thread::os_id`) - #162449 (Prefer removing a redundant shared reference over reborrow) - #162494 (Ignore `self-in-const-generics` test for parallel frontend) - #162495 (Reserve items in `Extend` implementations) - #162238 (trait solver: Include implied outlives assumptions) - #162473 (Small `x perf` improvements) - #162489 (Clean up on upvar_tys) - #162500 (Move the `expect-item-after-attribute.rs` test to the correct directory)
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 9, 2026
Rollup merge of #162473 - Kobzol:x-perf, r=JonathanBrouwer Small `x perf` improvements Tiny improvements I found while using this command locally. r? JonathanBrouwer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tiny improvements I found while using this command locally.
r? JonathanBrouwer