Skip to content

Prefer removing a redundant shared reference over reborrow - #162449

Merged
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
chenyukang:yukang-fix-133685-remove-redundant-shared-reference
Sep 9, 2026
Merged

Prefer removing a redundant shared reference over reborrow#162449
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
chenyukang:yukang-fix-133685-remove-redundant-shared-reference

Conversation

@chenyukang

@chenyukang chenyukang commented Sep 8, 2026

Copy link
Copy Markdown
Member

Fixes #133685

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 8, 2026
@rustbot

rustbot commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

r? @mati865

rustbot has assigned @mati865.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 75 candidates
  • Random selection from 18 candidates

@chenyukang
chenyukang force-pushed the yukang-fix-133685-remove-redundant-shared-reference branch from 8102695 to fb19743 Compare September 8, 2026 01:21

@mati865 mati865 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rust-bors

rust-bors Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

📌 Commit fb19743 has been approved by mati865

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 8, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Sep 8, 2026
…e-redundant-shared-reference, r=mati865

Prefer removing a redundant shared reference over reborrow

Fixes rust-lang#133685
rust-bors Bot pushed a commit that referenced this pull request Sep 8, 2026
…uwer

Rollup of 9 pull requests

Successful merges:

 - #157738 (Support move expressions in coroutine closures)
 - #160219 (Implement `Thread::os_id`)
 - #162449 (Prefer removing a redundant shared reference over reborrow)
 - #162494 (Ignore `self-in-const-generics` test for parallel frontend)
 - #162495 (Reserve items in `Extend` implementations)
 - #162238 (trait solver: Include implied outlives assumptions)
 - #162473 (Small `x perf` improvements)
 - #162489 (Clean up on upvar_tys)
 - #162500 (Move the `expect-item-after-attribute.rs` test to the correct directory)
@rust-bors
rust-bors Bot merged commit 01d3132 into rust-lang:main Sep 9, 2026
13 checks passed
@rustbot rustbot added this to the 1.100.0 milestone Sep 9, 2026
rust-bors Bot pushed a commit that referenced this pull request Sep 9, 2026
Rollup merge of #162449 - chenyukang:yukang-fix-133685-remove-redundant-shared-reference, r=mati865

Prefer removing a redundant shared reference over reborrow

Fixes #133685
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unnecessarily complex suggestion when using extraneous reference type

3 participants