Skip to content

Unconditionally invalidate the library when the compiler changes - #162413

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
Kobzol:check-compiler-invalidate
Sep 7, 2026
Merged

Unconditionally invalidate the library when the compiler changes#162413
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
Kobzol:check-compiler-invalidate

Conversation

@Kobzol

@Kobzol Kobzol commented Sep 7, 2026

Copy link
Copy Markdown
Member

Note that x doc is invalidated elsewhere, when rustdoc changes.

Fixes: #162407

r? jieyouxu

@rustbot rustbot added A-bootstrap-stamp Area: bootstrap stamp logic S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Sep 7, 2026
Comment thread src/bootstrap/src/core/builder/cargo.rs Outdated
@Kobzol
Kobzol force-pushed the check-compiler-invalidate branch from 67cfa94 to dbb7cda Compare September 7, 2026 10:44
@Kobzol
Kobzol force-pushed the check-compiler-invalidate branch from dbb7cda to eec967a Compare September 7, 2026 11:31
@Kobzol Kobzol changed the title Invalidate x check library when the compiler changes Unconditionally invalidate the library when the compiler changes Sep 7, 2026

@jieyouxu jieyouxu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, r=me once pr ci green

View changes since this review

@Kobzol

Kobzol commented Sep 7, 2026

Copy link
Copy Markdown
Member Author

@bors r=jieyouxu

@rust-bors

rust-bors Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

📌 Commit eec967a has been approved by jieyouxu

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 7, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Sep 7, 2026
…r=jieyouxu

Unconditionally invalidate the library when the compiler changes

Note that `x doc` is invalidated elsewhere, when `rustdoc` changes.

Fixes: rust-lang#162407

r? jieyouxu
rust-bors Bot pushed a commit that referenced this pull request Sep 7, 2026
…uwer

Rollup of 11 pull requests

Successful merges:

 - #158153 (avoid spurious lifetime diagnostic in async generic case)
 - #160197 (Restrict LLVM inline asm location cookie usage. Fixes #150451)
 - #162413 (Unconditionally invalidate the library when the compiler changes)
 - #162294 (Reflection refactor ptrs)
 - #162354 (Make comptime functions ineligible for coverage)
 - #162379 (add test ensuring we refuse to const-eval the body of a rustc_do_not_const_check function)
 - #162386 (Add a regression test for trailing attributes in doctests)
 - #162410 (std: remove exceed whitespace in docs)
 - #162420 (mir_build: Don't pass a redundant `scrutinee_span` to some MIR-build methods)
 - #162430 (rustc-dev-guide subtree update)
 - #162431 (add next-solver FIXMEs)
@rust-bors
rust-bors Bot merged commit a4764fa into rust-lang:main Sep 7, 2026
13 checks passed
@rustbot rustbot added this to the 1.100.0 milestone Sep 7, 2026
rust-bors Bot pushed a commit that referenced this pull request Sep 7, 2026
Rollup merge of #162413 - Kobzol:check-compiler-invalidate, r=jieyouxu

Unconditionally invalidate the library when the compiler changes

Note that `x doc` is invalidated elsewhere, when `rustdoc` changes.

Fixes: #162407

r? jieyouxu
@Kobzol
Kobzol deleted the check-compiler-invalidate branch September 7, 2026 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-bootstrap-stamp Area: bootstrap stamp logic S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

./x check library does not re-check library after compiler changed

3 participants