Add a regression test for trailing attributes in doctests - #162386
Merged
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
rustbot has assigned @lolbinarycat. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This was referenced Sep 6, 2026
This comment has been minimized.
This comment has been minimized.
JonathanBrouwer
force-pushed
the
doctest-attribute
branch
from
September 6, 2026 20:09
64a2966 to
6de68d9
Compare
This comment has been minimized.
This comment has been minimized.
JonathanBrouwer
force-pushed
the
doctest-attribute
branch
from
September 7, 2026 08:34
6de68d9 to
08e5e87
Compare
Member
This comment has been minimized.
This comment has been minimized.
Member
Author
|
I will fight CI & include the testcases mejrs linked |
rustbot
added
S-waiting-on-author
JonathanBrouwer
force-pushed
the
doctest-attribute
branch
from
September 7, 2026 12:06
08e5e87 to
e9c8a6d
Compare
mejrs
approved these changes
Sep 7, 2026
Contributor
rust-bors
Bot
added
the
S-waiting-on-bors
rust-bors
Bot
removed
the
S-waiting-on-author
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 7, 2026
…uwer Rollup of 11 pull requests Successful merges: - #158153 (avoid spurious lifetime diagnostic in async generic case) - #160197 (Restrict LLVM inline asm location cookie usage. Fixes #150451) - #162413 (Unconditionally invalidate the library when the compiler changes) - #162294 (Reflection refactor ptrs) - #162354 (Make comptime functions ineligible for coverage) - #162379 (add test ensuring we refuse to const-eval the body of a rustc_do_not_const_check function) - #162386 (Add a regression test for trailing attributes in doctests) - #162410 (std: remove exceed whitespace in docs) - #162420 (mir_build: Don't pass a redundant `scrutinee_span` to some MIR-build methods) - #162430 (rustc-dev-guide subtree update) - #162431 (add next-solver FIXMEs)
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 7, 2026
Rollup merge of #162386 - JonathanBrouwer:doctest-attribute, r=mejrs Add a regression test for trailing attributes in doctests Adds a regression test for #162131, #162129, #162349, and #162352 It seems likely this breakage is going to be accepted, so let's add a test in nightly so we can at least track this behavior in the feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a regression test for #162131, #162129, #162349, and #162352
It seems likely this breakage is going to be accepted, so let's add a test in nightly so we can at least track this behavior in the feature