Skip to content

Replace Allocator + Clone with AllocatorClone in btree - #161684

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
maxdexh:smoke-trees
Aug 26, 2026
Merged

Replace Allocator + Clone with AllocatorClone in btree#161684
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
maxdexh:smoke-trees

Conversation

@maxdexh

@maxdexh maxdexh commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

powered by ripgrep

r? nia-e

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 24, 2026
@maxdexh

maxdexh commented Aug 24, 2026

Copy link
Copy Markdown
Contributor Author

cc #161678

Comment thread library/alloc/src/collections/btree/map/entry.rs
@nia-e

nia-e commented Aug 25, 2026

Copy link
Copy Markdown
Member

seeing as this is all just a bunch of regexing, i see little reason for this to be wrong. just worth a check that any target-specific code implements the trait correctly. r=me if this passes.

@bors delegate+
@bors try jobs=dist-various

@rust-bors

rust-bors Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

✌️ @maxdexh, you can now approve this pull request!

If @nia-e told you to "r=me" after making some further change, then please make that change and post @bors r=nia-e.

View changes since this delegation.

@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Aug 25, 2026
Replace `Allocator + Clone` with `AllocatorClone` in btree


try-job: dist-various
@rust-bors rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 25, 2026
@rust-bors

rust-bors Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

💔 Test for ad4c4c1 failed: CI. Failed job:

@rust-log-analyzer

Copy link
Copy Markdown
Collaborator

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
   Compiling ureq v3.4.0
   Compiling citool v0.1.0 (/home/runner/work/rust/rust/src/ci/citool)
    Finished `dev` profile [unoptimized] target(s) in 23.45s
     Running `target/debug/citool calculate-job-matrix`
Run type: TryJob { job_patterns: Some(["dist-various"]), nolimit: false }
Error: Failed to calculate job matrix

Caused by:
    Patterns `dist-various` did not match any auto jobs
##[error]Process completed with exit code 1.

@maxdexh

maxdexh commented Aug 25, 2026

Copy link
Copy Markdown
Contributor Author

Patterns dist-various did not match any auto jobs

I still can't use bors try, can you please run a job that exists? ^^

@nia-e

nia-e commented Aug 25, 2026

Copy link
Copy Markdown
Member

it appears i have the stupids. apologies

@bors try jobs=dist-various-1,test-various

@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Aug 25, 2026
Replace `Allocator + Clone` with `AllocatorClone` in btree


try-job: dist-various-1
try-job: test-various
@rust-bors

rust-bors Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 1dc4162 (1dc4162340ccc1aa311a8ce853389868e20e63e0)
Base parent: cc05892 (cc05892c8346313865afd91ca12ee1fde6d3603c)

@maxdexh

maxdexh commented Aug 25, 2026

Copy link
Copy Markdown
Contributor Author

@bors r=nia-e

@rust-bors

rust-bors Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

📌 Commit bd72f7a has been approved by nia-e

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 25, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Aug 25, 2026
Replace `Allocator + Clone` with `AllocatorClone` in btree

powered by ripgrep

r? nia-e
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Aug 25, 2026
Replace `Allocator + Clone` with `AllocatorClone` in btree

powered by ripgrep

r? nia-e
rust-bors Bot pushed a commit that referenced this pull request Aug 25, 2026
…uwer

Rollup of 5 pull requests

Successful merges:

 - #161328 (Enforce even more library clippy lints in CI)
 - #161684 (Replace `Allocator + Clone` with `AllocatorClone` in btree)
 - #159232 (Don't list escaping bound regions in nested `for<...>` binders of E0308 notes)
 - #161464 (various cleanups of `rustc_builtin_macros`)
 - #161774 (Add codegen test for disjunction fed to unreachable_unchecked)
@rust-bors
rust-bors Bot merged commit f6d0a0a into rust-lang:main Aug 26, 2026
14 checks passed
@rustbot rustbot added this to the 1.100.0 milestone Aug 26, 2026
rust-bors Bot pushed a commit that referenced this pull request Aug 26, 2026
Rollup merge of #161684 - maxdexh:smoke-trees, r=nia-e

Replace `Allocator + Clone` with `AllocatorClone` in btree

powered by ripgrep

r? nia-e
@maxdexh
maxdexh deleted the smoke-trees branch August 26, 2026 06:49
@rust-timer

Copy link
Copy Markdown
Collaborator

Note

This PR was benchmarked as part of triage of its containing rollup: triage URL.

Finished benchmarking commit (f951449): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
0.3% [0.3%, 0.3%] 1
Regressions ❌
(secondary)
0.3% [0.3%, 0.3%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.3% [0.3%, 0.3%] 1

Max RSS (memory usage)

Results (primary -0.1%, secondary -3.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
2.0% [2.0%, 2.0%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-2.2% [-2.2%, -2.2%] 1
Improvements ✅
(secondary)
-3.7% [-3.7%, -3.7%] 1
All ❌✅ (primary) -0.1% [-2.2%, 2.0%] 2

Cycles

Results (primary 3.2%, secondary 1.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
3.2% [3.2%, 3.2%] 1
Regressions ❌
(secondary)
1.7% [1.7%, 1.7%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 3.2% [3.2%, 3.2%] 1

Binary size

Results (primary 0.0%, secondary 0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
0.0% [0.0%, 0.0%] 4
Regressions ❌
(secondary)
0.0% [0.0%, 0.0%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.0% [0.0%, 0.0%] 4

Bootstrap: 474.247s -> 473.912s (-0.07%)
Artifact size: 402.66 MiB -> 402.64 MiB (-0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants