Skip to content

various cleanups of rustc_builtin_macros - #161464

Merged
rust-bors[bot] merged 12 commits into
rust-lang:mainfrom
cyrgani:builtin_macros_clean
Aug 26, 2026
Merged

various cleanups of rustc_builtin_macros#161464
rust-bors[bot] merged 12 commits into
rust-lang:mainfrom
cyrgani:builtin_macros_clean

Conversation

@cyrgani

@cyrgani cyrgani commented Aug 21, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

View all comments

Each commit should be reviewable on its own.

@rustbot

rustbot commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred in compiler/rustc_builtin_macros/src/autodiff.rs

cc @ZuseZ4

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 21, 2026
@rustbot

rustbot commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator

r? @mati865

rustbot has assigned @mati865.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 75 candidates
  • Random selection from 20 candidates

mati865
mati865 approved these changes Aug 24, 2026
View reviewed changes

@mati865 mati865 left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I don't expect perf changes but just to be sure: @bors try @rust-timer queue

View changes since this review

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Aug 24, 2026
@bors
Auto merge of #161464 - cyrgani:builtin_macros_clean, r=<try>
968c228 
various cleanups of `rustc_builtin_macros`
@mati865

mati865 commented Aug 24, 2026

Copy link
Copy Markdown
Member

That didn't work.
@rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 24, 2026
@rust-bors

rust-bors Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 968c228 (968c22862432b26073280c84ed44ab75d260da04)
Base parent: 347a1db (347a1dbf428ab92f284e3afafacfa7eb46341a5d)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer

rust-timer commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (968c228): comparison URL.

Overall result: ❌ regressions - please read:

Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf.

Next, please: If you can, justify the regressions found in this try perf run in writing along with @rustbot label: +perf-regression-triaged. If not, fix the regressions and do another perf run. Neutral or positive results will clear the label automatically.

@bors rollup=never rustc-perf
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 0.3% [0.2%, 0.4%] 9
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

This perf run didn't have relevant results for this metric.

Cycles

This perf run didn't have relevant results for this metric.

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 468.927s -> 468.523s (-0.09%)
Artifact size: 400.24 MiB -> 400.26 MiB (0.01%)

@rustbot rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Aug 24, 2026
@mati865

mati865 commented Aug 24, 2026

Copy link
Copy Markdown
Member

Very minor instruction count regressions but concentrated around a single benchmark, so likely not a random noise. Perhaps caused by smallvec?

@rustbot author

@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 24, 2026
@rustbot rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Aug 24, 2026
@rustbot

rustbot commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@cyrgani

cyrgani commented Aug 24, 2026

Copy link
Copy Markdown
Contributor Author

The smallvec change only applies to the derive macro infra though, and include-blob only calls the non-derive macros include_bytes!, concat!, env! and include_str!. I also can't reproduce this regression locally.

@mati865

mati865 commented Aug 25, 2026

Copy link
Copy Markdown
Member

Let's retry because I don't see how it could have happened either.
@rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 25, 2026
@mati865

mati865 commented Aug 25, 2026

Copy link
Copy Markdown
Member

@bors try

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Aug 25, 2026
@bors
Auto merge of #161464 - cyrgani:builtin_macros_clean, r=<try>
5e2a395 
various cleanups of `rustc_builtin_macros`
@rust-bors

rust-bors Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 5e2a395 (5e2a395361d4ee422cf33bb8cd60c49e35f593f1)
Base parent: b751e7a (b751e7a48501be14dcd57b4a430b73a0e51a0c52)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer

rust-timer commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (5e2a395): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

Benchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up.

@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 0.0% [0.0%, 0.0%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -0.1% [-0.1%, -0.1%] 1
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary -0.4%, secondary 0.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 1.6% [1.4%, 1.7%] 2
Regressions ❌
(secondary)		 2.8% [2.7%, 2.9%] 2
Improvements ✅
(primary)		 -1.7% [-2.3%, -1.2%] 3
Improvements ✅
(secondary)		 -2.1% [-2.8%, -1.4%] 2
All ❌✅ (primary) -0.4% [-2.3%, 1.7%] 5

Cycles

This perf run didn't have relevant results for this metric.

Binary size

Results (primary -0.0%, secondary -0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.0% [-0.0%, -0.0%] 4
Improvements ✅
(secondary)		 -0.0% [-0.0%, -0.0%] 2
All ❌✅ (primary) -0.0% [-0.0%, -0.0%] 4

Bootstrap: 477.576s -> 471.375s (-1.30%)
Artifact size: 400.35 MiB -> 400.40 MiB (0.01%)

@rustbot rustbot removed S-waiting-on-perf Status: Waiting on a perf run to be completed. perf-regression Performance regression. labels Aug 25, 2026
@mati865

mati865 commented Aug 25, 2026

Copy link
Copy Markdown
Member

Weirdly enough, the regression is gone.

@bors r+

@rust-bors

rust-bors Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

📌 Commit b84ba04 has been approved by mati865

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 25, 2026
@JonathanBrouwer

JonathanBrouwer commented Aug 25, 2026

Copy link
Copy Markdown
Member

@bors rollup
The include-blob benchmark is doing it's bimodal noise again

@JonathanBrouwer JonathanBrouwer mentioned this pull request Aug 25, 2026
Merged
rust-bors Bot pushed a commit that referenced this pull request Aug 25, 2026
@bors
Auto merge of #161783 - JonathanBrouwer:rollup-YKXQIPx, r=JonathanBro…
0f33d09 
…uwer

Rollup of 5 pull requests

Successful merges:

 - #161328 (Enforce even more library clippy lints in CI)
 - #161684 (Replace `Allocator + Clone` with `AllocatorClone` in btree)
 - #159232 (Don't list escaping bound regions in nested `for<...>` binders of E0308 notes)
 - #161464 (various cleanups of `rustc_builtin_macros`)
 - #161774 (Add codegen test for disjunction fed to unreachable_unchecked)
@rust-bors
rust-bors Bot merged commit 9032e91 into rust-lang:main Aug 26, 2026
14 checks passed
@rustbot rustbot added this to the 1.100.0 milestone Aug 26, 2026
rust-bors Bot pushed a commit that referenced this pull request Aug 26, 2026
@bors
Unrolled build for #161464 in rollup 161783
b352022 
Rollup merge of #161464 - cyrgani:builtin_macros_clean, r=mati865

various cleanups of `rustc_builtin_macros`

Each commit should be reviewable on its own.
@cyrgani
cyrgani deleted the builtin_macros_clean branch August 26, 2026 06:10
@cyrgani cyrgani mentioned this pull request Aug 27, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mati865 mati865 mati865 approved these changes

Assignees

@mati865 mati865

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.100.0

Development

Successfully merging this pull request may close these issues.

5 participants

@cyrgani @rustbot @mati865 @rust-timer @JonathanBrouwer