Skip to content

Remove cfg(not(no_global_oom_handling)) from the Drop impl of UniqueArcUninit#159652

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
maxdexh:bugfix/unique-arc-uninit-drop-oom
Jul 22, 2026
Merged

Remove cfg(not(no_global_oom_handling)) from the Drop impl of UniqueArcUninit#159652
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
maxdexh:bugfix/unique-arc-uninit-drop-oom

Conversation

@maxdexh

@maxdexh maxdexh commented Jul 21, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

Fixes #159651

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 21, 2026
@rustbot

rustbot commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

r? @Darksonn

rustbot has assigned @Darksonn.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: libs
  • libs expanded to 12 candidates
  • Random selection from 7 candidates

@maxdexh maxdexh changed the title Remove the cfg(not(no_global_oom_handling)) from Drop impl of UniqueArcUninit Remove cfg(not(no_global_oom_handling)) from the Drop impl of UniqueArcUninit Jul 21, 2026
Darksonn
Darksonn approved these changes Jul 21, 2026
View reviewed changes

@Darksonn Darksonn left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@bors r+ rollup

View changes since this review

@rust-bors

rust-bors Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 8ae35e2 has been approved by Darksonn

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 21, 2026
@maxdexh

maxdexh commented Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

Was very tough work to fix this

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jul 21, 2026
@JonathanBrouwer
Rollup merge of rust-lang#159652 - maxdexh:bugfix/unique-arc-uninit-d…
63002e1 
…rop-oom, r=Darksonn

Remove `cfg(not(no_global_oom_handling))` from the `Drop` impl of `UniqueArcUninit`

Fixes rust-lang#159651
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jul 21, 2026
Closed
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jul 21, 2026
@GuillaumeGomez
Rollup merge of rust-lang#159652 - maxdexh:bugfix/unique-arc-uninit-d…
de97bae 
…rop-oom, r=Darksonn

Remove `cfg(not(no_global_oom_handling))` from the `Drop` impl of `UniqueArcUninit`

Fixes rust-lang#159651
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jul 21, 2026
Closed
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jul 21, 2026
@GuillaumeGomez
Rollup merge of rust-lang#159652 - maxdexh:bugfix/unique-arc-uninit-d…
855d0c6 
…rop-oom, r=Darksonn

Remove `cfg(not(no_global_oom_handling))` from the `Drop` impl of `UniqueArcUninit`

Fixes rust-lang#159651
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jul 21, 2026
Closed
rust-bors Bot pushed a commit that referenced this pull request Jul 21, 2026
@bors
Auto merge of #159693 - GuillaumeGomez:rollup-rCWLy5Y, r=GuillaumeGomez
e3dd89a 
Rollup of 12 pull requests

Successful merges:

 - #159582 (Sync from portable simd 2026 07 20)
 - #158890 (Fix splat v0 mangling)
 - #159411 ([rustdoc] Correctly handle output options with --show-coverage)
 - #159647 (Remove `early_exit` closures)
 - #159656 (define a `Simd` type in `minicore`)
 - #156474 (Add paths for linked associated items)
 - #159211 (Fix debuginfo argument when invoking LLBC linker)
 - #159527 (Bring runtime symbols statics on par with foreign functions)
 - #159625 (Refactor is_opsem_inhabited)
 - #159652 (Remove `cfg(not(no_global_oom_handling))` from the `Drop` impl of `UniqueArcUninit`)
 - #159657 (Remove the blanket `#![cfg_attr(test, allow(unused))]` from bootstrap )
 - #159663 (Add layout cycle hang regression test)
jhpratt added a commit to jhpratt/rust that referenced this pull request Jul 22, 2026
@jhpratt
Rollup merge of rust-lang#159652 - maxdexh:bugfix/unique-arc-uninit-d…
bafb694 
…rop-oom, r=Darksonn

Remove `cfg(not(no_global_oom_handling))` from the `Drop` impl of `UniqueArcUninit`

Fixes rust-lang#159651
This was referenced Jul 22, 2026
Closed
Merged
rust-bors Bot pushed a commit that referenced this pull request Jul 22, 2026
@bors
Auto merge of #159697 - jhpratt:rollup-4WBEz7c, r=jhpratt
03cad56 
Rollup of 13 pull requests

Successful merges:

 - #159582 (Sync from portable simd 2026 07 20)
 - #158890 (Fix splat v0 mangling)
 - #159614 (debuginfo generation for unsafe binders)
 - #159647 (Remove `early_exit` closures)
 - #159656 (define a `Simd` type in `minicore`)
 - #156474 (Add paths for linked associated items)
 - #159211 (Fix debuginfo argument when invoking LLBC linker)
 - #159527 (Bring runtime symbols statics on par with foreign functions)
 - #159625 (Refactor is_opsem_inhabited)
 - #159629 (Add more splat rust-call regression tests)
 - #159652 (Remove `cfg(not(no_global_oom_handling))` from the `Drop` impl of `UniqueArcUninit`)
 - #159657 (Remove the blanket `#![cfg_attr(test, allow(unused))]` from bootstrap )
 - #159663 (Add layout cycle hang regression test)
rust-bors Bot pushed a commit that referenced this pull request Jul 22, 2026
@bors
Auto merge of #159697 - jhpratt:rollup-4WBEz7c, r=jhpratt
1af98b7 
Rollup of 13 pull requests

Successful merges:

 - #159582 (Sync from portable simd 2026 07 20)
 - #158890 (Fix splat v0 mangling)
 - #159614 (debuginfo generation for unsafe binders)
 - #159647 (Remove `early_exit` closures)
 - #159656 (define a `Simd` type in `minicore`)
 - #156474 (Add paths for linked associated items)
 - #159211 (Fix debuginfo argument when invoking LLBC linker)
 - #159527 (Bring runtime symbols statics on par with foreign functions)
 - #159625 (Refactor is_opsem_inhabited)
 - #159629 (Add more splat rust-call regression tests)
 - #159652 (Remove `cfg(not(no_global_oom_handling))` from the `Drop` impl of `UniqueArcUninit`)
 - #159657 (Remove the blanket `#![cfg_attr(test, allow(unused))]` from bootstrap )
 - #159663 (Add layout cycle hang regression test)
@rust-bors
rust-bors Bot merged commit 0bb7d37 into rust-lang:main Jul 22, 2026
13 checks passed
@rustbot rustbot added this to the 1.99.0 milestone Jul 22, 2026
rust-timer added a commit that referenced this pull request Jul 22, 2026
@rust-timer
Unrolled build for #159652
138b51c 
Rollup merge of #159652 - maxdexh:bugfix/unique-arc-uninit-drop-oom, r=Darksonn

Remove `cfg(not(no_global_oom_handling))` from the `Drop` impl of `UniqueArcUninit`

Fixes #159651
@maxdexh
maxdexh deleted the bugfix/unique-arc-uninit-drop-oom branch July 22, 2026 06:30
pull Bot pushed a commit to xtqqczze/rust-lang-miri that referenced this pull request Jul 22, 2026
@bors
Auto merge of #159697 - jhpratt:rollup-4WBEz7c, r=jhpratt
c4103d8 
Rollup of 13 pull requests

Successful merges:

 - rust-lang/rust#159582 (Sync from portable simd 2026 07 20)
 - rust-lang/rust#158890 (Fix splat v0 mangling)
 - rust-lang/rust#159614 (debuginfo generation for unsafe binders)
 - rust-lang/rust#159647 (Remove `early_exit` closures)
 - rust-lang/rust#159656 (define a `Simd` type in `minicore`)
 - rust-lang/rust#156474 (Add paths for linked associated items)
 - rust-lang/rust#159211 (Fix debuginfo argument when invoking LLBC linker)
 - rust-lang/rust#159527 (Bring runtime symbols statics on par with foreign functions)
 - rust-lang/rust#159625 (Refactor is_opsem_inhabited)
 - rust-lang/rust#159629 (Add more splat rust-call regression tests)
 - rust-lang/rust#159652 (Remove `cfg(not(no_global_oom_handling))` from the `Drop` impl of `UniqueArcUninit`)
 - rust-lang/rust#159657 (Remove the blanket `#![cfg_attr(test, allow(unused))]` from bootstrap )
 - rust-lang/rust#159663 (Add layout cycle hang regression test)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Darksonn Darksonn Darksonn approved these changes

Assignees

@Darksonn Darksonn

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.99.0

Development

Successfully merging this pull request may close these issues.

Drop impl of UniqueArcUninit is behind cfg(not(no_global_oom_handling))

3 participants

@maxdexh @rustbot @Darksonn