Add paths for linked associated items by qaijuang · Pull Request #156474 · rust-lang/rust

qaijuang · 2026-05-11T21:32:59Z

rustdoc-json emits intra-doc links to associated items using the associated item's id. For external associated items, that id is not present in index, and it was also missing from paths.

This PR backfills missing paths summaries for intra-doc link targets from the resolved page item and cached parent paths. Local targets are only added when already present in index, preserving jsondoclint's local-path invariant.

Fixes #152511

rustbot · 2026-05-12T05:29:20Z

These commits modify tests/rustdoc-json.
rustdoc-json is a public (but unstable) interface.

Please ensure that if you've changed the output:

It's intentional.
The FORMAT_VERSION in src/librustdoc-json-types is bumped if necessary.

cc @aDotInTheVoid, @obi1kenobi

rustbot · 2026-05-12T05:29:22Z

r? @lolbinarycat

rustbot has assigned @lolbinarycat.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: rustdoc
rustdoc expanded to 9 candidates
Random selection from GuillaumeGomez, camelid, fmease, lolbinarycat, notriddle

aDotInTheVoid · 2026-05-13T15:57:58Z

r? @aDotInTheVoid

aDotInTheVoid

Thanks for picking this up. Sorry for taking so long to get back to you.

View changes since this review

aDotInTheVoid · 2026-05-15T12:36:34Z

+        paths
+    }
+
+    #[allow(rustc::potential_query_instability)]


NIT: Could this attribute be more tightly scoped on the call causing the instability.

It's still not clear (to me) which call is causing the instability here.

This is the diag without it:

warning: using `values` can result in unstable query results --> src/librustdoc/json/mod.rs:137:48 | 137 | let links = self.cache.intra_doc_links.values(); | ^^^^^^ | = note: if you believe this case to be fine, allow this lint and add a comment explaining your rationale note: the lint level is defined here --> src/librustdoc/lib.rs:18:9 | 18 | #![warn(rustc::internal)] | ^^^^^^^^^^^^^^^ = note: `#[warn(rustc::potential_query_instability)]` implied by `#[warn(rustc::internal)]`

aDotInTheVoid · 2026-06-14T23:05:42Z

 //@ is "$.index[?(@.name=='non_page')].links['`Trait::method`']" $method

+// Regression test for <https://github.com/rust-lang/rust/issues/152511>:
+// link target IDs for associated items need matching `paths` entries.


I'd really like this to test that the ID's are also correct, but I think that would need something like #142479 to be able to express.

should we wait on #142479 ?

I think so, this implementation is hairy enough that I don't think it should be merged without more robust tests, to provide assurance of present and ongoing correctness.

makes sense

The IDs are still not tested, right?

Yes, unless @aDotInTheVoid says otherwise.

#142479 was merged, allowing to test IDs (which is the blocker for this PR). So what's blocking you?

Testing with the IDs which i landed in c78d0a7

Ah I see. Then looks good to me.

aDotInTheVoid · 2026-06-20T10:47:02Z

Blocked on #142479 (see #156474 (comment))

@rustbot blocked

I can no longer approve this (rust-lang/team#2523)

r? rustdoc-json-backend

rustbot · 2026-07-16T11:52:34Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

qaijuang · 2026-07-16T11:54:22Z

Blocked on #142479 (see #156474 (comment))

@rustbot blocked

I can no longer approve this (rust-lang/team#2523)

r? rustdoc-json-backend

@aDotInTheVoid I believe we're good to go with c78d0a7

GuillaumeGomez · 2026-07-21T15:32:43Z

@bors r=aDotInTheVoid,GuillaumeGomez rollup

rust-bors · 2026-07-21T15:32:46Z

📋 This PR cannot be approved because it currently has the following label: S-blocked.

GuillaumeGomez · 2026-07-21T15:33:50Z

Interesting, didn't know about this feature.

@bors r=aDotInTheVoid,GuillaumeGomez rollup

rust-bors · 2026-07-21T15:33:53Z

📌 Commit c78d0a7 has been approved by aDotInTheVoid,GuillaumeGomez

It is now in the queue for this repository.

…r=aDotInTheVoid,GuillaumeGomez Add paths for linked associated items rustdoc-json emits intra-doc links to associated items using the associated item's id. For external associated items, that id is not present in `index`, and it was also missing from `paths`. This PR backfills missing `paths` summaries for intra-doc link targets from the resolved page item and cached parent paths. Local targets are only added when already present in `index`, preserving jsondoclint's local-path invariant. Fixes rust-lang#152511

Rollup of 12 pull requests Successful merges: - #159582 (Sync from portable simd 2026 07 20) - #158890 (Fix splat v0 mangling) - #159411 ([rustdoc] Correctly handle output options with --show-coverage) - #159647 (Remove `early_exit` closures) - #159656 (define a `Simd` type in `minicore`) - #156474 (Add paths for linked associated items) - #159211 (Fix debuginfo argument when invoking LLBC linker) - #159527 (Bring runtime symbols statics on par with foreign functions) - #159625 (Refactor is_opsem_inhabited) - #159652 (Remove `cfg(not(no_global_oom_handling))` from the `Drop` impl of `UniqueArcUninit`) - #159657 (Remove the blanket `#![cfg_attr(test, allow(unused))]` from bootstrap ) - #159663 (Add layout cycle hang regression test)

…r=aDotInTheVoid,GuillaumeGomez Add paths for linked associated items rustdoc-json emits intra-doc links to associated items using the associated item's id. For external associated items, that id is not present in `index`, and it was also missing from `paths`. This PR backfills missing `paths` summaries for intra-doc link targets from the resolved page item and cached parent paths. Local targets are only added when already present in `index`, preserving jsondoclint's local-path invariant. Fixes rust-lang#152511

Rollup of 13 pull requests Successful merges: - #159582 (Sync from portable simd 2026 07 20) - #158890 (Fix splat v0 mangling) - #159614 (debuginfo generation for unsafe binders) - #159647 (Remove `early_exit` closures) - #159656 (define a `Simd` type in `minicore`) - #156474 (Add paths for linked associated items) - #159211 (Fix debuginfo argument when invoking LLBC linker) - #159527 (Bring runtime symbols statics on par with foreign functions) - #159625 (Refactor is_opsem_inhabited) - #159629 (Add more splat rust-call regression tests) - #159652 (Remove `cfg(not(no_global_oom_handling))` from the `Drop` impl of `UniqueArcUninit`) - #159657 (Remove the blanket `#![cfg_attr(test, allow(unused))]` from bootstrap ) - #159663 (Add layout cycle hang regression test)

Rollup merge of #156474 - qaijuang:rustdoc-json-link-paths, r=aDotInTheVoid,GuillaumeGomez Add paths for linked associated items rustdoc-json emits intra-doc links to associated items using the associated item's id. For external associated items, that id is not present in `index`, and it was also missing from `paths`. This PR backfills missing `paths` summaries for intra-doc link targets from the resolved page item and cached parent paths. Local targets are only added when already present in `index`, preserving jsondoclint's local-path invariant. Fixes #152511

Rollup of 13 pull requests Successful merges: - rust-lang/rust#159582 (Sync from portable simd 2026 07 20) - rust-lang/rust#158890 (Fix splat v0 mangling) - rust-lang/rust#159614 (debuginfo generation for unsafe binders) - rust-lang/rust#159647 (Remove `early_exit` closures) - rust-lang/rust#159656 (define a `Simd` type in `minicore`) - rust-lang/rust#156474 (Add paths for linked associated items) - rust-lang/rust#159211 (Fix debuginfo argument when invoking LLBC linker) - rust-lang/rust#159527 (Bring runtime symbols statics on par with foreign functions) - rust-lang/rust#159625 (Refactor is_opsem_inhabited) - rust-lang/rust#159629 (Add more splat rust-call regression tests) - rust-lang/rust#159652 (Remove `cfg(not(no_global_oom_handling))` from the `Drop` impl of `UniqueArcUninit`) - rust-lang/rust#159657 (Remove the blanket `#![cfg_attr(test, allow(unused))]` from bootstrap ) - rust-lang/rust#159663 (Add layout cycle hang regression test)

rustbot added A-rustdoc-json Area: Rustdoc JSON backend S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels May 11, 2026

qaijuang marked this pull request as ready for review May 12, 2026 05:29

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 12, 2026

rustbot assigned lolbinarycat May 12, 2026

rustbot assigned aDotInTheVoid and unassigned lolbinarycat May 13, 2026

aDotInTheVoid reviewed Jun 14, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

qaijuang force-pushed the rustdoc-json-link-paths branch from a6a1fe3 to 3003031 Compare June 15, 2026 11:32

This comment has been minimized.

Sign in to view

rustbot assigned GuillaumeGomez and unassigned aDotInTheVoid Jun 20, 2026

qaijuang added 3 commits July 16, 2026 07:35

rustdoc-json: add paths for linked associated items

0a63dc6

address suggested nits

08fb51a

test with IDs as suggested

c78d0a7

qaijuang force-pushed the rustdoc-json-link-paths branch from 3003031 to c78d0a7 Compare July 16, 2026 11:52

GuillaumeGomez approved these changes Jul 21, 2026

View reviewed changes

GuillaumeGomez removed the S-blocked Status: Blocked on something else such as an RFC or other implementation work. label Jul 21, 2026

rust-bors Bot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jul 21, 2026

JonathanBrouwer mentioned this pull request Jul 21, 2026

Rollup of 10 pull requests #159684

Closed

GuillaumeGomez mentioned this pull request Jul 21, 2026

Rollup of 11 pull requests #159692

Closed

GuillaumeGomez mentioned this pull request Jul 21, 2026

Rollup of 12 pull requests #159693

Closed

This was referenced Jul 22, 2026

Rollup of 13 pull requests #159696

Closed

Rollup of 13 pull requests #159697

Merged

rust-bors Bot merged commit 38d03cc into rust-lang:main Jul 22, 2026
13 checks passed

rustbot added this to the 1.99.0 milestone Jul 22, 2026

qaijuang deleted the rustdoc-json-link-paths branch July 22, 2026 10:13

gifnksm mentioned this pull request Jul 24, 2026

Rustdoc-Json: some item IDs are missing in paths field. #101687

Closed

Uh oh!

Uh oh!

Conversation

qaijuang commented May 11, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented May 12, 2026

Uh oh!

rustbot commented May 12, 2026

Uh oh!

aDotInTheVoid commented May 13, 2026

Uh oh!

aDotInTheVoid left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

aDotInTheVoid commented Jun 20, 2026

Uh oh!

rustbot commented Jul 16, 2026

Uh oh!

qaijuang commented Jul 16, 2026

Uh oh!

GuillaumeGomez commented Jul 21, 2026

Uh oh!

rust-bors Bot commented Jul 21, 2026

Uh oh!

GuillaumeGomez commented Jul 21, 2026

Uh oh!

rust-bors Bot commented Jul 21, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

qaijuang commented May 11, 2026 •

edited by rustbot

Loading

aDotInTheVoid left a comment •

edited by rustbot

Loading