Only force backtraces when a panic occurs in bootstrap#159270
Merged
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
r? @jieyouxu rustbot has assigned @jieyouxu. Use Why was this reviewer chosen?The reviewer was selected based on:
|
jieyouxu
approved these changes
Jul 15, 2026
Contributor
rust-bors
Bot
added
S-waiting-on-bors
rust-bors Bot
pushed a commit
that referenced
this pull request
Jul 15, 2026
Rollup of 5 pull requests Successful merges: - #156712 (Pointer authentication config and user facing options) - #158522 (Lint against invalid POSIX symbol definitions) - #159229 (ast_lowering: Reject invalid direct_const_arg owners) - #159270 (Only force backtraces when a panic occurs in bootstrap) - #159308 (Reorganize `tests/ui/issues` [24/N])
rust-timer
added a commit
that referenced
this pull request
Jul 15, 2026
Rollup merge of #159270 - Kobzol:bootstrap-panic, r=jieyouxu Only force backtraces when a panic occurs in bootstrap In #159040, I forced a backtrace to be printed in bootstrap when a panic happens. However, since bootstrap also captures backtraces manually during command execution, this meant that backtraces started to be printed during "normal" bootstrap failures (e.g. if tidy returned a failure), which is annoying. This PR changes it so that the override only happens ona actual panics. Note: bootstrap still uses a lot of panics for "normal" error conditions during a build, rather than for actual bugs or weird bootstrap situations. Those should ideally be replaced with `exit!(1)`.
pull Bot
pushed a commit
to LeeeeeeM/miri
that referenced
this pull request
Jul 16, 2026
Rollup of 5 pull requests Successful merges: - rust-lang/rust#156712 (Pointer authentication config and user facing options) - rust-lang/rust#158522 (Lint against invalid POSIX symbol definitions) - rust-lang/rust#159229 (ast_lowering: Reject invalid direct_const_arg owners) - rust-lang/rust#159270 (Only force backtraces when a panic occurs in bootstrap) - rust-lang/rust#159308 (Reorganize `tests/ui/issues` [24/N])
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #159040, I forced a backtrace to be printed in bootstrap when a panic happens. However, since bootstrap also captures backtraces manually during command execution, this meant that backtraces started to be printed during "normal" bootstrap failures (e.g. if tidy returned a failure), which is annoying.
This PR changes it so that the override only happens ona actual panics.
Note: bootstrap still uses a lot of panics for "normal" error conditions during a build, rather than for actual bugs or weird bootstrap situations. Those should ideally be replaced with
exit!(1).