Skip to content

Pointer authentication config and user facing options#156712

Merged
rust-bors[bot] merged 5 commits into
rust-lang:mainfrom
jchlanda:jakub/pac_config
Jul 15, 2026
Merged

Pointer authentication config and user facing options#156712
rust-bors[bot] merged 5 commits into
rust-lang:mainfrom
jchlanda:jakub/pac_config

Conversation

@jchlanda

@jchlanda jchlanda commented May 18, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

View all comments

This patch brings:

  • unified handling of pointer authentication options through:
    -Zpointer-authentication, with possible values:
    aarch64-jump-table-hardening, auth-traps, calls, elf-got,
    function-pointer-type-discrimination, indirect-gotos, init-fini,
    init-fini-address-discrimination, return-addresses. Toggled with
    +/-.
  • centralized handling of pointer authentication features. Session holds
    pointer_auth_config: Option<PointerAuthConfig>
  • encapsulation of schema for function pointers and init/fini through
    PointerAuthSchema. This allowed for retiring of PacMetadata.
  • refactor enabling of pointer authentication in code, instead of
    relying on the target (pauthtest) use the session

@rustbot rustbot added A-compiletest Area: The compiletest test runner A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-run-make Area: port run-make Makefiles to rmake.rs A-test-infra-minicore Area: `minicore` test auxiliary and `//@ add-core-stubs` A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels May 18, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jchlanda
jchlanda force-pushed the jakub/pac_config branch from 77fe412 to b0a7e47 Compare May 18, 2026 13:15
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jchlanda
jchlanda force-pushed the jakub/pac_config branch from b0a7e47 to 4e8d9e3 Compare May 18, 2026 13:23
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jchlanda
jchlanda force-pushed the jakub/pac_config branch from 4e8d9e3 to 418f447 Compare May 18, 2026 13:39
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jchlanda
jchlanda force-pushed the jakub/pac_config branch from 418f447 to 6af45da Compare May 18, 2026 14:26
@jchlanda

jchlanda commented May 19, 2026

Copy link
Copy Markdown
Contributor Author

@davidtwco, @folkertdev, @tgross35, @madsmtm FWI this is a follow up to #155722 and #156548
This will have to be rebased once the above are merged.

@jchlanda
jchlanda marked this pull request as ready for review May 19, 2026 12:17
@rustbot

rustbot commented May 19, 2026

Copy link
Copy Markdown
Collaborator

This PR modifies src/bootstrap/src/core/config.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

Some changes occurred in src/tools/compiletest

cc @jieyouxu

The GCC codegen subtree was changed

cc @antoyo, @GuillaumeGomez

compiletest directives have been modified. Please add or update docs for the
new or modified directive in src/doc/rustc-dev-guide/.

Some changes occurred in src/doc/rustc/src/platform-support

cc @Noratrieb

This PR modifies tests/auxiliary/minicore.rs.

cc @jieyouxu

These commits modify compiler targets.
(See the Target Tier Policy.)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 19, 2026
@rustbot

rustbot commented May 19, 2026

Copy link
Copy Markdown
Collaborator

r? @mejrs

rustbot has assigned @mejrs.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 73 candidates
  • Random selection from 20 candidates

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jchlanda
jchlanda force-pushed the jakub/pac_config branch from 82f7a40 to 1c7ac6d Compare May 20, 2026 14:41
@jchlanda jchlanda mentioned this pull request May 21, 2026
Closed
@rust-bors

This comment has been minimized.

Sign in to view
@mejrs

mejrs commented May 24, 2026

Copy link
Copy Markdown
Contributor

Hi, I am not qualified to review this.

r? madsmtm or reroll maybe

@rust-bors rust-bors Bot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jul 13, 2026
@rust-bors

rust-bors Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

This pull request was unapproved.

This PR was contained in a rollup (#159231), which was unapproved.

View changes since this unapproval

@jchlanda

jchlanda commented Jul 13, 2026

Copy link
Copy Markdown
Contributor Author

@bors r- Soft conflict with #159231 (comment)

I'm not sure why it complains about the line length, both files have the // ignore-tidy-linelength

@rustbot

This comment has been minimized.

Sign in to view
@jchlanda

jchlanda commented Jul 14, 2026

Copy link
Copy Markdown
Contributor Author

@bors r- Soft conflict with #159231 (comment)

I'm not sure why it complains about the line length, both files have the // ignore-tidy-linelength

I see it now, updated to // ignore-tidy-file-linelength in 1fe1cae

@rust-bors

This comment has been minimized.

Sign in to view
jchlanda added 2 commits July 14, 2026 08:48
@jchlanda
Pointer authentication config and user facing options
abd56e9 
This patch brings:
* unified handling of pointer authentication options through:
  `-Zpointer-authentication`, with possible values:
  `aarch64-jump-table-hardening`, `auth-traps`, `calls`, `elf-got`,
  `function-pointer-type-discrimination`, `indirect-gotos`, `init-fini`,
  `init-fini-address-discrimination`, `return-addresses`. Toggled with
  `+`/`-`.
* centralized handling of pointer authentication features. Session holds
  `pointer_auth_config: Option<PointerAuthConfig>`
* encapsulation of schema for function pointers and init/fini through
  `PointerAuthSchema`. This allowed for retiring of `PacMetadata`.
* refactor enabling of pointer authentication in code, instead of
  relying on the target (`pauthtest`) use the session
@jchlanda
Extend version support with C++ specifics
03e9cf1
@rustbot

rustbot commented Jul 14, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
jchlanda added 3 commits July 14, 2026 09:13
@jchlanda
Document -Zpointer-authentication option
00f9612
@jchlanda
Convert -Zpointer-authentication to target modifier
f283bde 
Also improve the API design of pointer_authentication_functions, by
making it return Option<&PointerAuthSchema>, rather than bool.
@jchlanda
Update tests to use // ignore-tidy-file-linelength
ae91cf7
@jchlanda

jchlanda commented Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

@JonathanBrouwer, I'm not sure what the procedure is, but I believe that the conflict is now resolved and this patch should be ready to land. Thank you.

@JonathanBrouwer

JonathanBrouwer commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

@bors r=davidtwco

@rust-bors

rust-bors Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

📌 Commit ae91cf7 has been approved by davidtwco

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 15, 2026
@rust-bors

rust-bors Bot commented Jul 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

⌛ Testing commit ae91cf7 with merge 3ba9884...

Workflow: https://github.com/rust-lang/rust/actions/runs/29407184653

rust-bors Bot pushed a commit that referenced this pull request Jul 15, 2026
@bors
Auto merge of #156712 - jchlanda:jakub/pac_config, r=davidtwco
3ba9884 
Pointer authentication config and user facing options



This patch brings:
* unified handling of pointer authentication options through:
  `-Zpointer-authentication`, with possible values:
  `aarch64-jump-table-hardening`, `auth-traps`, `calls`, `elf-got`,
  `function-pointer-type-discrimination`, `indirect-gotos`, `init-fini`,
  `init-fini-address-discrimination`, `return-addresses`. Toggled with
  `+`/`-`.
* centralized handling of pointer authentication features. Session holds
  `pointer_auth_config: Option<PointerAuthConfig>`
* encapsulation of schema for function pointers and init/fini through
  `PointerAuthSchema`. This allowed for retiring of `PacMetadata`.
* refactor enabling of pointer authentication in code, instead of
  relying on the target (`pauthtest`) use the session
@jhpratt jhpratt mentioned this pull request Jul 15, 2026
Merged
@jhpratt

jhpratt commented Jul 15, 2026

Copy link
Copy Markdown
Member

Yielding to encompassing rollup

@bors yield

@rust-bors

rust-bors Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Auto build was cancelled. Cancelled workflows:

The next pull request likely to be tested is #159325.

rust-bors Bot pushed a commit that referenced this pull request Jul 15, 2026
@bors
Auto merge of #159325 - jhpratt:rollup-wVbUouH, r=jhpratt
df1ae0f 
Rollup of 5 pull requests

Successful merges:

 - #156712 (Pointer authentication config and user facing options)
 - #158522 (Lint against invalid POSIX symbol definitions)
 - #159229 (ast_lowering: Reject invalid direct_const_arg owners)
 - #159270 (Only force backtraces when a panic occurs in bootstrap)
 - #159308 (Reorganize `tests/ui/issues` [24/N])
@rust-bors
rust-bors Bot merged commit 7347c6d into rust-lang:main Jul 15, 2026
13 of 14 checks passed
rust-timer added a commit that referenced this pull request Jul 15, 2026
@rust-timer
Unrolled build for #156712
0694e48 
Rollup merge of #156712 - jchlanda:jakub/pac_config, r=davidtwco

Pointer authentication config and user facing options

This patch brings:
* unified handling of pointer authentication options through:
  `-Zpointer-authentication`, with possible values:
  `aarch64-jump-table-hardening`, `auth-traps`, `calls`, `elf-got`,
  `function-pointer-type-discrimination`, `indirect-gotos`, `init-fini`,
  `init-fini-address-discrimination`, `return-addresses`. Toggled with
  `+`/`-`.
* centralized handling of pointer authentication features. Session holds
  `pointer_auth_config: Option<PointerAuthConfig>`
* encapsulation of schema for function pointers and init/fini through
  `PointerAuthSchema`. This allowed for retiring of `PacMetadata`.
* refactor enabling of pointer authentication in code, instead of
  relying on the target (`pauthtest`) use the session
@rustbot rustbot added this to the 1.99.0 milestone Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@madsmtm madsmtm madsmtm left review comments
@bjorn3 bjorn3 bjorn3 left review comments
@davidtwco davidtwco davidtwco approved these changes
+1 more reviewer
@kovdan01 kovdan01 kovdan01 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@madsmtm madsmtm

Labels

A-compiletest Area: The compiletest test runner A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-run-make Area: port run-make Makefiles to rmake.rs A-test-infra-minicore Area: `minicore` test auxiliary and `//@ add-core-stubs` A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.99.0

Development

Successfully merging this pull request may close these issues.

Unify handling of pointer authentication features

10 participants

@jchlanda @rust-log-analyzer @rustbot @mejrs @davidtwco @JonathanBrouwer @jhpratt @madsmtm @bjorn3 @kovdan01