bootstrap.example.toml: Hint how to allow build.warnings#154437
Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom Mar 28, 2026
Merged
bootstrap.example.toml: Hint how to allow build.warnings#154437rust-bors[bot] merged 1 commit intorust-lang:mainfrom
build.warnings#154437rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Conversation
This commit turns "Actual" into "Expected" for the following problem: Steps: 1. Do some quick and experimental local code changes in the compiler code. 2. Run `./x build`. 3. Observe `error: warnings are denied by `build.warnings` configuration`. 4. Decide to not care and want to allow warnings. 5. Search for `build.warnings` in **bootstrap.example.toml** Actual: No hits. You get frustrated because didn't learn how to allow warnings. Expected: You get a hit and can easily see how to allow warnings.
Collaborator
|
This PR modifies If appropriate, please update |
rustbot
added
S-waiting-on-review
Collaborator
|
r? @jieyouxu rustbot has assigned @jieyouxu. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Enselic
added
the
A-contributor-roadblock
jieyouxu
approved these changes
Mar 27, 2026
Contributor
rust-bors
bot
added
S-waiting-on-bors
rust-bors bot
pushed a commit
that referenced
this pull request
Mar 27, 2026
Rollup of 10 pull requests Successful merges: - #154070 (Unstable book options parser) - #154371 (Use LocalDefId for more tcx method calls) - #154405 (Improve doc comment unicode guidance) - #154431 (Avoid ICE in explicit reference cast suggestion for unrelated leaf pr…) - #153528 (Fix LegacyKeyValueFormat report from docker build: mips) - #154246 (Add test for issue #101532: dead code warnings in const _) - #154421 (Rustdoc rejects html emits with json output) - #154428 (bootstrap: `-Zjson-target-spec` for synthetic targets) - #154437 (bootstrap.example.toml: Hint how to allow `build.warnings`) - #154454 (fix: [rustfmt] prevent panic when rewritng associated item delegations) Failed merges: - #154450 (Use the normal arg-parsing machinery for `-Zassert-incr-state`)
rust-bors bot
pushed a commit
that referenced
this pull request
Mar 27, 2026
Rollup of 10 pull requests Successful merges: - #154070 (Unstable book options parser) - #154371 (Use LocalDefId for more tcx method calls) - #154405 (Improve doc comment unicode guidance) - #154431 (Avoid ICE in explicit reference cast suggestion for unrelated leaf pr…) - #153528 (Fix LegacyKeyValueFormat report from docker build: mips) - #154246 (Add test for issue #101532: dead code warnings in const _) - #154421 (Rustdoc rejects html emits with json output) - #154428 (bootstrap: `-Zjson-target-spec` for synthetic targets) - #154437 (bootstrap.example.toml: Hint how to allow `build.warnings`) - #154454 (fix: [rustfmt] prevent panic when rewritng associated item delegations) Failed merges: - #154450 (Use the normal arg-parsing machinery for `-Zassert-incr-state`)
rust-timer
added a commit
that referenced
this pull request
Mar 28, 2026
Rollup merge of #154437 - Enselic:build.warnings, r=jieyouxu bootstrap.example.toml: Hint how to allow `build.warnings` This commit turns **Actual** into **Expected** for the following problem: ### Steps 1. Do some quick and experimental local code changes in the compiler code. 2. Run `./x build`. 3. Observe failed build with _"error: warnings are denied by `build.warnings` configuration"_. 4. Decide to not care and want to allow warnings. 5. Search for `build.warnings` in **bootstrap.example.toml**. ### Actual No hits. You get frustrated because didn't learn how to allow warnings. (The reason `build.warnings` is not mentioned in **bootstrap.example.toml** is of course because it is an unstable cargo [feature](https://doc.rust-lang.org/cargo/reference/unstable.html#buildwarnings) and not controlled by bootstrap, but you don't know that yet.) ### Expected You get a hit and can easily see how to allow warnings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit turns Actual into Expected for the following problem:
Steps
./x build.build.warningsconfiguration".build.warningsin bootstrap.example.toml.Actual
No hits. You get frustrated because didn't learn how to allow warnings. (The reason
build.warningsis not mentioned in bootstrap.example.toml is of course because it is an unstable cargo feature and not controlled by bootstrap, but you don't know that yet.)Expected
You get a hit and can easily see how to allow warnings.