Add test for issue #101532: dead code warnings in const _#154246
Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom Mar 28, 2026
Merged
Add test for issue #101532: dead code warnings in const _#154246rust-bors[bot] merged 1 commit intorust-lang:mainfrom
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
JumpiiX
force-pushed
the
fix-101532-dead-code-warnings
branch
from
ebdf48f to
0b9eac8
Compare
This comment has been minimized.
This comment has been minimized.
JumpiiX
force-pushed
the
fix-101532-dead-code-warnings
branch
from
0b9eac8 to
6d8bcd1
Compare
This comment has been minimized.
This comment has been minimized.
JumpiiX
force-pushed
the
fix-101532-dead-code-warnings
branch
from
6d8bcd1 to
4975cd0
Compare
This comment has been minimized.
This comment has been minimized.
JumpiiX
force-pushed
the
fix-101532-dead-code-warnings
branch
from
4975cd0 to
d06b0db
Compare
This comment has been minimized.
This comment has been minimized.
JumpiiX
force-pushed
the
fix-101532-dead-code-warnings
branch
from
d06b0db to
cb34b4e
Compare
This comment has been minimized.
This comment has been minimized.
JumpiiX
force-pushed
the
fix-101532-dead-code-warnings
branch
from
cb34b4e to
1017004
Compare
This comment has been minimized.
This comment has been minimized.
Tests that dead code warnings work correctly inside const _ blocks. Issue was already fixed, adding regression test as requested.
JumpiiX
force-pushed
the
fix-101532-dead-code-warnings
branch
from
1017004 to
36c22f7
Compare
Member
|
It looks good to me :) However, unfortunately, I don't have roll-up permission, so you'll have to wait for the designated reviewer, fmease. Additionally, please refrain from using LLM when writing PR descriptions. |
Contributor
Author
|
Thanks for the response @reddevilmidzy , appreciate it! |
fmease
approved these changes
Mar 27, 2026
Contributor
rust-bors
bot
added
S-waiting-on-bors
rust-bors bot
pushed a commit
that referenced
this pull request
Mar 27, 2026
Rollup of 10 pull requests Successful merges: - #154070 (Unstable book options parser) - #154371 (Use LocalDefId for more tcx method calls) - #154405 (Improve doc comment unicode guidance) - #154431 (Avoid ICE in explicit reference cast suggestion for unrelated leaf pr…) - #153528 (Fix LegacyKeyValueFormat report from docker build: mips) - #154246 (Add test for issue #101532: dead code warnings in const _) - #154421 (Rustdoc rejects html emits with json output) - #154428 (bootstrap: `-Zjson-target-spec` for synthetic targets) - #154437 (bootstrap.example.toml: Hint how to allow `build.warnings`) - #154454 (fix: [rustfmt] prevent panic when rewritng associated item delegations) Failed merges: - #154450 (Use the normal arg-parsing machinery for `-Zassert-incr-state`)
rust-bors bot
pushed a commit
that referenced
this pull request
Mar 27, 2026
Rollup of 10 pull requests Successful merges: - #154070 (Unstable book options parser) - #154371 (Use LocalDefId for more tcx method calls) - #154405 (Improve doc comment unicode guidance) - #154431 (Avoid ICE in explicit reference cast suggestion for unrelated leaf pr…) - #153528 (Fix LegacyKeyValueFormat report from docker build: mips) - #154246 (Add test for issue #101532: dead code warnings in const _) - #154421 (Rustdoc rejects html emits with json output) - #154428 (bootstrap: `-Zjson-target-spec` for synthetic targets) - #154437 (bootstrap.example.toml: Hint how to allow `build.warnings`) - #154454 (fix: [rustfmt] prevent panic when rewritng associated item delegations) Failed merges: - #154450 (Use the normal arg-parsing machinery for `-Zassert-incr-state`)
rust-timer
added a commit
that referenced
this pull request
Mar 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #101532
Adds a test for dead code warnings in
const _.This was already fixed, just adding coverage to avoid regressions.