use minicore more in testing inline assembly#154277
Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom Mar 24, 2026
Merged
use minicore more in testing inline assembly#154277rust-bors[bot] merged 1 commit intorust-lang:mainfrom
minicore more in testing inline assembly#154277rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
A-test-infra-minicore
This comment has been minimized.
This comment has been minimized.
folkertdev
force-pushed
the
ui-asm-minicore
branch
from
d53c7d0 to
6df99d6
Compare
rustbot
added
the
S-waiting-on-review
Collaborator
|
This PR modifies cc @jieyouxu |
rustbot
removed
the
S-waiting-on-author
Member
|
@bors try |
This comment has been minimized.
This comment has been minimized.
rust-bors bot
pushed a commit
that referenced
this pull request
Mar 24, 2026
use `minicore` more in testing inline assembly try-job: aarch64-gnu try-job: x86_64-gnu try-job: x86_64-gnu-debug
Contributor
jieyouxu
reviewed
Mar 24, 2026
|
|
||
| // Checks that inline asm errors are mapped to the correct line in the source code. | ||
|
|
||
| #[unsafe(no_mangle)] |
Member
There was a problem hiding this comment.
Question: these no_mangle changes I'm less sure about. Can you say more on why the no_mangle is needed? To have a reproducible symbol name?
Contributor
Author
There was a problem hiding this comment.
Without it the test will fail with
---- [ui] tests/ui/asm/aarch64/srcloc.rs stdout ----
error: ui test did not emit an error
note: by default, ui tests are expected not to compile.
hint: use check-pass, build-pass, or run-pass directive to change this behavior.
status: exit status: 0
because the function is not considered reachable the errors in it are not emitted. using no_mangle forces the function to be reachable. using pub would work too in this case.
Member
There was a problem hiding this comment.
Ah, right. Thanks for clarifying.
rustbot
added
S-waiting-on-author
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
folkertdev
commented
Mar 24, 2026
Contributor
Author
There was a problem hiding this comment.
@rustbot ready
I guess, anyway. There are other ways to make a function reachable but no_mangle is the most reliable one in my experience.
rustbot
added
S-waiting-on-review
Member
|
Thanks |
Contributor
rust-bors
bot
added
S-waiting-on-bors
rust-bors bot
pushed a commit
that referenced
this pull request
Mar 24, 2026
…uwer Rollup of 5 pull requests Successful merges: - #152710 (Unalign `PackedFingerprint` on all hosts, not just x86 and x86-64) - #153874 (constify const Fn*: Destruct) - #154097 (improve validation error messages: show surrounding type) - #154277 (use `minicore` more in testing inline assembly) - #154293 (Use verbose span suggestion for type const)
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Mar 25, 2026
…uwer Rollup of 5 pull requests Successful merges: - rust-lang/rust#152710 (Unalign `PackedFingerprint` on all hosts, not just x86 and x86-64) - rust-lang/rust#153874 (constify const Fn*: Destruct) - rust-lang/rust#154097 (improve validation error messages: show surrounding type) - rust-lang/rust#154277 (use `minicore` more in testing inline assembly) - rust-lang/rust#154293 (Use verbose span suggestion for type const)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both for easier development and because some niche assembly features were only tested on one platform.
try-job: aarch64-gnu
try-job: x86_64-gnu
try-job: x86_64-gnu-debug