improve validation error messages: show surrounding type#154097
Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom Mar 24, 2026
Merged
improve validation error messages: show surrounding type#154097rust-bors[bot] merged 1 commit intorust-lang:mainfrom
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Conversation
Collaborator
rustbot
added
S-waiting-on-review
Collaborator
|
|
This comment has been minimized.
This comment has been minimized.
RalfJung
force-pushed
the
validity-error
branch
from
dfd5623 to
b2bd21c
Compare
…fo on dyn-downcast
RalfJung
force-pushed
the
validity-error
branch
from
b2bd21c to
05834b2
Compare
oli-obk
approved these changes
Mar 24, 2026
Contributor
|
@bors r+ |
Contributor
rust-bors
bot
added
S-waiting-on-bors
rust-bors bot
pushed a commit
that referenced
this pull request
Mar 24, 2026
…uwer Rollup of 5 pull requests Successful merges: - #152710 (Unalign `PackedFingerprint` on all hosts, not just x86 and x86-64) - #153874 (constify const Fn*: Destruct) - #154097 (improve validation error messages: show surrounding type) - #154277 (use `minicore` more in testing inline assembly) - #154293 (Use verbose span suggestion for type const)
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Mar 25, 2026
…uwer Rollup of 5 pull requests Successful merges: - rust-lang/rust#152710 (Unalign `PackedFingerprint` on all hosts, not just x86 and x86-64) - rust-lang/rust#153874 (constify const Fn*: Destruct) - rust-lang/rust#154097 (improve validation error messages: show surrounding type) - rust-lang/rust#154277 (use `minicore` more in testing inline assembly) - rust-lang/rust#154293 (Use verbose span suggestion for type const)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, for dyn-downcast show the type we're downcasting to.
r? @oli-obk