Move ui/issues tests to relevant subdirectories by kyleecodes · Pull Request #154233 · rust-lang/rust

kyleecodes · 2026-03-23T03:00:15Z

Related to #133895 and Reorganisation of tests/ui/issues for GSOC

This is the first PR in a batch of PRs.

Moves ui/issues/issue-17546.rs‎ ‎-> ui/variants/variant-result-noresult-used-as-type.rs

Approach:

Check linked issue and test contents, determine new target directory
Move / rename tests to reflect purpose.
Add issue link / comments in separate commit.
Rebless if necessary and remove obsolete stderr.

r? @Kivooeo

rustbot · 2026-03-23T03:00:21Z

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 69 candidates
Random selection from 12 candidates

kyleecodes · 2026-03-23T05:55:08Z

Marked draft to modify the target directory.

Also, I'll keep all commit msgs the same format moving forward. Happy to fix that here if needed.

zedddie · 2026-03-23T17:02:09Z

tests/ui/variants/variant-result-noresult-used-as-type.stderr

Hey! you don't need to bless in the first (move) commit, since you'll rebless anyway after adding metadata in the next one (and the move commit should only consist of moves.) . It makes less noise in the diff if you just move first, then bless + add metadata together.

Makes sense, with issue links updating stderr line numbers. I'll update my approach to separate the move, then commit rebless with metadata / code changes.

Kivooeo · 2026-03-25T00:35:00Z

@bors squash

* tests(ui): migrate issues/issue-17546 to ui/resolve * tests(ui): add gh issue link * tests(ui/issues): move tests to variants dir

rust-bors · 2026-03-25T00:35:20Z

🔨 3 commits were squashed into 62ba3c1.

rust-bors · 2026-03-25T00:35:25Z

🔨 3 commits were squashed into 62ba3c1.

Kivooeo · 2026-03-25T00:36:38Z

@bors r+ rollup

rust-bors · 2026-03-25T00:36:41Z

📌 Commit 62ba3c1 has been approved by Kivooeo

It is now in the queue for this repository.

@Kivooeo

…r=Kivooeo Move ui/issues tests to relevant subdirectories Related to rust-lang#133895 and [Reorganisation of tests/ui/issues for GSOC](https://github.com/rust-lang/google-summer-of-code?tab=readme-ov-file#reorganisation-of-testsuiissues) This is the first PR in a batch of PRs. Moves `ui/issues/issue-17546.rs‎` ‎-> `ui/variants/variant-result-noresult-used-as-type.rs` Approach: 1. Check linked issue and test contents, determine new target directory 2. Move / rename tests to reflect purpose. 3. Add issue link / comments in separate commit. 4. Rebless if necessary and remove obsolete stderr. r? @Kivooeo

Rollup of 6 pull requests Successful merges: - #154004 (`Alignment`: move from `ptr` to `mem` and rename `as_nonzero` to `as_nonzero_usize`) - #153049 (Add `-Zsanitize=kernel-hwaddress`) - #154269 (miri recursive validation: only check one layer deep) - #154112 (some `tests/ui/macros` cleanup) - #154131 (begin `tests/ui/structs-enums` cleanup) - #154233 (Move ui/issues tests to relevant subdirectories)

@Kivooeo

…r=Kivooeo Move ui/issues tests to relevant subdirectories Related to rust-lang#133895 and [Reorganisation of tests/ui/issues for GSOC](https://github.com/rust-lang/google-summer-of-code?tab=readme-ov-file#reorganisation-of-testsuiissues) This is the first PR in a batch of PRs. Moves `ui/issues/issue-17546.rs‎` ‎-> `ui/variants/variant-result-noresult-used-as-type.rs` Approach: 1. Check linked issue and test contents, determine new target directory 2. Move / rename tests to reflect purpose. 3. Add issue link / comments in separate commit. 4. Rebless if necessary and remove obsolete stderr. r? @Kivooeo

Rollup of 5 pull requests Successful merges: - #153049 (Add `-Zsanitize=kernel-hwaddress`) - #154269 (miri recursive validation: only check one layer deep) - #154112 (some `tests/ui/macros` cleanup) - #154131 (begin `tests/ui/structs-enums` cleanup) - #154233 (Move ui/issues tests to relevant subdirectories)

@Kivooeo

…r=Kivooeo Move ui/issues tests to relevant subdirectories Related to rust-lang#133895 and [Reorganisation of tests/ui/issues for GSOC](https://github.com/rust-lang/google-summer-of-code?tab=readme-ov-file#reorganisation-of-testsuiissues) This is the first PR in a batch of PRs. Moves `ui/issues/issue-17546.rs‎` ‎-> `ui/variants/variant-result-noresult-used-as-type.rs` Approach: 1. Check linked issue and test contents, determine new target directory 2. Move / rename tests to reflect purpose. 3. Add issue link / comments in separate commit. 4. Rebless if necessary and remove obsolete stderr. r? @Kivooeo

…uwer Rollup of 22 pull requests Successful merges: - #153049 (Add `-Zsanitize=kernel-hwaddress`) - #153702 (Add macro matcher for `guard` fragment specifier) - #154200 (debuginfo: emit DW_TAG_call_site entries) - #154263 (interpret: when passing an argument fails, point at that argument) - #154269 (miri recursive validation: only check one layer deep) - #154313 (Init `self_decl` with a correct visibility) - #154344 (Update LLVM to 22.1.2) - #154348 (re-enable enzyme/autodiff builds on dist-aarch64-apple) - #154351 (Overhaul `Erasable` impls) - #154363 (delegation: fix zero-args nested delegation ICE) - #154364 (delegation: don't propagate synthetic params, remove lifetime hacks) - #151148 (Add functions to `GrowableBitSet`) - #154090 (Move tests in the statics category) - #154112 (some `tests/ui/macros` cleanup) - #154131 (begin `tests/ui/structs-enums` cleanup) - #154216 (unstably mark `NonNull::with_exposed_provenance` as const) - #154230 (Moved and rename issue-50411 to tests/ui/mir/inliner-double-elaborate) - #154233 (Move ui/issues tests to relevant subdirectories) - #154288 (Fix typo in doc comment for `char::to_titlecase`) - #154355 (delegation: add const type ICE test) - #154358 (install-template.sh: Optimize by using Bourne shell builtins.) - #154360 (fromrangeiter-overflow-checks: accept optional `signext` for argument)

…uwer Rollup of 22 pull requests Successful merges: - rust-lang/rust#153049 (Add `-Zsanitize=kernel-hwaddress`) - rust-lang/rust#153702 (Add macro matcher for `guard` fragment specifier) - rust-lang/rust#154200 (debuginfo: emit DW_TAG_call_site entries) - rust-lang/rust#154263 (interpret: when passing an argument fails, point at that argument) - rust-lang/rust#154269 (miri recursive validation: only check one layer deep) - rust-lang/rust#154313 (Init `self_decl` with a correct visibility) - rust-lang/rust#154344 (Update LLVM to 22.1.2) - rust-lang/rust#154348 (re-enable enzyme/autodiff builds on dist-aarch64-apple) - rust-lang/rust#154351 (Overhaul `Erasable` impls) - rust-lang/rust#154363 (delegation: fix zero-args nested delegation ICE) - rust-lang/rust#154364 (delegation: don't propagate synthetic params, remove lifetime hacks) - rust-lang/rust#151148 (Add functions to `GrowableBitSet`) - rust-lang/rust#154090 (Move tests in the statics category) - rust-lang/rust#154112 (some `tests/ui/macros` cleanup) - rust-lang/rust#154131 (begin `tests/ui/structs-enums` cleanup) - rust-lang/rust#154216 (unstably mark `NonNull::with_exposed_provenance` as const) - rust-lang/rust#154230 (Moved and rename issue-50411 to tests/ui/mir/inliner-double-elaborate) - rust-lang/rust#154233 (Move ui/issues tests to relevant subdirectories) - rust-lang/rust#154288 (Fix typo in doc comment for `char::to_titlecase`) - rust-lang/rust#154355 (delegation: add const type ICE test) - rust-lang/rust#154358 (install-template.sh: Optimize by using Bourne shell builtins.) - rust-lang/rust#154360 (fromrangeiter-overflow-checks: accept optional `signext` for argument)

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 23, 2026

rustbot assigned jieyouxu Mar 23, 2026

rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Mar 23, 2026

rustbot assigned Kivooeo and unassigned jieyouxu Mar 23, 2026

kyleecodes marked this pull request as draft March 23, 2026 03:14

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 23, 2026

kyleecodes changed the title ~~Migrate test/ui/issues tests to more relevant test/ui subdirectories~~ Migrate test/ui/issues tests to relevant subdirectories Mar 23, 2026

kyleecodes changed the title ~~Migrate test/ui/issues tests to relevant subdirectories~~ Move ui/issues tests to relevant subdirectories Mar 23, 2026

kyleecodes marked this pull request as ready for review March 23, 2026 16:23

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 23, 2026

zedddie reviewed Mar 23, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

Move ui/issues tests to relevant subdirectories

62ba3c1

* tests(ui): migrate issues/issue-17546 to ui/resolve * tests(ui): add gh issue link * tests(ui/issues): move tests to variants dir

rust-bors bot force-pushed the tests/reorg-ui-issues branch from 5ea30db to 62ba3c1 Compare March 25, 2026 00:35

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 25, 2026

jhpratt mentioned this pull request Mar 25, 2026

Rollup of 6 pull requests #154347

Closed

jhpratt mentioned this pull request Mar 25, 2026

Rollup of 5 pull requests #154353

Closed

This was referenced Mar 25, 2026

Rollup of 21 pull requests #154378

Closed

Rollup of 22 pull requests #154384

Merged

rust-bors bot merged commit 4b9e655 into rust-lang:main Mar 25, 2026
11 checks passed

rustbot added this to the 1.96.0 milestone Mar 25, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Move ui/issues tests to relevant subdirectories#154233

Move ui/issues tests to relevant subdirectories#154233
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
kyleecodes:tests/reorg-ui-issues

kyleecodes commented Mar 23, 2026 •

edited

Loading

Uh oh!

rustbot commented Mar 23, 2026

Uh oh!

kyleecodes commented Mar 23, 2026 •

edited

Loading

Uh oh!

zedddie Mar 23, 2026

Uh oh!

kyleecodes Mar 23, 2026 •

edited

Loading

Uh oh!

Kivooeo commented Mar 25, 2026

Uh oh!

This comment has been minimized.

rust-bors bot commented Mar 25, 2026

Uh oh!

rust-bors bot commented Mar 25, 2026

Uh oh!

Kivooeo commented Mar 25, 2026

Uh oh!

rust-bors bot commented Mar 25, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

kyleecodes commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Mar 23, 2026

Uh oh!

kyleecodes commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zedddie Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

kyleecodes Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Kivooeo commented Mar 25, 2026

Uh oh!

This comment has been minimized.

rust-bors bot commented Mar 25, 2026

Uh oh!

rust-bors bot commented Mar 25, 2026

Uh oh!

Kivooeo commented Mar 25, 2026

Uh oh!

rust-bors bot commented Mar 25, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

kyleecodes commented Mar 23, 2026 •

edited

Loading

kyleecodes commented Mar 23, 2026 •

edited

Loading

kyleecodes Mar 23, 2026 •

edited

Loading