Skip to content

begin tests/ui/structs-enums cleanup#154131

Merged
rust-bors[bot] merged 5 commits intorust-lang:mainfrom
cyrgani:structs-enums
Mar 25, 2026
Merged

begin tests/ui/structs-enums cleanup#154131
rust-bors[bot] merged 5 commits intorust-lang:mainfrom
cyrgani:structs-enums

Conversation

@cyrgani
Copy link
Copy Markdown
Contributor

@cyrgani cyrgani commented Mar 20, 2026

Nearly all tests in this directory are heavily outdated, poorly formatted and have a lot of duplication. This PR is the first of a planned series of PRs to combinine this, ui/structs and ui/enum into a better structure (ui/adt maybe?).

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 20, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Mar 20, 2026

r? @mati865

rustbot has assigned @mati865.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 69 candidates
  • Random selection from 14 candidates

@JayanAXHF
Copy link
Copy Markdown
Member

JayanAXHF commented Mar 20, 2026

Is there a parent issue for this? IMO this is a good place for new contributions (i'd like to help out myself if you'd like)

@cyrgani
Copy link
Copy Markdown
Contributor Author

cyrgani commented Mar 20, 2026

Currently, there is no dedicated issue for this. #133895 is the overarching issue for test improvements, but the only place that (briefly) mentions the plans for individual directories is tests/ui/README.md. I'll try to make some issues tomorrow for some of the larger directories where it would make sense for multiple people to work on them.

@Kivooeo Kivooeo assigned Kivooeo and unassigned mati865 Mar 21, 2026
@Kivooeo
Copy link
Copy Markdown
Member

Kivooeo commented Mar 23, 2026

I like your idea with ui/adt, but is having ui/adt/structs and ui/adt/enums (possibly unions too) would be too much?

@Kivooeo
Copy link
Copy Markdown
Member

Kivooeo commented Mar 25, 2026

ui/structs and ui/enum into a better structure

I've just reread this and think having separate directories for structs and enums is fine. I just don't like the idea of a structs-enums.

@Kivooeo
Copy link
Copy Markdown
Member

Kivooeo commented Mar 25, 2026

@bors r+ rollup

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Mar 25, 2026

📌 Commit ff524fd has been approved by Kivooeo

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 25, 2026
jhpratt added a commit to jhpratt/rust that referenced this pull request Mar 25, 2026
@jhpratt
Rollup merge of rust-lang#154131 - cyrgani:structs-enums, r=Kivooeo
8ca3b88 
begin `tests/ui/structs-enums` cleanup

Nearly all tests in this directory are heavily outdated, poorly formatted and have a lot of duplication. This PR is the first of a planned series of PRs to combinine this, `ui/structs` and `ui/enum` into a better structure (`ui/adt` maybe?).
@jhpratt jhpratt mentioned this pull request Mar 25, 2026
Closed
rust-bors bot pushed a commit that referenced this pull request Mar 25, 2026
@bors
Auto merge of #154347 - jhpratt:rollup-IoYtkt9, r=jhpratt
f774118 
Rollup of 6 pull requests

Successful merges:

 - #154004 (`Alignment`: move from `ptr` to `mem` and rename `as_nonzero` to `as_nonzero_usize`)
 - #153049 (Add `-Zsanitize=kernel-hwaddress`)
 - #154269 (miri recursive validation: only check one layer deep)
 - #154112 (some `tests/ui/macros` cleanup)
 - #154131 (begin `tests/ui/structs-enums` cleanup)
 - #154233 (Move ui/issues tests to relevant subdirectories)
jhpratt added a commit to jhpratt/rust that referenced this pull request Mar 25, 2026
@jhpratt
Rollup merge of rust-lang#154131 - cyrgani:structs-enums, r=Kivooeo
dc2c20e 
begin `tests/ui/structs-enums` cleanup

Nearly all tests in this directory are heavily outdated, poorly formatted and have a lot of duplication. This PR is the first of a planned series of PRs to combinine this, `ui/structs` and `ui/enum` into a better structure (`ui/adt` maybe?).
@jhpratt jhpratt mentioned this pull request Mar 25, 2026
Closed
rust-bors bot pushed a commit that referenced this pull request Mar 25, 2026
@bors
Auto merge of #154353 - jhpratt:rollup-bLxq22n, r=jhpratt
b27b2eb 
Rollup of 5 pull requests

Successful merges:

 - #153049 (Add `-Zsanitize=kernel-hwaddress`)
 - #154269 (miri recursive validation: only check one layer deep)
 - #154112 (some `tests/ui/macros` cleanup)
 - #154131 (begin `tests/ui/structs-enums` cleanup)
 - #154233 (Move ui/issues tests to relevant subdirectories)
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 25, 2026
@JonathanBrouwer
Rollup merge of rust-lang#154131 - cyrgani:structs-enums, r=Kivooeo
4de20a2 
begin `tests/ui/structs-enums` cleanup

Nearly all tests in this directory are heavily outdated, poorly formatted and have a lot of duplication. This PR is the first of a planned series of PRs to combinine this, `ui/structs` and `ui/enum` into a better structure (`ui/adt` maybe?).
This was referenced Mar 25, 2026
Closed
Merged
rust-bors bot pushed a commit that referenced this pull request Mar 25, 2026
@bors
Auto merge of #154384 - JonathanBrouwer:rollup-Wou9g2B, r=JonathanBro…
80d0e4b 
…uwer

Rollup of 22 pull requests

Successful merges:

 - #153049 (Add `-Zsanitize=kernel-hwaddress`)
 - #153702 (Add macro matcher for `guard` fragment specifier)
 - #154200 (debuginfo: emit DW_TAG_call_site entries)
 - #154263 (interpret: when passing an argument fails, point at that argument)
 - #154269 (miri recursive validation: only check one layer deep)
 - #154313 (Init `self_decl` with a correct visibility)
 - #154344 (Update LLVM to 22.1.2)
 - #154348 (re-enable enzyme/autodiff builds on dist-aarch64-apple)
 - #154351 (Overhaul `Erasable` impls)
 - #154363 (delegation: fix zero-args nested delegation ICE)
 - #154364 (delegation: don't propagate synthetic params, remove lifetime hacks)
 - #151148 (Add functions to `GrowableBitSet`)
 - #154090 (Move tests in the statics category)
 - #154112 (some `tests/ui/macros` cleanup)
 - #154131 (begin `tests/ui/structs-enums` cleanup)
 - #154216 (unstably mark `NonNull::with_exposed_provenance` as const)
 - #154230 (Moved and rename issue-50411 to tests/ui/mir/inliner-double-elaborate)
 - #154233 (Move ui/issues tests to relevant subdirectories)
 - #154288 (Fix typo in doc comment for `char::to_titlecase`)
 - #154355 (delegation: add const type ICE test)
 - #154358 (install-template.sh: Optimize by using Bourne shell builtins.)
 - #154360 (fromrangeiter-overflow-checks: accept optional `signext` for argument)
@rust-bors rust-bors bot merged commit 7381bbb into rust-lang:main Mar 25, 2026
11 checks passed
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Mar 26, 2026
@bors
Auto merge of #154384 - JonathanBrouwer:rollup-Wou9g2B, r=JonathanBro…
9098134 
…uwer

Rollup of 22 pull requests

Successful merges:

 - rust-lang/rust#153049 (Add `-Zsanitize=kernel-hwaddress`)
 - rust-lang/rust#153702 (Add macro matcher for `guard` fragment specifier)
 - rust-lang/rust#154200 (debuginfo: emit DW_TAG_call_site entries)
 - rust-lang/rust#154263 (interpret: when passing an argument fails, point at that argument)
 - rust-lang/rust#154269 (miri recursive validation: only check one layer deep)
 - rust-lang/rust#154313 (Init `self_decl` with a correct visibility)
 - rust-lang/rust#154344 (Update LLVM to 22.1.2)
 - rust-lang/rust#154348 (re-enable enzyme/autodiff builds on dist-aarch64-apple)
 - rust-lang/rust#154351 (Overhaul `Erasable` impls)
 - rust-lang/rust#154363 (delegation: fix zero-args nested delegation ICE)
 - rust-lang/rust#154364 (delegation: don't propagate synthetic params, remove lifetime hacks)
 - rust-lang/rust#151148 (Add functions to `GrowableBitSet`)
 - rust-lang/rust#154090 (Move tests in the statics category)
 - rust-lang/rust#154112 (some `tests/ui/macros` cleanup)
 - rust-lang/rust#154131 (begin `tests/ui/structs-enums` cleanup)
 - rust-lang/rust#154216 (unstably mark `NonNull::with_exposed_provenance` as const)
 - rust-lang/rust#154230 (Moved and rename issue-50411 to tests/ui/mir/inliner-double-elaborate)
 - rust-lang/rust#154233 (Move ui/issues tests to relevant subdirectories)
 - rust-lang/rust#154288 (Fix typo in doc comment for `char::to_titlecase`)
 - rust-lang/rust#154355 (delegation: add const type ICE test)
 - rust-lang/rust#154358 (install-template.sh: Optimize by using Bourne shell builtins.)
 - rust-lang/rust#154360 (fromrangeiter-overflow-checks: accept optional `signext` for argument)
@cyrgani cyrgani deleted the structs-enums branch March 26, 2026 07:09
@cyrgani cyrgani mentioned this pull request Mar 28, 2026
Merged
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Mar 28, 2026
@GuillaumeGomez
Rollup merge of rust-lang#154504 - cyrgani:structenum, r=Kivooeo
c2fc360 
move many tests from `structs-enums` to `structs` or `enum`

This PR moves most of the tests in `ui/structs-enums` that are only about structs or only about enums to their respective directory, as a step towards removing `ui/structs-enums`.
Followup to rust-lang#154131.
r? @Kivooeo
rust-timer added a commit that referenced this pull request Mar 29, 2026
@rust-timer
Unrolled build for #154504
ebc02b3 
Rollup merge of #154504 - cyrgani:structenum, r=Kivooeo

move many tests from `structs-enums` to `structs` or `enum`

This PR moves most of the tests in `ui/structs-enums` that are only about structs or only about enums to their respective directory, as a step towards removing `ui/structs-enums`.
Followup to #154131.
r? @Kivooeo
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Mar 29, 2026
@GuillaumeGomez
Rollup merge of #154504 - cyrgani:structenum, r=Kivooeo
ea3a9aa 
move many tests from `structs-enums` to `structs` or `enum`

This PR moves most of the tests in `ui/structs-enums` that are only about structs or only about enums to their respective directory, as a step towards removing `ui/structs-enums`.
Followup to rust-lang/rust#154131.
r? @Kivooeo
github-actions bot pushed a commit to rust-lang/stdarch that referenced this pull request Mar 30, 2026
@GuillaumeGomez
Rollup merge of #154504 - cyrgani:structenum, r=Kivooeo
4690586 
move many tests from `structs-enums` to `structs` or `enum`

This PR moves most of the tests in `ui/structs-enums` that are only about structs or only about enums to their respective directory, as a step towards removing `ui/structs-enums`.
Followup to rust-lang/rust#154131.
r? @Kivooeo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Kivooeo Kivooeo

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cyrgani @rustbot @JayanAXHF @Kivooeo @mati865