Don't fuse in MapWindows#154190
Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom Mar 29, 2026
Merged
Conversation
rustbot
added
the
S-waiting-on-review
rustbot
added
the
T-libs
Collaborator
|
r? @scottmcm rustbot has assigned @scottmcm. Use Why was this reviewer chosen?The reviewer was selected based on:
|
teor2345
reviewed
Mar 27, 2026
Member
|
Agreed, change looks good, and I agree with not adding @bors r+ rollup |
Contributor
rust-bors
bot
added
S-waiting-on-bors
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Mar 29, 2026
Don't fuse in `MapWindows` cc rust-lang#87155 Fusing makes the iterator larger, slower, more complicated, and less useful. Users who need fusing behavior can always use `.fuse()`, but there is no way to get non-fusing behavior from the fused version. @rustbot label A-iterators
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Mar 29, 2026
Don't fuse in `MapWindows` cc rust-lang#87155 Fusing makes the iterator larger, slower, more complicated, and less useful. Users who need fusing behavior can always use `.fuse()`, but there is no way to get non-fusing behavior from the fused version. @rustbot label A-iterators
This was referenced Mar 29, 2026
rust-bors bot
pushed a commit
that referenced
this pull request
Mar 29, 2026
…uwer Rollup of 4 pull requests Successful merges: - #153632 (Fix Vec::const_make_global for 0 capacity and ZST's) - #154190 (Don't fuse in `MapWindows`) - #154512 (Constify comparisons and `Clone` for `core::mem::Alignment`) - #154520 (Add doc links to `ExtractIf` of `BTree{Set,Map}` and `LinkedList`)
rust-timer
added a commit
that referenced
this pull request
Mar 29, 2026
Rollup merge of #154190 - Jules-Bertholet:nonfused, r=scottmcm Don't fuse in `MapWindows` cc #87155 Fusing makes the iterator larger, slower, more complicated, and less useful. Users who need fusing behavior can always use `.fuse()`, but there is no way to get non-fusing behavior from the fused version. @rustbot label A-iterators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc #87155
Fusing makes the iterator larger, slower, more complicated, and less useful. Users who need fusing behavior can always use
.fuse(), but there is no way to get non-fusing behavior from the fused version.@rustbot label A-iterators