Skip to content

Fix Vec::const_make_global for 0 capacity and ZST's#153632

Merged
rust-bors[bot] merged 2 commits intorust-lang:mainfrom
Lars-Schumann:issue-153158
Mar 29, 2026
Merged

Fix Vec::const_make_global for 0 capacity and ZST's#153632
rust-bors[bot] merged 2 commits intorust-lang:mainfrom
Lars-Schumann:issue-153158

Conversation

@Lars-Schumann
Copy link
Copy Markdown
Contributor

@Lars-Schumann Lars-Schumann commented Mar 9, 2026

fixes #153158

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 9, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Mar 9, 2026

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: libs
  • libs expanded to 7 candidates

fee1-dead
fee1-dead requested changes Mar 9, 2026
View reviewed changes
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 9, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Mar 9, 2026

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@rustbot rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Mar 9, 2026
@Lars-Schumann
Copy link
Copy Markdown
Contributor Author

Lars-Schumann commented Mar 10, 2026

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 10, 2026
@fee1-dead
Copy link
Copy Markdown
Member

fee1-dead commented Mar 29, 2026

@bors r+ rollup

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Mar 29, 2026

📌 Commit 50ee6f9 has been approved by fee1-dead

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 29, 2026
Zalathar added a commit to Zalathar/rust that referenced this pull request Mar 29, 2026
@Zalathar
Rollup merge of rust-lang#153632 - Lars-Schumann:issue-153158, r=fee1…
49dab60 
…-dead

Fix Vec::const_make_global for 0 capacity and ZST's

fixes rust-lang#153158
@Zalathar Zalathar mentioned this pull request Mar 29, 2026
Closed
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 29, 2026
@JonathanBrouwer
Rollup merge of rust-lang#153632 - Lars-Schumann:issue-153158, r=fee1…
4b52ede 
…-dead

Fix Vec::const_make_global for 0 capacity and ZST's

fixes rust-lang#153158
This was referenced Mar 29, 2026
Closed
Merged
rust-bors bot pushed a commit that referenced this pull request Mar 29, 2026
@bors
Auto merge of #154535 - JonathanBrouwer:rollup-jU7CiZw, r=JonathanBro…
584d32e 
…uwer

Rollup of 4 pull requests

Successful merges:

 - #153632 (Fix Vec::const_make_global for 0 capacity and ZST's)
 - #154190 (Don't fuse in `MapWindows`)
 - #154512 (Constify comparisons and `Clone` for `core::mem::Alignment`)
 - #154520 (Add doc links to `ExtractIf` of `BTree{Set,Map}` and `LinkedList`)
@rust-bors rust-bors bot merged commit 8287d4d into rust-lang:main Mar 29, 2026
11 checks passed
@rustbot rustbot added this to the 1.96.0 milestone Mar 29, 2026
rust-timer added a commit that referenced this pull request Mar 29, 2026
@rust-timer
Unrolled build for #153632
43c7f8d 
Rollup merge of #153632 - Lars-Schumann:issue-153158, r=fee1-dead

Fix Vec::const_make_global for 0 capacity and ZST's

fixes #153158
@Lars-Schumann Lars-Schumann deleted the issue-153158 branch March 29, 2026 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fee1-dead fee1-dead fee1-dead requested changes

Assignees

@fee1-dead fee1-dead

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

Vec's const_make_global method erroring when Vec is empty

4 participants

@Lars-Schumann @rustbot @fee1-dead @Mark-Simulacrum