Skip to content

Add a comment explaining the 'tcx lifetime.#153422

Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
nnethercote:tcx-comment
Mar 5, 2026
Merged

Add a comment explaining the 'tcx lifetime.#153422
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
nnethercote:tcx-comment

Conversation

@nnethercote
Copy link
Contributor

I wrote this after thinking about where the 'tcx lifetime actually comes from.

r? @bjorn3

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 4, 2026
@bjorn3
Copy link
Member

bjorn3 commented Mar 5, 2026

@bors r+ rollup

@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 5, 2026

📌 Commit b3fddcb has been approved by bjorn3

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 5, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 5, 2026
Add a comment explaining the 'tcx lifetime.

I wrote this after thinking about where the `'tcx` lifetime actually comes from.

r? @bjorn3
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 5, 2026
Add a comment explaining the 'tcx lifetime.

I wrote this after thinking about where the `'tcx` lifetime actually comes from.

r? @bjorn3
rust-bors bot pushed a commit that referenced this pull request Mar 5, 2026
…uwer

Rollup of 9 pull requests

Successful merges:

 - #153399 (constify `Vec::{into, from}_raw_parts{_in|_alloc}`)
 - #153436 (Use shlex instead of shell-words)
 - #150845 (bootstrap: minimal fix for ./x install src with build.docs = false)
 - #152906 (Make `const_lit_matches_ty` check literal suffixes for exact type match)
 - #153378 (Rename `QueryCache::iter` to `for_each`)
 - #153386 (Minor query cleanups)
 - #153422 (Add a comment explaining the 'tcx lifetime.)
 - #153435 (Fix obtaining def_id from unresolved segment)
 - #153453 (Fix ICEs due to incomplete typechecking on struct literals with syntax errors.)
@rust-bors rust-bors bot merged commit e26f208 into rust-lang:main Mar 5, 2026
11 checks passed
@rustbot rustbot added this to the 1.96.0 milestone Mar 5, 2026
rust-timer added a commit that referenced this pull request Mar 5, 2026
Rollup merge of #153422 - nnethercote:tcx-comment, r=bjorn3

Add a comment explaining the 'tcx lifetime.

I wrote this after thinking about where the `'tcx` lifetime actually comes from.

r? @bjorn3
@nnethercote nnethercote deleted the tcx-comment branch March 6, 2026 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants