Skip to content

Rename QueryCache::iter to for_each#153378

Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Zalathar:for-each
Mar 5, 2026
Merged

Rename QueryCache::iter to for_each#153378
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Zalathar:for-each

Conversation

@Zalathar
Copy link
Member

@Zalathar Zalathar commented Mar 4, 2026

Methods that perform internal iteration are typically named for_each.

@rustbot rustbot added A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 4, 2026
@rustbot
Copy link
Collaborator

rustbot commented Mar 4, 2026

r? @fee1-dead

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler, query-system
  • compiler, query-system expanded to 69 candidates
  • Random selection from 16 candidates

@rust-bors

This comment has been minimized.

Methods that perform internal iteration are typically named `for_each`.
@rustbot
Copy link
Collaborator

rustbot commented Mar 5, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@fee1-dead
Copy link
Member

@bors r+ rollup

@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 5, 2026

📌 Commit 743d442 has been approved by fee1-dead

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 5, 2026
rust-bors bot pushed a commit that referenced this pull request Mar 5, 2026
…uwer

Rollup of 9 pull requests

Successful merges:

 - #153399 (constify `Vec::{into, from}_raw_parts{_in|_alloc}`)
 - #153436 (Use shlex instead of shell-words)
 - #150845 (bootstrap: minimal fix for ./x install src with build.docs = false)
 - #152906 (Make `const_lit_matches_ty` check literal suffixes for exact type match)
 - #153378 (Rename `QueryCache::iter` to `for_each`)
 - #153386 (Minor query cleanups)
 - #153422 (Add a comment explaining the 'tcx lifetime.)
 - #153435 (Fix obtaining def_id from unresolved segment)
 - #153453 (Fix ICEs due to incomplete typechecking on struct literals with syntax errors.)
@rust-bors rust-bors bot merged commit 31c5680 into rust-lang:main Mar 5, 2026
11 checks passed
@rustbot rustbot added this to the 1.96.0 milestone Mar 5, 2026
rust-timer added a commit that referenced this pull request Mar 5, 2026
Rollup merge of #153378 - Zalathar:for-each, r=fee1-dead

Rename `QueryCache::iter` to `for_each`

Methods that perform internal iteration are typically named `for_each`.
@Zalathar Zalathar deleted the for-each branch March 6, 2026 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants