test: add regression test for fuzzy_provenance_casts lint ICE#153233
Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom Mar 2, 2026
Merged
test: add regression test for fuzzy_provenance_casts lint ICE#153233rust-bors[bot] merged 1 commit intorust-lang:mainfrom
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Conversation
Collaborator
|
r? @nnethercote rustbot has assigned @nnethercote. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Contributor
Contributor
Author
|
The ICE no longer reproduces on the latest main — the issue was already fixed, and this PR only adds a regression test. The issue had the I've updated the PR description to clarify this. Sorry for the confusion. @rustbot ready |
Contributor
|
Thanks for the clarification! Looks good. @bors r+ rollup |
Contributor
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Mar 2, 2026
…-test, r=nnethercote test: add regression test for fuzzy_provenance_casts lint ICE This PR adds a regression test for an ICE in `draw_code_line` that occurred when emitting a `fuzzy_provenance_casts` lint diagnostic for code with an inner attribute spanning the entire file, causing a panic on an empty `file_lines` from a dummy span. The ICE no longer reproduces on the latest main. This PR only adds a regression test to prevent future regressions. The test is based on the auto-reduced code from the issue. rust-lang#137588
rust-bors bot
pushed a commit
that referenced
this pull request
Mar 2, 2026
Rollup of 6 pull requests Successful merges: - #153015 (core: make atomic primitives type aliases of `Atomic<T>`) - #153046 (Couple of cg_ssa refactorings) - #153169 (Various small query cleanups) - #152304 (stabilize new RangeToInclusive type) - #153225 (tests/ui/asm: add annotations for reference rules) - #153233 (test: add regression test for fuzzy_provenance_casts lint ICE)
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Mar 2, 2026
…-test, r=nnethercote test: add regression test for fuzzy_provenance_casts lint ICE This PR adds a regression test for an ICE in `draw_code_line` that occurred when emitting a `fuzzy_provenance_casts` lint diagnostic for code with an inner attribute spanning the entire file, causing a panic on an empty `file_lines` from a dummy span. The ICE no longer reproduces on the latest main. This PR only adds a regression test to prevent future regressions. The test is based on the auto-reduced code from the issue. rust-lang#137588
rust-bors bot
pushed a commit
that referenced
this pull request
Mar 2, 2026
…uwer Rollup of 6 pull requests Successful merges: - #153169 (Various small query cleanups) - #152304 (stabilize new RangeToInclusive type) - #153046 (Couple of cg_ssa refactorings) - #153090 (elf-raw-dylib: set type for functions) - #153225 (tests/ui/asm: add annotations for reference rules) - #153233 (test: add regression test for fuzzy_provenance_casts lint ICE)
rust-timer
added a commit
that referenced
this pull request
Mar 2, 2026
Rollup merge of #153233 - yuyahy:ice-issue-137588-regression-test, r=nnethercote test: add regression test for fuzzy_provenance_casts lint ICE This PR adds a regression test for an ICE in `draw_code_line` that occurred when emitting a `fuzzy_provenance_casts` lint diagnostic for code with an inner attribute spanning the entire file, causing a panic on an empty `file_lines` from a dummy span. The ICE no longer reproduces on the latest main. This PR only adds a regression test to prevent future regressions. The test is based on the auto-reduced code from the issue. #137588
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a regression test for an ICE in
draw_code_linethat occurred when emitting afuzzy_provenance_castslint diagnostic for code with an inner attribute spanning the entire file, causing a panic on an emptyfile_linesfrom a dummy span.The ICE no longer reproduces on the latest main. This PR only adds a regression test to prevent future regressions.
The test is based on the auto-reduced code from the issue.
#137588