stabilize new RangeToInclusive type by pitaj · Pull Request #152304 · rust-lang/rust

pitaj · 2026-02-07T17:03:32Z

stabilizes core::range::RangeToInclusive

// in core::range

pub struct RangeToInclusive<Idx> {
    pub last: Idx,
}

impl<Idx: fmt::Debug> fmt::Debug for RangeInclusive<Idx> { /* ... */ }

impl<Idx: PartialOrd<Idx>> RangeToInclusive<Idx> {
    pub const fn contains<U>(&self, item: &U) -> bool
    where
        Idx: [const] PartialOrd<U>,
        U: ?Sized + [const] PartialOrd<Idx>;
}

impl<T> const RangeBounds<T> for RangeToInclusive<T> { /* ... */ }
impl<T> const RangeBounds<T> for RangeToInclusive<&T> { /* ... */ }

impl<T> const From<RangeToInclusive<T>> for legacy::RangeToInclusive<T> { /* ... */ }
impl<T> const From<legacy::RangeToInclusive<T>> for RangeToInclusive<T> { /* ... */ }

unsafe impl<T> const SliceIndex<[T]> for range::RangeToInclusive<usize> {
    type Output = [T];
    /* ... */
}
unsafe impl const SliceIndex<str> for range::RangeToInclusive<usize> {
    type Output = str;
    /* ... */
}

Tracking issue: #125687

r? @tgross35

rustbot · 2026-02-07T17:03:36Z

tgross35 is currently at their maximum review capacity.
They may take a while to respond.

tgross35

I think there is a small change needed here but otherwise LGTM. However, I noticed there are some trait implementations missing compared to ops::RangeToInclusive:

OneSidedRange<T>
RangeBounds<T> for RangeToInclusive<&T> (currently has for RangeToInclusive<T>
SliceIndex<ByteStr> for RangeToInclusive<usize> (unstable)
SliceIndex<str> for RangeToInclusive<usize>

Would you mind putting up a PR adding those? We can re-nominate this for libs-api after.

View changes since this review

library/core/src/range.rs

rustbot · 2026-02-09T10:11:54Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

tgross35 · 2026-02-09T10:15:04Z

Index<RangeFrom<usize>> for CStr is also missing in the new RangeFrom

pitaj · 2026-02-14T23:58:23Z

@rustbot ready

tgross35 · 2026-02-16T12:27:08Z

library/core/src/ffi/c_str.rs

+#[unstable(feature = "new_range_api", issue = "125687")]
+impl ops::Index<range::RangeFrom<usize>> for CStr {
+    type Output = CStr;
+
+    #[inline]
+    fn index(&self, index: range::RangeFrom<usize>) -> &CStr {
+        let bytes = self.to_bytes_with_nul();
+        // we need to manually check the starting index to account for the null
+        // byte, since otherwise we could get an empty string that doesn't end
+        // in a null.
+        if index.start < bytes.len() {
+            // SAFETY: Non-empty tail of a valid `CStr` is still a valid `CStr`.
+            unsafe { CStr::from_bytes_with_nul_unchecked(&bytes[index.start..]) }
+        } else {
+            panic!(
+                "index out of bounds: the len is {} but the index is {}",
+                bytes.len(),
+                index.start
+            );
+        }
+    }
+}


This impl can probably forward to ops::RangeFrom so we don't have the same thing twice, or vice versa

tgross35 · 2026-02-16T12:34:34Z

One note but otherwise the changes here LGTM. Nominating for libs-api to take a look because there are two new impls that weren't present for the FCP at #125687 (comment):

impl RangeBounds<T> for RangeToInclusive<&T> { /* ... */ }
impl SliceIndex<str> for RangeToInclusive<usize> { /* ... */ }

These match up with what is present on the existing RangeToInclusive.

@rustbot label +I-libs-api-nominated

tgross35

Everything here LGTM but it needs somebody from @rust-lang/libs-api to okay the above additions. I don't expect it to need a new FCP since they match the old RangeToInclusive.

Last two commits could be squashed.

View changes since this review

Amanieu · 2026-02-24T17:23:15Z

We discussed this in the @rust-lang/libs-api meeting and we are happy with the added trait impls.

stabilizes `core::range::RangeToInclusive` add missing trait impls for new RangeToInclusive add missing trait impls for new RangeFrom

rustbot · 2026-03-01T04:46:52Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

pitaj · 2026-03-01T04:59:36Z

@rustbot ready

tgross35

@bors r+ rollup

View changes since this review

rust-bors · 2026-03-02T02:33:48Z

📌 Commit bc4cead has been approved by tgross35

It is now in the queue for this repository.

tgross35 · 2026-03-02T02:35:14Z

library/core/src/range.rs

+// #[stable(feature = "new_range_to_inclusive_api", since = "CURRENT_RUSTC_VERSION")]
 #[unstable(feature = "range_into_bounds", issue = "136903")]
 #[rustc_const_unstable(feature = "const_range", issue = "none")]
 impl<T> const IntoBounds<T> for RangeToInclusive<T> {


Probably no need to have this comment, we can't have >1 #[stable] if range_into_bounds gets stabilized.

…gross35 stabilize new RangeToInclusive type stabilizes `core::range::RangeToInclusive` ```rust // in core::range pub struct RangeToInclusive<Idx> { pub last: Idx, } impl<Idx: fmt::Debug> fmt::Debug for RangeInclusive<Idx> { /* ... */ } impl<Idx: PartialOrd<Idx>> RangeToInclusive<Idx> { pub const fn contains(&self, item: &U) -> bool where Idx: [const] PartialOrd, U: ?Sized + [const] PartialOrd<Idx>; } impl<T> const RangeBounds<T> for RangeToInclusive<T> { /* ... */ } impl<T> const RangeBounds<T> for RangeToInclusive<&T> { /* ... */ } impl<T> const From<RangeToInclusive<T>> for legacy::RangeToInclusive<T> { /* ... */ } impl<T> const From<legacy::RangeToInclusive<T>> for RangeToInclusive<T> { /* ... */ } unsafe impl<T> const SliceIndex<[T]> for range::RangeToInclusive<usize> { type Output = [T]; /* ... */ } unsafe impl const SliceIndex<str> for range::RangeToInclusive<usize> { type Output = str; /* ... */ } ``` Tracking issue: rust-lang#125687

Rollup of 6 pull requests Successful merges: - #153015 (core: make atomic primitives type aliases of `Atomic<T>`) - #153046 (Couple of cg_ssa refactorings) - #153169 (Various small query cleanups) - #152304 (stabilize new RangeToInclusive type) - #153225 (tests/ui/asm: add annotations for reference rules) - #153233 (test: add regression test for fuzzy_provenance_casts lint ICE)

…gross35 stabilize new RangeToInclusive type stabilizes `core::range::RangeToInclusive` ```rust // in core::range pub struct RangeToInclusive<Idx> { pub last: Idx, } impl<Idx: fmt::Debug> fmt::Debug for RangeInclusive<Idx> { /* ... */ } impl<Idx: PartialOrd<Idx>> RangeToInclusive<Idx> { pub const fn contains(&self, item: &U) -> bool where Idx: [const] PartialOrd, U: ?Sized + [const] PartialOrd<Idx>; } impl<T> const RangeBounds<T> for RangeToInclusive<T> { /* ... */ } impl<T> const RangeBounds<T> for RangeToInclusive<&T> { /* ... */ } impl<T> const From<RangeToInclusive<T>> for legacy::RangeToInclusive<T> { /* ... */ } impl<T> const From<legacy::RangeToInclusive<T>> for RangeToInclusive<T> { /* ... */ } unsafe impl<T> const SliceIndex<[T]> for range::RangeToInclusive<usize> { type Output = [T]; /* ... */ } unsafe impl const SliceIndex<str> for range::RangeToInclusive<usize> { type Output = str; /* ... */ } ``` Tracking issue: rust-lang#125687

…uwer Rollup of 6 pull requests Successful merges: - #153169 (Various small query cleanups) - #152304 (stabilize new RangeToInclusive type) - #153046 (Couple of cg_ssa refactorings) - #153090 (elf-raw-dylib: set type for functions) - #153225 (tests/ui/asm: add annotations for reference rules) - #153233 (test: add regression test for fuzzy_provenance_casts lint ICE)

Rollup merge of #152304 - pitaj:stabilize-new_range_api, r=tgross35 stabilize new RangeToInclusive type stabilizes `core::range::RangeToInclusive` ```rust // in core::range pub struct RangeToInclusive<Idx> { pub last: Idx, } impl<Idx: fmt::Debug> fmt::Debug for RangeInclusive<Idx> { /* ... */ } impl<Idx: PartialOrd<Idx>> RangeToInclusive<Idx> { pub const fn contains(&self, item: &U) -> bool where Idx: [const] PartialOrd, U: ?Sized + [const] PartialOrd<Idx>; } impl<T> const RangeBounds<T> for RangeToInclusive<T> { /* ... */ } impl<T> const RangeBounds<T> for RangeToInclusive<&T> { /* ... */ } impl<T> const From<RangeToInclusive<T>> for legacy::RangeToInclusive<T> { /* ... */ } impl<T> const From<legacy::RangeToInclusive<T>> for RangeToInclusive<T> { /* ... */ } unsafe impl<T> const SliceIndex<[T]> for range::RangeToInclusive<usize> { type Output = [T]; /* ... */ } unsafe impl const SliceIndex<str> for range::RangeToInclusive<usize> { type Output = str; /* ... */ } ``` Tracking issue: #125687

rustbot assigned tgross35 Feb 7, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Feb 7, 2026

tgross35 mentioned this pull request Feb 9, 2026

Tracking Issue for new_range_api (part of RFC 3550) #125687

Open

15 tasks

tgross35 requested changes Feb 9, 2026

View reviewed changes

library/core/src/range.rs Show resolved Hide resolved

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 9, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 14, 2026

tgross35 reviewed Feb 16, 2026

View reviewed changes

rustbot added the I-libs-api-nominated Nominated for discussion during a libs-api team meeting. label Feb 16, 2026

tgross35 approved these changes Feb 20, 2026

View reviewed changes

Amanieu removed the I-libs-api-nominated Nominated for discussion during a libs-api team meeting. label Feb 24, 2026

stabilize new RangeToInclusive type

bc4cead

stabilizes `core::range::RangeToInclusive` add missing trait impls for new RangeToInclusive add missing trait impls for new RangeFrom

pitaj force-pushed the stabilize-new_range_api branch from 682fb44 to bc4cead Compare March 1, 2026 04:46

tgross35 approved these changes Mar 2, 2026

View reviewed changes

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 2, 2026

tgross35 reviewed Mar 2, 2026

View reviewed changes

jhpratt mentioned this pull request Mar 2, 2026

Rollup of 6 pull requests #153270

Closed

jhpratt mentioned this pull request Mar 2, 2026

Rollup of 6 pull requests #153277

Closed

JonathanBrouwer mentioned this pull request Mar 2, 2026

Rollup of 6 pull requests #153278

Merged

rust-bors bot merged commit 44c7081 into rust-lang:main Mar 2, 2026
11 checks passed

rustbot added this to the 1.96.0 milestone Mar 2, 2026

tgross35 added the relnotes Marks issues that should be documented in the release notes of the next release. label Mar 2, 2026

rustbot mentioned this pull request Mar 2, 2026

Tracking issue for release notes of #152304: stabilize new RangeToInclusive type #153307

Open

Uh oh!

Conversation

pitaj commented Feb 7, 2026 • edited by tgross35 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Feb 7, 2026

Uh oh!

tgross35 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rustbot commented Feb 9, 2026

Uh oh!

tgross35 commented Feb 9, 2026

Uh oh!

pitaj commented Feb 14, 2026

Uh oh!

tgross35 Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

tgross35 commented Feb 16, 2026

Uh oh!

tgross35 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Amanieu commented Feb 24, 2026

Uh oh!

rustbot commented Mar 1, 2026

Uh oh!

pitaj commented Mar 1, 2026

Uh oh!

tgross35 left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rust-bors bot commented Mar 2, 2026

Uh oh!

tgross35 Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

pitaj commented Feb 7, 2026 •

edited by tgross35

Loading

tgross35 left a comment •

edited

Loading

tgross35 left a comment •

edited

Loading

tgross35 left a comment •

edited by rustbot

Loading