Fix comment about placeholders#153172
Merged
rust-bors[bot] merged 2 commits intorust-lang:mainfrom Feb 28, 2026
Merged
Conversation
rustbot
added
S-waiting-on-review
jdonszelmann
force-pushed
the
placeholder-comment
branch
from
61a632e to
ea2a15f
Compare
Contributor
|
@bors r+ rollup |
Contributor
rust-bors
bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Feb 28, 2026
…r=lcnr Fix comment about placeholders r? @lcnr When this was introduced, briefly returned an `Option`, which is what the comment refers to. rust-lang@a9f1e1c#diff-8d11697c196da9f44774488ae0bf353283e5c6466a6dd570d7818431b73d4a44R511 Before that this code would just panic, and in the commit right after fixing review comments it does so again: rust-lang@cf001dc#diff-8d11697c196da9f44774488ae0bf353283e5c6466a6dd570d7818431b73d4a44R560 That comment has been copied around for 5 years now despite not reflecting the behavior hehe Second commit has some general typos I found
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Feb 28, 2026
…r=lcnr Fix comment about placeholders r? @lcnr When this was introduced, briefly returned an `Option`, which is what the comment refers to. rust-lang@a9f1e1c#diff-8d11697c196da9f44774488ae0bf353283e5c6466a6dd570d7818431b73d4a44R511 Before that this code would just panic, and in the commit right after fixing review comments it does so again: rust-lang@cf001dc#diff-8d11697c196da9f44774488ae0bf353283e5c6466a6dd570d7818431b73d4a44R560 That comment has been copied around for 5 years now despite not reflecting the behavior hehe Second commit has some general typos I found
This was referenced Feb 28, 2026
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 28, 2026
…uwer Rollup of 12 pull requests Successful merges: - #153211 (`rust-analyzer` subtree update) - #149027 (Improve cross-crate trait impl param mismatch suggestions ) - #152730 (add field representing types) - #153136 (Correctly handle `#[doc(alias = "...")]` attribute on inlined reexports) - #152165 (Normalize capture place `ty`s to prevent ICE) - #152615 (refactor 'valid for read/write' definition: exclude null) - #153109 (Fix LegacyKeyValueFormat report from docker build: aarch64-gnu-debug) - #153172 (Fix comment about placeholders) - #153187 (Fix ICE when macro-expanded extern crate shadows std) - #153190 (Don't allow subdiagnostic to use variables from their parent) - #153200 (Remove redundant clone) - #153216 (mark two polonius tests as known-bug)
rust-timer
added a commit
that referenced
this pull request
Feb 28, 2026
Rollup merge of #153172 - jdonszelmann:placeholder-comment, r=lcnr Fix comment about placeholders r? @lcnr When this was introduced, briefly returned an `Option`, which is what the comment refers to. a9f1e1c#diff-8d11697c196da9f44774488ae0bf353283e5c6466a6dd570d7818431b73d4a44R511 Before that this code would just panic, and in the commit right after fixing review comments it does so again: cf001dc#diff-8d11697c196da9f44774488ae0bf353283e5c6466a6dd570d7818431b73d4a44R560 That comment has been copied around for 5 years now despite not reflecting the behavior hehe Second commit has some general typos I found
github-actions bot
pushed a commit
to rust-lang/rust-analyzer
that referenced
this pull request
Mar 2, 2026
…uwer Rollup of 12 pull requests Successful merges: - rust-lang/rust#153211 (`rust-analyzer` subtree update) - rust-lang/rust#149027 (Improve cross-crate trait impl param mismatch suggestions ) - rust-lang/rust#152730 (add field representing types) - rust-lang/rust#153136 (Correctly handle `#[doc(alias = "...")]` attribute on inlined reexports) - rust-lang/rust#152165 (Normalize capture place `ty`s to prevent ICE) - rust-lang/rust#152615 (refactor 'valid for read/write' definition: exclude null) - rust-lang/rust#153109 (Fix LegacyKeyValueFormat report from docker build: aarch64-gnu-debug) - rust-lang/rust#153172 (Fix comment about placeholders) - rust-lang/rust#153187 (Fix ICE when macro-expanded extern crate shadows std) - rust-lang/rust#153190 (Don't allow subdiagnostic to use variables from their parent) - rust-lang/rust#153200 (Remove redundant clone) - rust-lang/rust#153216 (mark two polonius tests as known-bug)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @lcnr
When this was introduced, briefly returned an
Option, which is what the comment refers to.a9f1e1c#diff-8d11697c196da9f44774488ae0bf353283e5c6466a6dd570d7818431b73d4a44R511
Before that this code would just panic, and in the commit right after fixing review comments it does so again:
cf001dc#diff-8d11697c196da9f44774488ae0bf353283e5c6466a6dd570d7818431b73d4a44R560
That comment has been copied around for 5 years now despite not reflecting the behavior hehe
Second commit has some general typos I found