Improve cross-crate trait impl param mismatch suggestions by reddevilmidzy · Pull Request #149027 · rust-lang/rust

reddevilmidzy · 2025-11-17T14:20:12Z

rustbot · 2025-11-17T17:04:14Z

rustbot has assigned @madsmtm.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

madsmtm

Sorry for the delay in getting back here, this slipped my notifications.

Did you have a look at the previous implementation? #107548

Some of the tests in that one contains //~| HELP attributes, which I think is useful for actually testing that the behaviour is what we desire.

View changes since this review

tests/ui/impl-trait/in-trait/method-signature-matches.too_few.stderr

compiler/rustc_hir_analysis/src/check/compare_impl_item.rs

tests/ui/impl-trait/trait_type.stderr

compiler/rustc_hir_analysis/src/check/compare_impl_item.rs

rustbot · 2025-12-13T15:57:34Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

reddevilmidzy · 2025-12-15T16:02:46Z

@rustbot ready

madsmtm

Thanks, I had another look through, I like the test you've added, but I still feel that the approach with extracting the signature from spans is the wrong one (though maybe that's just me hating span calculation code), have expanded upon it in a comment.

View changes since this review

tests/ui/suggestions/trait-impl-param-mismatched-cross-crate.stderr

tests/ui/suggestions/trait-impl-param-mismatched-cross-crate.rs

compiler/rustc_hir_analysis/src/check/compare_impl_item.rs

rustbot · 2026-02-01T05:39:40Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

wesleywiser · 2026-02-19T15:34:05Z

Hi @madsmtm, just a friendly reminder if you have time to look at this PR. The author seems to have addressed all the previous review feedback and rebased 🙂

madsmtm

Thanks for the ping, I'm sorry I haven't gotten back to this sooner.

Things look great, feel free to r=me when the potentially_plural_count is resolved.

View changes since this review

compiler/rustc_hir_analysis/src/check/compare_impl_item.rs

madsmtm · 2026-02-26T11:39:56Z

@bors delegate+

rust-bors · 2026-02-26T11:39:58Z

✌️ @reddevilmidzy, you can now approve this pull request!

If @madsmtm told you to "r=me" after making some further change, then please make that change and post @bors r=madsmtm.

reddevilmidzy · 2026-02-28T05:27:54Z

Thanks for the review! I added the comment you mentioned and changed potentially_plural_count to pluralize!.

reddevilmidzy · 2026-02-28T06:57:55Z

@bors r=madsmtm

rust-bors · 2026-02-28T06:57:57Z

📌 Commit 97748ad has been approved by madsmtm

It is now in the queue for this repository.

Improve cross-crate trait impl param mismatch suggestions resolve: rust-lang#106999

…uwer Rollup of 12 pull requests Successful merges: - #153211 (`rust-analyzer` subtree update) - #149027 (Improve cross-crate trait impl param mismatch suggestions ) - #152730 (add field representing types) - #153136 (Correctly handle `#[doc(alias = "...")]` attribute on inlined reexports) - #152165 (Normalize capture place `ty`s to prevent ICE) - #152615 (refactor 'valid for read/write' definition: exclude null) - #153109 (Fix LegacyKeyValueFormat report from docker build: aarch64-gnu-debug) - #153172 (Fix comment about placeholders) - #153187 (Fix ICE when macro-expanded extern crate shadows std) - #153190 (Don't allow subdiagnostic to use variables from their parent) - #153200 (Remove redundant clone) - #153216 (mark two polonius tests as known-bug)

Rollup merge of #149027 - reddevilmidzy:suggest, r=madsmtm Improve cross-crate trait impl param mismatch suggestions resolve: #106999

…uwer Rollup of 12 pull requests Successful merges: - rust-lang/rust#153211 (`rust-analyzer` subtree update) - rust-lang/rust#149027 (Improve cross-crate trait impl param mismatch suggestions ) - rust-lang/rust#152730 (add field representing types) - rust-lang/rust#153136 (Correctly handle `#[doc(alias = "...")]` attribute on inlined reexports) - rust-lang/rust#152165 (Normalize capture place `ty`s to prevent ICE) - rust-lang/rust#152615 (refactor 'valid for read/write' definition: exclude null) - rust-lang/rust#153109 (Fix LegacyKeyValueFormat report from docker build: aarch64-gnu-debug) - rust-lang/rust#153172 (Fix comment about placeholders) - rust-lang/rust#153187 (Fix ICE when macro-expanded extern crate shadows std) - rust-lang/rust#153190 (Don't allow subdiagnostic to use variables from their parent) - rust-lang/rust#153200 (Remove redundant clone) - rust-lang/rust#153216 (mark two polonius tests as known-bug)

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 17, 2025

This comment has been minimized.

Sign in to view

reddevilmidzy force-pushed the suggest branch from a989b57 to 3d5d61f Compare November 17, 2025 14:38

This comment has been minimized.

Sign in to view

reddevilmidzy force-pushed the suggest branch from 3d5d61f to 3cecb85 Compare November 17, 2025 15:31

reddevilmidzy marked this pull request as ready for review November 17, 2025 17:04

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 17, 2025

rustbot assigned madsmtm Nov 17, 2025

rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Nov 17, 2025

reddevilmidzy force-pushed the suggest branch from 3cecb85 to e408b20 Compare November 19, 2025 17:31

This comment has been minimized.

Sign in to view

reddevilmidzy force-pushed the suggest branch from e408b20 to 3cecb85 Compare November 19, 2025 17:46

madsmtm added A-diagnostics Area: Messages for errors, warnings, and lints A-suggestion-diagnostics Area: Suggestions generated by the compiler applied by `cargo fix` labels Nov 20, 2025

madsmtm requested changes Dec 13, 2025

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 13, 2025

reddevilmidzy force-pushed the suggest branch from 3cecb85 to 9f65b05 Compare December 15, 2025 15:02

This comment has been minimized.

Sign in to view

reddevilmidzy force-pushed the suggest branch from 9f65b05 to 34b2df8 Compare December 15, 2025 15:05

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 15, 2025

madsmtm requested changes Dec 15, 2025

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 15, 2025

reddevilmidzy force-pushed the suggest branch from 2a476e7 to 0e8c962 Compare December 16, 2025 15:54

reddevilmidzy force-pushed the suggest branch from ee0499f to 3443d4c Compare February 1, 2026 05:39

madsmtm reviewed Feb 26, 2026

View reviewed changes

madsmtm approved these changes Feb 26, 2026

View reviewed changes

madsmtm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 26, 2026

rust-cloud-vms bot force-pushed the suggest branch from 3443d4c to f3ca2c4 Compare February 28, 2026 05:28

This comment has been minimized.

Sign in to view

Improve cross-crate trait impl param mismatch suggestions

97748ad

rust-cloud-vms bot force-pushed the suggest branch from f3ca2c4 to 97748ad Compare February 28, 2026 05:30

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 28, 2026

reddevilmidzy changed the title ~~Implement method signature suggestion for trait mismatches error~~ Improve cross-crate trait impl param mismatch suggestions Feb 28, 2026

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Feb 28, 2026

Rollup merge of rust-lang#149027 - reddevilmidzy:suggest, r=madsmtm

ffa5d6c

Improve cross-crate trait impl param mismatch suggestions resolve: rust-lang#106999

JonathanBrouwer mentioned this pull request Feb 28, 2026

Rollup of 9 pull requests #153208

Closed

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Feb 28, 2026

Rollup merge of rust-lang#149027 - reddevilmidzy:suggest, r=madsmtm

5cb42db

Improve cross-crate trait impl param mismatch suggestions resolve: rust-lang#106999

This was referenced Feb 28, 2026

Rollup of 11 pull requests #153212

Closed

Rollup of 12 pull requests #153217

Merged

rust-bors bot merged commit 4dd3fea into rust-lang:main Feb 28, 2026
11 checks passed

rustbot added this to the 1.96.0 milestone Feb 28, 2026

rust-timer added a commit that referenced this pull request Feb 28, 2026

Unrolled build for #149027

a1fa3d8

Rollup merge of #149027 - reddevilmidzy:suggest, r=madsmtm Improve cross-crate trait impl param mismatch suggestions resolve: #106999

reddevilmidzy deleted the suggest branch February 28, 2026 16:03

Uh oh!

Conversation

reddevilmidzy commented Nov 17, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

rustbot commented Nov 17, 2025

Uh oh!

This comment has been minimized.

madsmtm left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rustbot commented Dec 13, 2025

Uh oh!

This comment has been minimized.

reddevilmidzy commented Dec 15, 2025

Uh oh!

madsmtm left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rustbot commented Feb 1, 2026

Uh oh!

wesleywiser commented Feb 19, 2026

Uh oh!

madsmtm left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

madsmtm commented Feb 26, 2026

Uh oh!

rust-bors bot commented Feb 26, 2026

Uh oh!

reddevilmidzy commented Feb 28, 2026

Uh oh!

This comment has been minimized.

reddevilmidzy commented Feb 28, 2026

Uh oh!

rust-bors bot commented Feb 28, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

reddevilmidzy commented Nov 17, 2025 •

edited by rustbot

Loading

madsmtm left a comment •

edited by rustbot

Loading

madsmtm left a comment •

edited

Loading

madsmtm left a comment •

edited by rustbot

Loading