Skip to content

Stabilize control_flow_ok#152911

Merged
rust-bors[bot] merged 2 commits intorust-lang:mainfrom
nxsaken:stable_control_flow_ok
Mar 3, 2026
Merged

Stabilize control_flow_ok#152911
rust-bors[bot] merged 2 commits intorust-lang:mainfrom
nxsaken:stable_control_flow_ok

Conversation

@nxsaken
Copy link
Contributor

@nxsaken nxsaken commented Feb 20, 2026 •
edited by rustbot
Loading

Feature: control_flow_ok
Tracking issue: #140266

r? @dtolnay

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Feb 20, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@fee1-dead
Copy link
Member

fee1-dead commented Feb 20, 2026

this probably needs #[rustc_allow_const_fn_unstable(const_precise_live_drops)]. cc @rust-lang/wg-const-eval

@nxsaken
Copy link
Contributor Author

nxsaken commented Feb 20, 2026

See #t-compiler/project-const-traits > const Destruct required on stable, not nightly (?)

@rustbot
Copy link
Collaborator

rustbot commented Feb 20, 2026

⚠️ #[rustc_allow_const_fn_unstable] needs careful audit to avoid accidentally exposing unstable
implementation details on stable.

cc @rust-lang/wg-const-eval

dtolnay
dtolnay approved these changes Mar 3, 2026
View reviewed changes
Copy link
Member

@dtolnay dtolnay left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

View changes since this review

@dtolnay
Copy link
Member

dtolnay commented Mar 3, 2026

@bors r+

@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 3, 2026

📌 Commit c5da0e3 has been approved by dtolnay

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 3, 2026
@JonathanBrouwer JonathanBrouwer mentioned this pull request Mar 3, 2026
Merged
rust-bors bot pushed a commit that referenced this pull request Mar 3, 2026
@bors
Auto merge of #153355 - JonathanBrouwer:rollup-Bh4zTly, r=JonathanBro…
9c4bb2e 
…uwer

Rollup of 4 pull requests

Successful merges:

 - #152712 (Use shell-words to parse output from llvm-config)
 - #152911 (Stabilize `control_flow_ok`)
 - #153223 (Fix LegacyKeyValueFormat report from docker build: host-aarch64)
 - #153345 (MGCA: fix type error handling for const array and tuple lowering logic)
rust-bors bot pushed a commit that referenced this pull request Mar 3, 2026
@bors
Auto merge of #153355 - JonathanBrouwer:rollup-Bh4zTly, r=JonathanBro…
9dca545 
…uwer

Rollup of 4 pull requests

Successful merges:

 - #152712 (Use shell-words to parse output from llvm-config)
 - #152911 (Stabilize `control_flow_ok`)
 - #153223 (Fix LegacyKeyValueFormat report from docker build: host-aarch64)
 - #153345 (MGCA: fix type error handling for const array and tuple lowering logic)
rust-bors bot pushed a commit that referenced this pull request Mar 3, 2026
@bors
Auto merge of #153355 - JonathanBrouwer:rollup-Bh4zTly, r=JonathanBro…
d956393 
…uwer

Rollup of 4 pull requests

Successful merges:

 - #152712 (Use shell-words to parse output from llvm-config)
 - #152911 (Stabilize `control_flow_ok`)
 - #153223 (Fix LegacyKeyValueFormat report from docker build: host-aarch64)
 - #153345 (MGCA: fix type error handling for const array and tuple lowering logic)
@rust-bors rust-bors bot merged commit f4810cb into rust-lang:main Mar 3, 2026
11 checks passed
@rustbot rustbot added this to the 1.96.0 milestone Mar 3, 2026
rust-timer added a commit that referenced this pull request Mar 3, 2026
@rust-timer
Unrolled build for #152911
d431560 
Rollup merge of #152911 - nxsaken:stable_control_flow_ok, r=dtolnay

Stabilize `control_flow_ok`

Feature: `control_flow_ok`
Tracking issue: #140266

r? @dtolnay
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees

@dtolnay dtolnay

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

5 participants

@nxsaken @rust-log-analyzer @fee1-dead @rustbot @dtolnay