Use shell-words to parse output from llvm-config by eggyal · Pull Request #152712 · rust-lang/rust

eggyal · 2026-02-16T13:28:11Z

llvm-config might output paths that contain spaces, in which case the naive approach of splitting on whitespace breaks; instead we ask llvm-config to quote any paths and use the shell-words crate by @tmiasko (a new dependency) to parse the output.

r? ChrisDenton
Fixes #152707

rustbot · 2026-02-16T13:28:14Z

The list of allowed third-party dependencies may have been modified! You must ensure that any new dependencies have compatible licenses before merging.

cc @davidtwco, @wesleywiser

rustbot · 2026-02-16T13:28:17Z

ChrisDenton is currently at their maximum review capacity.
They may take a while to respond.

eggyal · 2026-02-16T13:28:44Z

I haven't added a test for this. Not entirely sure how we can do so, if it's desired?

ChrisDenton · 2026-02-16T13:42:03Z

Oh, it seems --quote-paths is too new for the oldest llvm version we use. Either we need to delay this or else add some logic to detect if it's supported.

ChrisDenton · 2026-02-16T13:45:55Z

I haven't added a test for this. Not entirely sure how we can do so, if it's desired?

Properly checking would require checking out the source into a directory with a space in its name and trying to build from there. That may be kind of expensive in CI time though. Maybe it would be sufficient to have a wrapper we can unit test.

ChrisDenton · 2026-02-16T13:55:41Z

If a backport is approved then that's definitely better!

eggyal · 2026-02-16T14:03:10Z

Hm, no, that commit is already in the llvm-project submodule that we're using.

ChrisDenton · 2026-02-16T14:10:17Z

Looking again, it seems to be using the system llvm so our backports won't help: /usr/lib/llvm-20/bin/llvm-config.

eggyal · 2026-02-16T20:07:20Z

Now determining whether llvm-config supports --quote-paths by searching for "quote-paths" in the output of llvm-config --help.

compiler/rustc_llvm/build.rs

llvm-config might output paths that contain spaces, in which case the naive approach of splitting on whitespace breaks; instead we ask llvm-config to quote any paths and use the shell-words crate to parse the output.

Zalathar · 2026-02-17T02:17:26Z

I haven't added a test for this. Not entirely sure how we can do so, if it's desired?

From looking at LLVM's sys::printArg (in src/llvm-project/llvm/lib/Support/Program.cpp), it seems that if a path contains any of " \ $, then LLVM will quote the whole thing even if it contains no spaces.

So even if we aren't specifically testing the quoted-spaces case, if this continues to work in Windows CI jobs then that should be a pretty decent proxy-test for quote-aware parsing.

(I'm assuming that on Windows, filesystem paths will naturally tend to contain \, though I haven't confirmed this.)

eggyal · 2026-02-17T02:55:08Z

if this continues to work in Windows CI jobs then that should be a pretty decent proxy-test for quote-aware parsing.

Provided one or more of the Windows CI jobs are using LLVM 22?

Zalathar · 2026-02-17T02:58:18Z

As I understand it, almost all CI jobs use the in-tree LLVM submodule (which is currently 22), except for the ones that specifically exist to test a numbered out-of-tree LLVM.

ChrisDenton · 2026-03-03T12:11:08Z

Ok, the new dependency looks good to me (and david has checked the license) so I think we're fine on that front. This looks good to go, thanks!

@bors r+

rust-bors · 2026-03-03T12:11:10Z

📌 Commit c30e20a has been approved by ChrisDenton

It is now in the queue for this repository.

@tmiasko

Use shell-words to parse output from llvm-config llvm-config might output paths that contain spaces, in which case the naive approach of splitting on whitespace breaks; instead we ask llvm-config to quote any paths and use the [shell-words](https://crates.io/crates/shell-words) crate by @tmiasko (a new dependency) to parse the output. r? ChrisDenton Fixes rust-lang#152707

@tmiasko

Use shell-words to parse output from llvm-config llvm-config might output paths that contain spaces, in which case the naive approach of splitting on whitespace breaks; instead we ask llvm-config to quote any paths and use the [shell-words](https://crates.io/crates/shell-words) crate by @tmiasko (a new dependency) to parse the output. r? ChrisDenton Fixes rust-lang#152707

…uwer Rollup of 4 pull requests Successful merges: - #152164 (Lint unused features) - #152712 (Use shell-words to parse output from llvm-config) - #153223 (Fix LegacyKeyValueFormat report from docker build: host-aarch64) - #153345 (MGCA: fix type error handling for const array and tuple lowering logic)

…uwer Rollup of 4 pull requests Successful merges: - #152712 (Use shell-words to parse output from llvm-config) - #152911 (Stabilize `control_flow_ok`) - #153223 (Fix LegacyKeyValueFormat report from docker build: host-aarch64) - #153345 (MGCA: fix type error handling for const array and tuple lowering logic)

@tmiasko

Use shell-words to parse output from llvm-config llvm-config might output paths that contain spaces, in which case the naive approach of splitting on whitespace breaks; instead we ask llvm-config to quote any paths and use the [shell-words](https://crates.io/crates/shell-words) crate by @tmiasko (a new dependency) to parse the output. r? ChrisDenton Fixes #152707

rust-bors · 2026-03-03T19:02:37Z

⌛ Testing commit c30e20a with merge bf3d4c6...

JonathanBrouwer · 2026-03-03T19:04:43Z

@bors yield
Yielding to enclosing rollup

rust-bors · 2026-03-03T19:04:52Z

Auto build cancelled. Cancelled workflows:

https://github.com/rust-lang/rust/actions/runs/22638319995

The next pull request likely to be tested is #153355.

…uwer Rollup of 4 pull requests Successful merges: - #152712 (Use shell-words to parse output from llvm-config) - #152911 (Stabilize `control_flow_ok`) - #153223 (Fix LegacyKeyValueFormat report from docker build: host-aarch64) - #153345 (MGCA: fix type error handling for const array and tuple lowering logic)

rust-bors · 2026-03-03T19:09:33Z

⌛ Testing commit c30e20a with merge 743f7a2...

Workflow: https://github.com/rust-lang/rust/actions/runs/22638541691

@tmiasko

Use shell-words to parse output from llvm-config llvm-config might output paths that contain spaces, in which case the naive approach of splitting on whitespace breaks; instead we ask llvm-config to quote any paths and use the [shell-words](https://crates.io/crates/shell-words) crate by @tmiasko (a new dependency) to parse the output. r? ChrisDenton Fixes #152707

rust-log-analyzer · 2026-03-03T19:22:39Z

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

JonathanBrouwer · 2026-03-03T19:26:00Z

@bors yield
Yielding to enclosing rollup

rust-bors · 2026-03-03T19:26:04Z

Auto build cancelled. Cancelled workflows:

https://github.com/rust-lang/rust/actions/runs/22638541691

The next pull request likely to be tested is #153355.

…uwer Rollup of 4 pull requests Successful merges: - #152712 (Use shell-words to parse output from llvm-config) - #152911 (Stabilize `control_flow_ok`) - #153223 (Fix LegacyKeyValueFormat report from docker build: host-aarch64) - #153345 (MGCA: fix type error handling for const array and tuple lowering logic)

rust-log-analyzer · 2026-03-03T20:07:43Z

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

bjorn3 · 2026-03-03T23:08:30Z

How does shell-words compare with shlex? The latter is already a dependency of the cc crate.

@tmiasko

Rollup merge of #152712 - eggyal:quote-lib-paths, r=ChrisDenton Use shell-words to parse output from llvm-config llvm-config might output paths that contain spaces, in which case the naive approach of splitting on whitespace breaks; instead we ask llvm-config to quote any paths and use the [shell-words](https://crates.io/crates/shell-words) crate by @tmiasko (a new dependency) to parse the output. r? ChrisDenton Fixes #152707

eggyal · 2026-03-03T23:27:00Z

I wasn't aware of shlex, but from a cursory glance it actually looks slightly better suited as we can avoid parsing into a Vec<String> and instead use the Shlex iterator.

…risDenton Use shlex instead of shell-words In rust-lang#152712, the [`shell-words`] crate was introduced as a new dependency of `rustc_llvm` in order for its build script to parse the output of `llvm-config --quote-paths` and thereby handle paths containing whitespace; however, as [noted by bjorn3], that build script already transitively depends upon the [`shlex`] crate (via the [`cc`] crate) which provides similar functionality. This patch is based off (the already-approved) rust-lang#153419, which would otherwise conflict. [`cc`]: https://crates.io/crates/cc [noted by bjorn3]: rust-lang#152712 (comment) [`shell-words`]: https://crates.io/crates/shell-words [`shlex`]: https://crates.io/crates/shlex r? ChrisDenton

Rollup merge of #153436 - eggyal:shlex-not-shell_words, r=ChrisDenton Use shlex instead of shell-words In #152712, the [`shell-words`] crate was introduced as a new dependency of `rustc_llvm` in order for its build script to parse the output of `llvm-config --quote-paths` and thereby handle paths containing whitespace; however, as [noted by bjorn3], that build script already transitively depends upon the [`shlex`] crate (via the [`cc`] crate) which provides similar functionality. This patch is based off (the already-approved) #153419, which would otherwise conflict. [`cc`]: https://crates.io/crates/cc [noted by bjorn3]: #152712 (comment) [`shell-words`]: https://crates.io/crates/shell-words [`shlex`]: https://crates.io/crates/shlex r? ChrisDenton

rustbot assigned ChrisDenton Feb 16, 2026

This comment has been minimized.

Sign in to view

This comment was marked as outdated.

Sign in to view

eggyal force-pushed the quote-lib-paths branch from 06e14f1 to d3679f4 Compare February 16, 2026 20:03

Zalathar reviewed Feb 16, 2026

View reviewed changes

compiler/rustc_llvm/build.rs Show resolved Hide resolved

Use shell-words to parse output from llvm-config

c30e20a

llvm-config might output paths that contain spaces, in which case the naive approach of splitting on whitespace breaks; instead we ask llvm-config to quote any paths and use the shell-words crate to parse the output.

eggyal force-pushed the quote-lib-paths branch from d3679f4 to c30e20a Compare February 16, 2026 23:57

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 3, 2026

JonathanBrouwer mentioned this pull request Mar 3, 2026

Rollup of 2 pull requests #153348

Closed

JonathanBrouwer mentioned this pull request Mar 3, 2026

Rollup of 4 pull requests #153349

Closed

JonathanBrouwer mentioned this pull request Mar 3, 2026

Rollup of 4 pull requests #153355

Merged

rust-bors bot merged commit 6a44bbd into rust-lang:main Mar 3, 2026
11 of 12 checks passed

rustbot added this to the 1.96.0 milestone Mar 3, 2026

cuviper mentioned this pull request Mar 5, 2026

rustc_llvm: add missing - to flag-comparison logic #153419

Merged

eggyal mentioned this pull request Mar 5, 2026

Use shlex instead of shell-words #153436

Merged

Uh oh!

Conversation

eggyal commented Feb 16, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Feb 16, 2026

Uh oh!

rustbot commented Feb 16, 2026

Uh oh!

eggyal commented Feb 16, 2026

Uh oh!

This comment has been minimized.

ChrisDenton commented Feb 16, 2026

Uh oh!

ChrisDenton commented Feb 16, 2026

Uh oh!

This comment was marked as outdated.

ChrisDenton commented Feb 16, 2026

Uh oh!

eggyal commented Feb 16, 2026

Uh oh!

ChrisDenton commented Feb 16, 2026

Uh oh!

eggyal commented Feb 16, 2026

Uh oh!

Uh oh!

Zalathar commented Feb 17, 2026

Uh oh!

eggyal commented Feb 17, 2026

Uh oh!

Zalathar commented Feb 17, 2026

Uh oh!

ChrisDenton commented Mar 3, 2026

Uh oh!

rust-bors bot commented Mar 3, 2026

Uh oh!

rust-bors bot commented Mar 3, 2026

Uh oh!

JonathanBrouwer commented Mar 3, 2026

Uh oh!

rust-bors bot commented Mar 3, 2026

Uh oh!

rust-bors bot commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-log-analyzer commented Mar 3, 2026

Uh oh!

JonathanBrouwer commented Mar 3, 2026

Uh oh!

rust-bors bot commented Mar 3, 2026

Uh oh!

rust-log-analyzer commented Mar 3, 2026

Uh oh!

bjorn3 commented Mar 3, 2026

Uh oh!

Uh oh!

eggyal commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

eggyal commented Feb 16, 2026 •

edited by rustbot

Loading

rust-bors bot commented Mar 3, 2026 •

edited

Loading

eggyal commented Mar 3, 2026 •

edited

Loading