Clippy subtree update#152533
Conversation
The file is testing `unwrap_used`, but that's already covered by the `unwrap_expect_used.rs` test file
…nnethercote Bump bootstrap compiler to 1.94 https://forge.rust-lang.org/release/process.html#default-branch-bootstrap-update-tuesday
…Amanieu Move assert_matches to planned stable path Another prep PR for rust-lang#137487
The file is testing `unwrap_used`, but that's already covered by the `unwrap_expect_used.rs` test file changelog: none
Adds a trailing comma to struct patterns ending with `..`. Fixes rust-lang#16433
Now, only `call_span` is replaced, so the receiver is not a part of the diff. This also removes the need to create a snippet for the receiver.
…ust-lang#16198) Noticed while writing a copy of subtree sync docs for `rustfmt`. changelog: none
…nishearth Clippy subtree update r? Manishearth `Cargo.lock` update due to Clippy version bump.
This makes rustc simply return an exit code from main rather than calling `std::process::exit` with an exit code. This means that drops run normally and the process exits cleanly. Also instead of hard coding success and failure codes this uses `ExitCode::SUCCESS` and `ExitCode::FAILURE`, which in turn effectively uses `libc::EXIT_SUCCESS` and `libc::EXIT_FAILURE` (via std). These are `0` and `1` respectively for all currently supported host platforms so it doesn't actually change the exit code.
…th `..` (rust-lang#16442) fixes rust-lang/rust-clippy#16433 Adds a trailing comma to the last field of a struct pattern if it ends with a `..` to avoid an invalid suggestion. A test was added as well. changelog: [`manual_let_else`] fix suggestion for `..` patterns
std: avoid tearing `dbg!` prints Fixes rust-lang#136703. This is an alternative to rust-lang#149859. Instead of formatting everything into a string, this PR makes multi-expression `dbg!` expand into multiple nested matches, with the final match containing a single `eprint!`. By using macro recursion and relying on hygiene, this allows naming every bound value in that `eprint!`. CC @orlp r? libs
Closes rust-lang/rust-clippy#16446 changelog: [`doc_markdown`] add PowerShell to whitelist
Related to the example in rust-lang/rust-clippy#16451 but doesn't fix the issue itself changelog: [`let_and_return`]: No longer lints when there's a comment between the `let` and return
changelog: [`never_loop`]: rhs of short-circuit expression doesn't always run Fixes rust-lang/rust-clippy#16462
Closes rust-lang/rust-clippy#16447 changelog: [`test_attr_in_doctest`] fix FP on `test_harness`
…16424) Closes rust-lang/rust-clippy#16419 changelog: [`manual_is_variant_and`] enhance to cover manual `is_none_or`
This comment has been minimized.
This comment has been minimized.
Clippy subtree update r? @Manishearth 1 week late, due to vacation and some technical issues.
|
The @bors retry (stalled job) |
|
❗ You can only retry pull requests that are approved and have a previously failed auto build. Hint: There is currently a pending auto build on this PR. To cancel it, run |
|
@bors cancel |
|
Auto build cancelled. Cancelled workflows: The next pull request likely to be tested is #152562. |
|
@bors retry |
|
❗ You can only retry pull requests that are approved and have a previously failed auto build. |
|
@bors r=Manishearth |
This comment has been minimized.
This comment has been minimized.
Clippy subtree update r? @Manishearth 1 week late, due to vacation and some technical issues.
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
💔 Test for 5bc5973 failed: CI. Failed job:
|
This comment has been minimized.
This comment has been minimized.
Clippy subtree update try-job: i686-msvc-1
This comment has been minimized.
This comment has been minimized.
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing d7daac0 (parent) -> a423f68 (this PR) Test differencesShow 4 test diffs4 doctest diffs were found. These are ignored, as they are noisy. Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard a423f68a0d75656eabab4982a06bed9f316f7109 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
Finished benchmarking commit (a423f68): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 479.255s -> 479.498s (0.05%) |
r? @Manishearth
1 week late, due to vacation and some technical issues.