Clippy subtree update by flip1995 · Pull Request #151501 · rust-lang/rust

flip1995 · 2026-01-22T18:03:48Z

r? Manishearth

Cargo.lock update due to Clippy version bump.

- update file name to match lint name - use `Symbol`s instead of `&str`s - get rid of needless lifetimes

…macro expns

Add checks for expressions such as `x != y && x >= y` and `x != y && x <= y`.

allow only whitespace between the comment marker and `SAFETY:`

@BoxyUwU

MGCA: Support tuple expressions as direct const arguments Tracking issue: rust-lang#132980 Fixes rust-lang#133965 Fixes rust-lang#150613 r? @BoxyUwU

The previous fix only handled `String`+`str`.

By postponing the creation of `Sugg`s, we can properly account for their effect on applicability

…unavailable

@bjorn3

Update `literal-escaper` version to `0.0.7` It removes the `std` dependency for this crate (which doesn't change anything for rustc 😄 ). cc @bjorn3 r? @Urgau

….rs`

…provenance_mut` Currently `without_provenance`/`without_provenance_mut` do not have a `rustc_diagnostic_item` so this change is dependent on them being added before being ready to be used. changelog: [`transmuting_null`]: now checks for [`ptr::without_provenance`](https://doc.rust-lang.org/core/ptr/fn.without_provenance.html) and [`ptr::without_provenance_mut`](https://doc.rust-lang.org/core/ptr/fn.without_provenance_mut.html) which create null pointers

@ghost

r? @ghost changelog: none

…ubtree-update

rustbot · 2026-01-22T18:03:53Z

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

rustbot · 2026-01-22T18:03:58Z

⚠️ Warning ⚠️

There are issue links (such as #123) in the commit messages of the following commits.
Please move them to the PR description, to avoid spamming the issues with references to the commit, and so this bot can automatically canonicalize them to avoid issues with subtree.
- b4dea7c
- ea21831
- 92608aa
- 0a83962
- 331a474
- 11fe0c6
- b94106a
- 5ebb322
- 5366824
- 8bd0931
- bcd52c1
- 669fbcb
- 88ab1a3
- 6f5048d
- a47cbd0
- 1437ea0
- 637108e
- 0a5825e
- 2a3eb6f
- 5ef494c
- d9d034c
- c267b59
- e256d3e
- d7e5996
- 60b3ecf
- a66ad93
- 5320bdb
- 73d05dd
- 6802a56
- 69e70c8
- 59b58ec
- 3404c3b
- 29e2b8d
- 4ab5ad4
- d25a26d
- a5ae164
- fe4bc31
- bbfe34e
- 4b98bd3
- f2b567f
- e5055d4
- 5448229

Manishearth · 2026-01-22T18:38:17Z

r=me, but build fails

samueltardieu · 2026-01-23T14:14:36Z

@bors r=Manishearth p=1 rollup=never

rust-bors · 2026-01-23T14:14:40Z

📌 Commit 2a62479 has been approved by Manishearth

It is now in the queue for this repository.

rust-bors · 2026-01-23T18:11:25Z

☀️ Test successful - CI
Approved by: Manishearth
Duration: 3h 13m 46s
Pushing d222ddc to main...

github-actions · 2026-01-23T18:14:19Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 5944b12 (parent) -> d222ddc (this PR)

Test differences

Show 4 test diffs

4 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard d222ddc4d90743dfc1e53b610be8fc9d95893d2c --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

tidy: 167.6s -> 143.6s (-14.4%)
dist-apple-various: 4115.5s -> 4706.5s (+14.4%)
x86_64-gnu-miri: 4788.0s -> 4104.9s (-14.3%)
i686-gnu-2: 5879.2s -> 5136.6s (-12.6%)
x86_64-rust-for-linux: 3098.9s -> 2716.2s (-12.4%)
aarch64-gnu-llvm-20-2: 3203.4s -> 2861.1s (-10.7%)
dist-riscv64-linux: 5434.5s -> 4882.5s (-10.2%)
aarch64-gnu: 8024.3s -> 7214.3s (-10.1%)
pr-check-1: 1847.3s -> 1666.7s (-9.8%)
i686-gnu-1: 8163.7s -> 7391.0s (-9.5%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2026-01-23T18:53:58Z

Finished benchmarking commit (d222ddc): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 1.7%, secondary -3.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.7%	[1.7%, 1.7%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.8%	[-3.8%, -3.8%]	1
All ❌✅ (primary)	1.7%	[1.7%, 1.7%]	1

Cycles

Results (primary -2.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.1%	[-2.3%, -2.0%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.1%	[-2.3%, -2.0%]	2

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 474.479s -> 470.684s (-0.80%)
Artifact size: 383.49 MiB -> 383.48 MiB (-0.00%)

…nishearth Clippy subtree update r? Manishearth `Cargo.lock` update due to Clippy version bump.

ada4a and others added 30 commits October 13, 2025 20:05

clean-up

1566879

- update file name to match lint name - use `Symbol`s instead of `&str`s - get rid of needless lifetimes

fix: use snippet_with_context for spans that are likely to contain …

4d79522

…macro expns

s/snippet/snippet_with_applicability while we're at it

b270954

double_comparison: add missing cases

d160cb7

Add checks for expressions such as `x != y && x >= y` and `x != y && x <= y`.

fix: map_unwrap_or fail to cover Result::unwrap_or

f2283e2

fix: map_unwrap_or FN on references

9565b28

Post needless_continue diagnostic on the right node

bd03414

fix: main_recursion enable lint in no_std crates and fix broken tests

9bfc9a4

Enhance needless_collect to cover vec push

aede29f

Extend needless_collect to also cover extend

6417c8f

Extend needless_collect to cover push_front

0127720

accept test changes related to binary ops

ce012da

Add span field for ConstArg

6b11237

recognize safety comments inside blocks and on same line in macros

d37d04a

allow only whitespace between the comment marker and `SAFETY:`

fix: map_unwrap_or suggests wrongly for empty slice

0db25db

fix: significant_drop_tightening suggests wrongly for non-method usage

4976fdf

Rollup merge of rust-lang#150675 - mgca/tuple-expr, r=BoxyUwU

53267d7

MGCA: Support tuple expressions as direct const arguments Tracking issue: rust-lang#132980 Fixes rust-lang#133965 Fixes rust-lang#150613 r? @BoxyUwU

Compile-Time Reflection MVP: tuples

72f1ac9

Update literal-escaper version to 0.0.7

21f6afc

MGCA: literals support

fb5c850

Do not warn on arithmetic side effect for String+String

331f75f

The previous fix only handled `String`+`str`.

clean-up

a4f0937

fix: respect applicability reduction due to Sugg

0cfc4ee

By postponing the creation of `Sugg`s, we can properly account for their effect on applicability

fix: don't lint if std or core are required for a suggestion but …

bdb1050

…unavailable

Rollup merge of rust-lang#150809 - update-literal-escaper, r=Urgau

55b0788

Update `literal-escaper` version to `0.0.7` It removes the `std` dependency for this crate (which doesn't change anything for rustc 😄 ). cc @bjorn3 r? @Urgau

clean-up

d0d7251

fix(float_point_arithmetic): respect reduced applicability

cb9a079

move floating_point_arithmetic.rs to `floating_point_arithmetic/mod…

7a377d6

….rs`

extract each check into a separate module

44a4104

flip1995 added 5 commits January 22, 2026 16:55

Bump nightly version -> 2026-01-22

21e84b5

Bump Clippy version -> 0.1.95

0f9b027

Rustup (rust-lang#16438)

5448229

r? @ghost changelog: none

Merge commit '54482290b5f32e6c6b57cc9e0a17153f432b0036' into clippy-s…

0e8e621

…ubtree-update

Update Cargo.lock

e2d6de7

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-clippy Relevant to the Clippy team. labels Jan 22, 2026

rustbot assigned Manishearth Jan 22, 2026

This comment has been minimized.

Sign in to view

bootstrap: fix Clippy warning

2a62479

rustbot added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Jan 23, 2026

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 23, 2026

This comment has been minimized.

Sign in to view

rust-bors bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 23, 2026

rust-bors bot merged commit d222ddc into rust-lang:main Jan 23, 2026
12 checks passed

rustbot added this to the 1.95.0 milestone Jan 23, 2026

This was referenced Jan 23, 2026

Add String<A> type with custom allocator parameter #149328

Open

Return ExitCode from rustc_driver::main instead of calling process::exit #150379

Merged

flip1995 deleted the clippy-subtree-update branch January 26, 2026 12:44

flip1995 pushed a commit to flip1995/rust that referenced this pull request Feb 12, 2026

Auto merge of rust-lang#151501 - flip1995:clippy-subtree-update, r=Ma…

529b820

…nishearth Clippy subtree update r? Manishearth `Cargo.lock` update due to Clippy version bump.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Clippy subtree update#151501

Clippy subtree update#151501
rust-bors[bot] merged 132 commits intorust-lang:mainfrom
flip1995:clippy-subtree-update

flip1995 commented Jan 22, 2026

Uh oh!

rustbot commented Jan 22, 2026

Uh oh!

rustbot commented Jan 22, 2026

Uh oh!

This comment has been minimized.

Manishearth commented Jan 22, 2026

Uh oh!

samueltardieu commented Jan 23, 2026

Uh oh!

rust-bors bot commented Jan 23, 2026

Uh oh!

This comment has been minimized.

rust-bors bot commented Jan 23, 2026

Uh oh!

Uh oh!

github-actions bot commented Jan 23, 2026

Uh oh!

rust-timer commented Jan 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Uh oh!

Conversation

flip1995 commented Jan 22, 2026

Uh oh!

rustbot commented Jan 22, 2026

Uh oh!

rustbot commented Jan 22, 2026

Uh oh!

This comment has been minimized.

Manishearth commented Jan 22, 2026

Uh oh!

samueltardieu commented Jan 23, 2026

Uh oh!

rust-bors bot commented Jan 23, 2026

Uh oh!

This comment has been minimized.

rust-bors bot commented Jan 23, 2026

Uh oh!

Uh oh!

github-actions bot commented Jan 23, 2026

Test differences

Job duration changes

Uh oh!

rust-timer commented Jan 23, 2026

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants