Revert doc attribute parsing errors to future warnings#151952
Merged
rust-bors[bot] merged 3 commits intorust-lang:mainfrom Feb 4, 2026
Merged
Revert doc attribute parsing errors to future warnings#151952rust-bors[bot] merged 3 commits intorust-lang:mainfrom
rust-bors[bot] merged 3 commits intorust-lang:mainfrom
Conversation
Collaborator
|
Some changes occurred in compiler/rustc_attr_parsing |
rustbot
added
A-attributes
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
revert-error-to-future-warning
branch
from
746bbbd to
5e7c152
Compare
This comment has been minimized.
This comment has been minimized.
Member
Author
|
Ah, so it's still flaky. |
JonathanBrouwer
added
the
beta-nominated
Contributor
|
@rustbot author |
rustbot
added
S-waiting-on-author
Contributor
|
I think there are a few options then
My proposal would be merge #3 into nightly, backport it, then on nightly do #4 |
Contributor
|
I’m confused. Why is modifying a lint a problem? Isn’t cap-lints supposed to solve this, even for deny-by-default lints? |
Contributor
|
I was not aware of that option, that makes life slightly better. However, a new deny-by-default lint does still break users, as they need to fix the problem or set These cases will immediately go from being silently ignored to deny-by-default linted, meaning users don't get time to fix the problem If I'm wrong and the consensus is that what I'm describing is considered acceptable breakage, lmk |
Contributor
|
The important part is that Cargo sets cap-lints=allow by default for your dependencies. This means you only get an error if a crate in your own workspace triggers it, and, if it does, you can immediately fix it by slapping |
Contributor
|
Ah I see, in that case I think making the lint deny by default is reasonably acceptable user breakage. Thanks for explaining! |
JonathanBrouwer
approved these changes
Feb 3, 2026
Contributor
There was a problem hiding this comment.
r=me after #151944 merged & this pr is rebased on that
GuillaumeGomez
force-pushed
the
revert-error-to-future-warning
branch
from
5e7c152 to
c910511
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Member
Author
|
@bors r=JonathanBrouwer rollup |
Contributor
rust-bors
bot
added
S-waiting-on-bors
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 4, 2026
…uwer Rollup of 12 pull requests Successful merges: - #150992 (link modifier `export-symbols`: export all global symbols from selected uptream c static libraries) - #151534 (target: fix destabilising target-spec-json) - #152088 (rustbook/README.md: add missing `)`) - #151526 (Fix autodiff codegen tests) - #151810 (citool: report debuginfo test statistics) - #151952 (Revert doc attribute parsing errors to future warnings) - #152065 (Convert to inline diagnostics in `rustc_ty_utils`) - #152066 (Convert to inline diagnostics in `rustc_session`) - #152069 (Convert to inline diagnostics in `rustc_privacy`) - #152072 (Convert to inline diagnostics in `rustc_monomorphize`) - #152083 (Fix set_times_nofollow for directory on windows) - #152102 (Convert to inline diagnostics in all codegen backends) Failed merges: - #152068 (Convert to inline diagnostics in `rustc_resolve`) - #152070 (Convert to inline diagnostics in `rustc_pattern_analysis`)
rust-timer
added a commit
that referenced
this pull request
Feb 4, 2026
Rollup merge of #151952 - GuillaumeGomez:revert-error-to-future-warning, r=JonathanBrouwer Revert doc attribute parsing errors to future warnings Part of #151865 (hopefully fixes it). r? @JonathanBrouwer
Contributor
rustbot
added
the
beta-accepted
cuviper
removed
the
beta-nominated
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 12, 2026
[beta] backports, plus stable versions in stdarch - Replace `stdarch` version placeholders with 1.94 - Parse ident with allowing recovery when trying to diagnose #151249 - Revert enabling `outline-atomics` on various platforms #151896 - Revert doc attribute parsing errors to future warnings #151952 - Remove the 4 failing tests from rustdoc-gui #152194 - Remove rustdoc GUI flaky test #152116 - Align `ArrayWindows` trait impls with `Windows` #151613 - Fix suppression of `unused_assignment` in binding of `unused_variable` #151556 - layout: handle rigid aliases without params #151814 - Fix missing unused_variables lint when using a match guard #151990 - Partially revert "resolve: Update `NameBindingData::vis` in place" #152498 - [BETA]: parse array lengths without stripping const blocks #152237 r? cuviper
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #151865 (hopefully fixes it).
r? @JonathanBrouwer