-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
Rollup of 5 pull requests #151816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 5 pull requests #151816
Conversation
…m-portable-simd-2025-01-18
The `#[must_use]` attribute has no effect when applied to methods in trait implementations.
…m-portable-simd-2025-03-19
…3-20 Sync upstream
Fix grammar in beginners-guide.md
Remove usize/isize impls from - `loongarch64.rs` - `wasm32.rs` - `x86.rs`
Remove usize/isize `From` impls for vendor vector types
Add const to `as_mut_array`, `copy_to_slice`
Make `Mask::splat` const
clippy fix: use div_ceil
Fix compilation for AVX512
Update examples to remove features that have been stabilized
This reverts commit 323484c.
Update nightly toolchain and `Cargo.lock`, fix examples broken by stabilized features
loongarch64: Use unified data types for SIMD intrinsics
…imd-2026-01-28, r=folkertdev Portable SIMD subtree update cc @folkertdev @programmerjake
Tweak E0599 to consolidate unsatisfied trait bound messages Fixes rust-lang#114430 r? @estebank
fix(parser): Disallow CR in frontmatter T-lang came back on the stabilization PR (rust-lang#148051) asking for CR to be disallowed to leave room for all stray CRs to be rejected in the future. At that point, the test can remain but the implementation can be removed. If that plan does not go through, we'll need to re-evaluate - whether this is more lint-like and should defer to the calling tool that is managing the frontmatter - how much Rust should treat the frontmatter as Rust and apply the same grammar restrictions of "no stray CR" (like raw string literals) Part of rust-lang#136889
…, r=Kivooeo add foregin type tests for issue 64458 add tests/ui/rfcs/rfc-1861-extern-types/comparison.rs close rust-lang#64458
Cleanup of `#[derive(Diagnostic)]` attribute parsers This PR does a lot of refactoring on the implementation of `#[derive(Diagnostic)]`. It should have no observable effect other than error messages for incorrect usage of the attributes. In general, I think the error messages got better. This PR can be reviewed commit by commit, each commit passes the tests. - [Convert parse_nested_meta to parse_args_with for #[diagnostic]](rust-lang@9e61014) Start parsing `#[diagnostic]` using `syn`'s `parse_args_with` function instead of `parse_nested_meta`. This improves error messages and prepares for the new syntax needed for rust-lang#151366 which cannot be parsed using `parse_args_with`. - [Convert parse_nested_meta to parse_args_with for #[subdiagnostic]](rust-lang@5d21a21) Same as above but for `#[subdiagnostic]` - [Remove unused no_span option](rust-lang@0bf3f5d) Removes the `no_span` option of `#[suggestion]`, which there were no tests for and which seems to have been unused. If needed again in the future, this can be re-added pretty easily, but I find that unlikely. - [Remove HasFieldMap trait in favour of passing FieldMap directly](rust-lang@2e8347a) Removes the `HasFieldMap` trait, because I don't really see the point of having a trait "has a field map" if we can just pass the fieldmap itself instead. r? @Kivooeo (Thanks for reviewing my PRs so far :3)
This comment has been minimized.
This comment has been minimized.
|
📌 Perf builds for each rolled up PR:
previous master: 80b898258d In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 80b8982 (parent) -> 370143f (this PR) Test differencesShow 929 test diffsStage 0
Stage 1
Stage 2
(and 513 additional test diffs) Additionally, 316 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 370143facfb348ad3b29749c0393402d76b280c3 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
Finished benchmarking commit (370143f): comparison URL. Overall result: ❌✅ regressions and improvements - please read the text belowOur benchmarks found a performance regression caused by this PR. Next Steps:
@rustbot label: +perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary -2.1%, secondary 1.7%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary 9.3%, secondary -3.3%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary -0.1%, secondary -0.2%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 475.963s -> 474.117s (-0.39%) |
|
Some perf improvement for @rust-timer build 0a89cd1 |
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (0a89cd1): comparison URL. Overall result: ❌✅ regressions and improvements - please read the text belowInstruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary -0.7%, secondary 1.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary 0.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary -0.1%, secondary -0.2%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 475.963s -> 475.148s (-0.17%) |
Successful merges:
#[derive(Diagnostic)]attribute parsers #151657 (Cleanup of#[derive(Diagnostic)]attribute parsers)r? @ghost
Create a similar rollup