Skip to content

Conversation

@KaiTomotake
Copy link
Contributor

@KaiTomotake KaiTomotake commented Jan 22, 2026

add tests/ui/rfcs/rfc-1861-extern-types/comparison.rs

close #64458

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 22, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 22, 2026

r? @jackh726

rustbot has assigned @jackh726.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@Kivooeo Kivooeo assigned Kivooeo and unassigned jackh726 Jan 22, 2026
add tests/ui/rfcs/rfc-1861-extern-types/comparison.rs
@KaiTomotake KaiTomotake force-pushed the add-foreign-type-tests branch from 089d584 to e86cfa0 Compare January 22, 2026 23:57
@KaiTomotake KaiTomotake requested a review from Kivooeo January 27, 2026 06:14
@KaiTomotake
Copy link
Contributor Author

When will this PR be reviewed?

@Kivooeo
Copy link
Member

Kivooeo commented Jan 29, 2026

today-tomorrow

@Kivooeo
Copy link
Member

Kivooeo commented Jan 29, 2026

@bors r+

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 29, 2026

📌 Commit e86cfa0 has been approved by Kivooeo

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 29, 2026
@Kivooeo
Copy link
Member

Kivooeo commented Jan 29, 2026

@bors rollup

rust-bors bot pushed a commit that referenced this pull request Jan 29, 2026
Rollup of 5 pull requests

Successful merges:

 - #151775 (Portable SIMD subtree update)
 - #151488 (Tweak E0599 to consolidate unsatisfied trait bound messages)
 - #149823 (fix(parser): Disallow CR in frontmatter )
 - #151475 (add foregin type tests for issue 64458)
 - #151657 (Cleanup of `#[derive(Diagnostic)]` attribute parsers)
@rust-bors rust-bors bot merged commit 36a2726 into rust-lang:main Jan 29, 2026
11 checks passed
@rustbot rustbot added this to the 1.95.0 milestone Jan 29, 2026
rust-timer added a commit that referenced this pull request Jan 29, 2026
Rollup merge of #151475 - KaiTomotake:add-foreign-type-tests, r=Kivooeo

add foregin type tests for issue 64458

add tests/ui/rfcs/rfc-1861-extern-types/comparison.rs

close #64458
@KaiTomotake KaiTomotake deleted the add-foreign-type-tests branch January 29, 2026 15:40
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Jan 30, 2026
Rollup of 5 pull requests

Successful merges:

 - rust-lang/rust#151775 (Portable SIMD subtree update)
 - rust-lang/rust#151488 (Tweak E0599 to consolidate unsatisfied trait bound messages)
 - rust-lang/rust#149823 (fix(parser): Disallow CR in frontmatter )
 - rust-lang/rust#151475 (add foregin type tests for issue 64458)
 - rust-lang/rust#151657 (Cleanup of `#[derive(Diagnostic)]` attribute parsers)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Foreign type tests not covering all operations

4 participants