Skip to content

Avoid pulling in unicode when calling io::Error::kind #151418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rust-bors merged 1 commit into from
Jan 21, 2026
Merged

Avoid pulling in unicode when calling io::Error::kind #151418

rust-bors merged 1 commit into from
Jan 21, 2026

Conversation

@lhecker
Copy link
Contributor

@lhecker lhecker commented Jan 20, 2026

Reduces binary size by ~1KB.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 20, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 20, 2026

r? @jhpratt

rustbot has assigned @jhpratt.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@lhecker
Copy link
Contributor Author

lhecker commented Jan 20, 2026

image

@nagisa
Copy link
Member

nagisa commented Jan 20, 2026

I'm not aware of unicode crlf, so this seems equivalent to me.

@bors r+ rollup

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 20, 2026

📌 Commit 711ea73 has been approved by nagisa

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 20, 2026
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jan 20, 2026
Merged
rust-bors bot pushed a commit that referenced this pull request Jan 20, 2026
@bors
Auto merge of #151427 - GuillaumeGomez:rollup-HAeLPDZ, r=GuillaumeGomez
af6695c 
Rollup of 7 pull requests

Successful merges:

 - #151216 ([rustdoc] Make popover menus content scrollable on mobile devices)
 - #151373 (Fix an ICE on transmute goals with placeholders in `param_env`)
 - #151399 (Generate error delegation when delegation is not resolved)
 - #151406 (Use version 1.93.0 in `RELEASES.md` instead of 1.93)
 - #151410 (Fixes for LLVM 22 compatibility)
 - #151415 (chore: Remove redundant conversion)
 - #151418 (Avoid pulling in unicode when calling io::Error::kind)

r? @ghost
@rust-bors rust-bors bot merged commit 3682ed7 into rust-lang:main Jan 21, 2026
11 checks passed
rust-timer added a commit that referenced this pull request Jan 21, 2026
@rust-timer
Unrolled build for #151418
8b9b6f2 
Rollup merge of #151418 - windows-error-kind-size, r=nagisa

Avoid pulling in unicode when calling io::Error::kind

Reduces binary size by ~1KB.
@rustbot rustbot added this to the 1.95.0 milestone Jan 21, 2026
@lhecker lhecker deleted the windows-error-kind-size branch January 21, 2026 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jhpratt jhpratt

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.95.0

Development

Successfully merging this pull request may close these issues.

4 participants

@lhecker @rustbot @nagisa @jhpratt