Skip to content

Suggest ignore returning value inside macro for unused_must_use lint #151283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rust-bors merged 1 commit into from
Jan 29, 2026
Merged

Suggest ignore returning value inside macro for unused_must_use lint #151283

rust-bors merged 1 commit into from
Jan 29, 2026
+50 −5

Conversation

@chenyukang
Copy link
Member

@chenyukang chenyukang commented Jan 18, 2026 •
edited by rustbot
Loading

Fixes #151269

The first commit fix the original issue,
the second commit is a code refactoring in this lint.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 18, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 18, 2026

r? @mati865

rustbot has assigned @mati865.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@mati865
Copy link
Member

mati865 commented Jan 18, 2026

@rustbot reroll

@rustbot rustbot assigned petrochenkov and unassigned mati865 Jan 18, 2026
petrochenkov
petrochenkov reviewed Jan 19, 2026
View reviewed changes
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 19, 2026
@chenyukang
Copy link
Member Author

chenyukang commented Jan 29, 2026

@rustbot ready
Whether this simpler fix looks ok for you?

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 29, 2026
@petrochenkov
Copy link
Contributor

petrochenkov commented Jan 29, 2026

r=me after squashing commits.
@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 29, 2026
@chenyukang chenyukang force-pushed the yukang-fix-macro-unused branch from a3b5752 to 87f75df Compare January 29, 2026 15:13
@petrochenkov
Copy link
Contributor

petrochenkov commented Jan 29, 2026

@bors r+

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 29, 2026

📌 Commit 87f75df has been approved by petrochenkov

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 29, 2026
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jan 29, 2026
Merged
rust-bors bot pushed a commit that referenced this pull request Jan 29, 2026
@bors
Auto merge of #151835 - JonathanBrouwer:rollup-ayQY8NW, r=JonathanBro…
842bd5b 
…uwer

Rollup of 8 pull requests

Successful merges:

 - #147387 (hir_owner_parent optimized to inlined call for non-incremental build)
 - #150271 (Move struct placeholder pt2)
 - #151283 (Suggest ignore returning value inside macro for unused_must_use lint)
 - #151565 (Rename, clarify, and document code for "erasing" query values)
 - #149482 (thread::scope: document how join interacts with TLS destructors)
 - #151827 (Use `Rustc` prefix for `rustc` attrs in `AttributeKind`)
 - #151833 (Treat unions as 'data types' in attr parsing diagnostics)
 - #151834 (Update `askama` version to `0.15.4`)
@rust-bors rust-bors bot merged commit adcdb6c into rust-lang:main Jan 29, 2026
11 checks passed
@rustbot rustbot added this to the 1.95.0 milestone Jan 29, 2026
rust-timer added a commit that referenced this pull request Jan 29, 2026
@rust-timer
Unrolled build for #151283
c9dfd9e 
Rollup merge of #151283 - chenyukang:yukang-fix-macro-unused, r=petrochenkov

Suggest ignore returning value inside macro for unused_must_use lint

Fixes #151269

The first commit fix the original issue,
the second commit is a code refactoring in this lint.
@github-actions github-actions bot mentioned this pull request Jan 30, 2026
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petrochenkov petrochenkov petrochenkov left review comments

Assignees

@petrochenkov petrochenkov

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.95.0

Development

Successfully merging this pull request may close these issues.

unused_must_use inside macro suggests let _ = on the macro invocation

4 participants

@chenyukang @rustbot @mati865 @petrochenkov