Move struct placeholder pt2 #150271

Jamesbarford · 2025-12-22T15:02:51Z

r? ghost

compiler/rustc_borrowck/src/diagnostics/bound_region_errors.rs

compiler/rustc_infer/src/infer/region_constraints/mod.rs

compiler/rustc_infer/src/infer/outlives/obligations.rs

compiler/rustc_middle/src/ty/region.rs

compiler/rustc_next_trait_solver/src/placeholder.rs

compiler/rustc_type_ir/src/binder.rs

compiler/rustc_type_ir/src/interner.rs

lcnr · 2026-01-05T15:26:13Z

The reason HashStable isn't implemented is kinda stupid.

HashStable_NoContext is a "perfect derive", i.e. we simply add where-clauses that each field implements the trait. This means the derive for BoundRegionKind adds I::DefId: HasHStable<CTX> and I::Symbol: HashStable<CTX>. These are then considered to not hold in the manual impl. Though tbf, I don't get why the manual impl exists at all.

Try to replace the manual impl with a derive and see if anything breaks. If it does break, add I::DefId: HashStable<CTX> and I::Symbol: HashStable<CTX> to the manual impl

compiler/rustc_public/src/mir/body.rs

compiler/rustc_public/src/ty.rs

compiler/rustc_hir_analysis/src/collect/resolve_bound_vars.rs

compiler/rustc_type_ir/src/binder.rs

lcnr · 2026-01-24T21:51:56Z

please cleanup the changes + commit history and make this ready for review 😊 thank you for working on this

rustbot · 2026-01-26T08:27:41Z

HIR ty lowering was modified

cc @fmease

changes to the core type system

cc @lcnr

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

This PR changes rustc_public

cc @oli-obk, @celinval, @ouz-a, @makai410

compiler/rustc_type_ir/src/binder.rs

lcnr · 2026-01-26T09:06:49Z

compiler/rustc_type_ir/src/binder.rs

+    fn lift_to_interner(self, cx: U) -> Option<Self::Lifted> {
+        Some(BoundTy { var: self.var, kind: self.kind.lift_to_interner(cx)? })
+    }
+}


why can this one not be derived?

I get this error without the implementation;

error[E0277]: the trait bound `BoundTy<TyCtxt<'_>>: Lift<TyCtxt<'tcx>>` is not satisfied --> compiler/rustc_infer/src/infer/region_constraints/mod.rs:672:59 | 672 | GenericKind::Placeholder(ref p) => write!(f, "{p}"), | -----------^^^-- | | | | | unsatisfied trait bound | in this macro invocation (#1) | --> /rustc/9b1f8ff42d110b0ca138116745be921df5dc97e7/library/core/src/macros/mod.rs:610:0 | = note: in this expansion of `write!` (#1) ::: /rustc/9b1f8ff42d110b0ca138116745be921df5dc97e7/library/core/src/macros/mod.rs:612:23 | = note: in this macro invocation (#2) ::: /rustc/9b1f8ff42d110b0ca138116745be921df5dc97e7/library/core/src/macros/mod.rs:997:4 | = note: in this expansion of `$crate::format_args!` (#2) | = help: the nightly-only, unstable trait `for<'tcx> Lift<rustc_middle::ty::TyCtxt<'tcx>>` is not implemented for `BoundTy<rustc_middle::ty::TyCtxt<'_>>` = help: the following other types implement trait `Lift<I>`: `&RawList<(), BoundVariableKind<TyCtxt<'a>>>` implements `Lift<rustc_middle::ty::TyCtxt<'tcx>>` `&RawList<(), GenericArg<'a>>` implements `Lift<rustc_middle::ty::TyCtxt<'tcx>>` `&RawList<(), Ty<'a>>` implements `Lift<rustc_middle::ty::TyCtxt<'tcx>>` `&RawList<(), Binder<TyCtxt<'a>, ...>>` implements `Lift<rustc_middle::ty::TyCtxt<'tcx>>` `()` implements `Lift<rustc_middle::ty::TyCtxt<'tcx>>` `AliasTerm<I>` implements `Lift<J>` `AliasTy<I>` implements `Lift<J>` `AllocId` implements `Lift<rustc_middle::ty::TyCtxt<'tcx>>` and 68 others = note: required for `Placeholder<TyCtxt<'_>, BoundTy<TyCtxt<'_>>>` to implement `for<'tcx> Lift<rustc_middle::ty::TyCtxt<'tcx>>` = note: required for `rustc_middle::ty::TyCtxt<'_>` to implement `IrPrint<Placeholder<TyCtxt<'_>, BoundTy<...>>>` = note: required for `Placeholder<TyCtxt<'_>, BoundTy<TyCtxt<'_>>>` to implement `std::fmt::Display` = note: 1 redundant requirement hidden = note: required for `&Placeholder<TyCtxt<'_>, BoundTy<TyCtxt<'_>>>` to implement `std::fmt::Display` = note: the full name for the type has been written to '/home/jambar02/Documents/arm/rust/build/x86_64-unknown-linux-gnu/stage1-rustc/x86_64-unknown-linux-gnu/release/deps/rustc_infer-29c3d638b97358db.long-type-10995706924995725161.txt' = note: consider using `--verbose` to print the full type name to the console

without the manual implementation but with a derive?

as in, using Lift_Generic

I get the same error when doing;

#[derive_where(Clone, Copy, PartialEq, Eq, Hash; I: Interner)] #[derive(Lift_Generic)] #[cfg_attr( feature = "nightly", derive(Encodable_NoContext, Decodable_NoContext, HashStable_NoContext) )] pub struct BoundTy<I: Interner> { pub var: ty::BoundVar, pub kind: BoundTyKind<I>, }

that might be as BoundVar doesn't implement Lift.

Does only deriving it for BoundRegionKind also error? The same with its HashStable impl

Doing it for BoundRegionKind allowed me to then also do it for BoundVariableKind and BoundTyKind.

lcnr · 2026-01-26T09:07:50Z

compiler/rustc_type_ir/src/interner.rs

-    type BoundTy: BoundVarLike<Self>;
-    type PlaceholderTy: PlaceholderLike<Self, Bound = Self::BoundTy>;
-    type Symbol: Copy + Hash + PartialEq + Eq + Debug;
+    type Symbol: Copy + Hash + PartialEq + Eq + Debug + Symbol<Self>;


please move all these item bounds to be super traits of Symbol instead

not actually resolved 😅

I didn't push my changes 🤦

lcnr

nits, then r=me

also, for future PRs. It would have been good to keep the BoundRegionKind::NamedForPrinting rename in a separate commit as that one isn't strictly related to the other changes

View changes since this review

compiler/rustc_type_ir/src/binder.rs

lcnr

r=me after nit

View changes since this review

compiler/rustc_type_ir/src/binder.rs

lcnr · 2026-01-29T10:24:21Z

@bors delegate+

rust-bors · 2026-01-29T10:24:24Z

✌️ @Jamesbarford, you can now approve this pull request!

If @lcnr told you to "r=me" after making some further change, then please make that change and post @bors r=lcnr.

Jamesbarford · 2026-01-29T13:21:51Z

@bors r=lcnr

rust-bors · 2026-01-29T13:21:54Z

📌 Commit 25c1365 has been approved by lcnr

It is now in the queue for this repository.

…uwer Rollup of 8 pull requests Successful merges: - #147387 (hir_owner_parent optimized to inlined call for non-incremental build) - #150271 (Move struct placeholder pt2) - #151283 (Suggest ignore returning value inside macro for unused_must_use lint) - #151565 (Rename, clarify, and document code for "erasing" query values) - #149482 (thread::scope: document how join interacts with TLS destructors) - #151827 (Use `Rustc` prefix for `rustc` attrs in `AttributeKind`) - #151833 (Treat unions as 'data types' in attr parsing diagnostics) - #151834 (Update `askama` version to `0.15.4`)

Rollup merge of #150271 - Jamesbarford:chore/refactor-struct-placeholder-pt2, r=lcnr Move struct placeholder pt2 r? ghost

This comment has been minimized.

Sign in to view

lcnr reviewed Dec 22, 2025

View reviewed changes

compiler/rustc_borrowck/src/diagnostics/bound_region_errors.rs Outdated Show resolved Hide resolved

Jamesbarford force-pushed the chore/refactor-struct-placeholder-pt2 branch from 753b92c to 2077c6b Compare December 30, 2025 08:41

This comment has been minimized.

Sign in to view

lcnr reviewed Dec 30, 2025

View reviewed changes

compiler/rustc_infer/src/infer/region_constraints/mod.rs Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

lcnr reviewed Jan 5, 2026

View reviewed changes

compiler/rustc_infer/src/infer/outlives/obligations.rs Outdated Show resolved Hide resolved

lcnr reviewed Jan 5, 2026

View reviewed changes

compiler/rustc_middle/src/ty/region.rs Outdated Show resolved Hide resolved

lcnr reviewed Jan 5, 2026

View reviewed changes

compiler/rustc_next_trait_solver/src/placeholder.rs Outdated Show resolved Hide resolved

lcnr reviewed Jan 5, 2026

View reviewed changes

compiler/rustc_type_ir/src/binder.rs Outdated Show resolved Hide resolved

lcnr reviewed Jan 5, 2026

View reviewed changes

compiler/rustc_type_ir/src/binder.rs Outdated Show resolved Hide resolved

lcnr reviewed Jan 5, 2026

View reviewed changes

compiler/rustc_type_ir/src/interner.rs Outdated Show resolved Hide resolved

Jamesbarford force-pushed the chore/refactor-struct-placeholder-pt2 branch from d262f5c to d36238d Compare January 13, 2026 11:42

This comment has been minimized.

Sign in to view

Jamesbarford force-pushed the chore/refactor-struct-placeholder-pt2 branch from d36238d to a03a907 Compare January 13, 2026 13:29

This comment has been minimized.

Sign in to view

Jamesbarford force-pushed the chore/refactor-struct-placeholder-pt2 branch from a03a907 to b4de573 Compare January 15, 2026 14:43

This comment has been minimized.

Sign in to view

lcnr reviewed Jan 15, 2026

View reviewed changes

compiler/rustc_public/src/mir/body.rs Outdated Show resolved Hide resolved

lcnr reviewed Jan 15, 2026

View reviewed changes

compiler/rustc_public/src/ty.rs Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

Jamesbarford force-pushed the chore/refactor-struct-placeholder-pt2 branch from 044bbd5 to cdff0b9 Compare January 19, 2026 12:01

This comment has been minimized.

Sign in to view

lcnr reviewed Jan 19, 2026

View reviewed changes

compiler/rustc_hir_analysis/src/collect/resolve_bound_vars.rs Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

lcnr reviewed Jan 23, 2026

View reviewed changes

compiler/rustc_type_ir/src/binder.rs Outdated Show resolved Hide resolved

Jamesbarford force-pushed the chore/refactor-struct-placeholder-pt2 branch from 4813077 to beb1a6e Compare January 26, 2026 08:24

Jamesbarford marked this pull request as ready for review January 26, 2026 08:27

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 26, 2026

lcnr reviewed Jan 26, 2026

View reviewed changes

compiler/rustc_type_ir/src/binder.rs Outdated Show resolved Hide resolved

lcnr reviewed Jan 26, 2026

View reviewed changes

Jamesbarford force-pushed the chore/refactor-struct-placeholder-pt2 branch 2 times, most recently from 8387fa4 to 267fa27 Compare January 27, 2026 12:09

lcnr reviewed Jan 27, 2026

View reviewed changes

compiler/rustc_type_ir/src/binder.rs Outdated Show resolved Hide resolved

compiler/rustc_type_ir/src/binder.rs Outdated Show resolved Hide resolved

Jamesbarford force-pushed the chore/refactor-struct-placeholder-pt2 branch from 267fa27 to 9f0791e Compare January 29, 2026 08:34

lcnr reviewed Jan 29, 2026

View reviewed changes

compiler/rustc_type_ir/src/binder.rs Outdated Show resolved Hide resolved

Part 2 refactoring of moving placeholder types to rustc_type_ir

25c1365

Jamesbarford force-pushed the chore/refactor-struct-placeholder-pt2 branch from 9f0791e to 25c1365 Compare January 29, 2026 11:12

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 29, 2026

JonathanBrouwer mentioned this pull request Jan 29, 2026

Rollup of 8 pull requests #151835

Merged

rust-bors bot merged commit 40d7cb8 into rust-lang:main Jan 29, 2026
11 checks passed

rustbot added this to the 1.95.0 milestone Jan 29, 2026

rust-timer added a commit that referenced this pull request Jan 29, 2026

Unrolled build for #150271

ec981e3

Rollup merge of #150271 - Jamesbarford:chore/refactor-struct-placeholder-pt2, r=lcnr Move struct placeholder pt2 r? ghost

Uh oh!

Move struct placeholder pt2 #150271

Move struct placeholder pt2 #150271

Conversation

Jamesbarford commented Dec 22, 2025

Uh oh!

This comment has been minimized.

Uh oh!

This comment has been minimized.

This comment has been minimized.

Uh oh!

This comment has been minimized.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lcnr commented Jan 5, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

Uh oh!

This comment has been minimized.

This comment has been minimized.

Uh oh!

lcnr commented Jan 24, 2026

Uh oh!

rustbot commented Jan 26, 2026

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lcnr Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lcnr left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

lcnr left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

lcnr commented Jan 29, 2026

Uh oh!

rust-bors bot commented Jan 29, 2026

Uh oh!

Jamesbarford commented Jan 29, 2026

Uh oh!

rust-bors bot commented Jan 29, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

lcnr Jan 27, 2026 •

edited

Loading

lcnr left a comment •

edited by rustbot

Loading

lcnr left a comment •

edited by rustbot

Loading