Skip to content

Conversation

@Kobzol
Copy link
Member

@Kobzol Kobzol commented Dec 31, 2025

Companion to #150538.

try-job: dist-x86_64-linux

@rustbot rustbot added A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Dec 31, 2025
@Kobzol
Copy link
Member Author

Kobzol commented Dec 31, 2025

@bors try

@rust-bors

This comment has been minimized.

rust-bors bot added a commit that referenced this pull request Dec 31, 2025
Add a dist component for libgccjit
@rust-bors
Copy link
Contributor

rust-bors bot commented Dec 31, 2025

☀️ Try build successful (CI)
Build commit: 3a627bb (3a627bb68515998e10c45df091f28af8503726c3, parent: 629b092f8fab1b0370dfb749c4f5e00e70169dd2)

@bors
Copy link
Collaborator

bors commented Jan 5, 2026

☔ The latest upstream changes (presumably #150535) made this pull request unmergeable. Please resolve the merge conflicts.

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 5, 2026

☔ The latest upstream changes made this pull request unmergeable. Please resolve the merge conflicts.

@Kobzol Kobzol force-pushed the dist-gcc-component branch from f7682ee to 2b72774 Compare January 8, 2026 16:10
@Kobzol
Copy link
Member Author

Kobzol commented Jan 8, 2026

@bors try

rust-bors bot added a commit that referenced this pull request Jan 8, 2026
Add a dist component for libgccjit

try-job: dist-x86_64-linux
@rust-bors

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 8, 2026

☀️ Try build successful (CI)
Build commit: 2a127d5 (2a127d591cf45d2e3322e3227773c69c9b38f978, parent: 32fe406b5e71afbb0d8b95280e50e67d1549224c)

@Kobzol Kobzol force-pushed the dist-gcc-component branch from 2b72774 to b0aa77a Compare January 9, 2026 15:51
@Kobzol
Copy link
Member Author

Kobzol commented Jan 9, 2026

Downloaded the gcc and rustc_codegen_gcc backend manually from CI and tested that it works on hello world 🎉

@Kobzol Kobzol marked this pull request as ready for review January 9, 2026 16:17
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 9, 2026
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jan 9, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 9, 2026

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jieyouxu
Copy link
Member

@bors r+ rollup=never

@rust-bors rust-bors bot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 10, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 10, 2026

📌 Commit b0aa77a has been approved by jieyouxu

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 14, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 14, 2026

💔 Test for 2f9be61 failed: CI. Failed jobs:

@Kobzol
Copy link
Member Author

Kobzol commented Jan 14, 2026

Some really weird GitHub job results above ^. Let's retry.

@bors retry

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 14, 2026
@jieyouxu
Copy link
Member

This PR is slowly becoming cursed 😱

@rust-bors

This comment has been minimized.

rust-bors bot pushed a commit that referenced this pull request Jan 14, 2026
Add a dist component for libgccjit

Companion to #150538.

try-job: dist-x86_64-linux
@rust-bors rust-bors bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 14, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 14, 2026

💔 Test for 0d6934b failed: CI. Failed jobs:

@jieyouxu
Copy link
Member

The hosted runner lost communication with the server.

💀

@bors retry

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 14, 2026
@jieyouxu
Copy link
Member

This PR needs a bit of:

ferris-exorcism

@rust-bors

This comment has been minimized.

@rust-bors rust-bors bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 14, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 14, 2026

☀️ Test successful - CI
Approved by: jieyouxu
Pushing 2fd6efc to main...

@rust-bors rust-bors bot merged commit 2fd6efc into rust-lang:main Jan 14, 2026
12 checks passed
@rustbot rustbot added this to the 1.94.0 milestone Jan 14, 2026
@github-actions
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 4931e09 (parent) -> 2fd6efc (this PR)

Test differences

Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 2fd6efc32704647e64d3d646d21c4c68eae100e4 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. aarch64-apple: 10378.8s -> 7621.4s (-26.6%)
  2. pr-check-1: 2058.5s -> 1709.5s (-17.0%)
  3. dist-aarch64-apple: 8780.3s -> 7341.7s (-16.4%)
  4. x86_64-rust-for-linux: 3178.0s -> 2668.8s (-16.0%)
  5. aarch64-gnu-llvm-20-2: 3351.3s -> 2827.8s (-15.6%)
  6. test-various: 7747.7s -> 6740.3s (-13.0%)
  7. dist-apple-various: 4201.3s -> 4731.5s (+12.6%)
  8. x86_64-gnu-tools: 3733.4s -> 3272.8s (-12.3%)
  9. x86_64-gnu-aux: 7543.6s -> 6711.6s (-11.0%)
  10. x86_64-gnu-gcc: 3387.3s -> 3019.1s (-10.9%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (2fd6efc): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -1.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-1.6% [-2.4%, -0.7%] 2
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -1.6% [-2.4%, -0.7%] 2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 474.176s -> 474.74s (0.12%)
Artifact size: 383.16 MiB -> 383.12 MiB (-0.01%)

@GuillaumeGomez
Copy link
Member

Do you know when this will be available with rustup by any chance? :3

@Kobzol
Copy link
Member Author

Kobzol commented Jan 14, 2026

Once we add it there 😆 One more PR is needed, to add libgccjit and cg_gcc to the "build manifest". I'll send it once I can find a bit of time.

@Kobzol Kobzol deleted the dist-gcc-component branch January 14, 2026 15:10
@GuillaumeGomez
Copy link
Member

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants