-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
Add a dist component for libgccjit #150541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@bors try |
This comment has been minimized.
This comment has been minimized.
Add a dist component for libgccjit
|
☔ The latest upstream changes (presumably #150535) made this pull request unmergeable. Please resolve the merge conflicts. |
|
☔ The latest upstream changes made this pull request unmergeable. Please resolve the merge conflicts. |
f7682ee to
2b72774
Compare
|
@bors try |
Add a dist component for libgccjit try-job: dist-x86_64-linux
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
2b72774 to
b0aa77a
Compare
|
Downloaded the gcc and rustc_codegen_gcc backend manually from CI and tested that it works on hello world 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
@bors r+ rollup=never |
|
💔 Test for 2f9be61 failed: CI. Failed jobs:
|
|
Some really weird GitHub job results above ^. Let's retry. @bors retry |
|
This PR is slowly becoming cursed 😱 |
This comment has been minimized.
This comment has been minimized.
Add a dist component for libgccjit Companion to #150538. try-job: dist-x86_64-linux
|
💔 Test for 0d6934b failed: CI. Failed jobs:
|
💀 @bors retry |
This comment has been minimized.
This comment has been minimized.
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 4931e09 (parent) -> 2fd6efc (this PR) Test differencesShow 2 test diffs2 doctest diffs were found. These are ignored, as they are noisy. Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 2fd6efc32704647e64d3d646d21c4c68eae100e4 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
Finished benchmarking commit (2fd6efc): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary -1.6%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 474.176s -> 474.74s (0.12%) |
|
Do you know when this will be available with rustup by any chance? :3 |
|
Once we add it there 😆 One more PR is needed, to add libgccjit and cg_gcc to the "build manifest". I'll send it once I can find a bit of time. |
|
Thanks a lot! |

Companion to #150538.
try-job: dist-x86_64-linux