-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
Add a dist component for cg_gcc #150538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a dist component for cg_gcc #150538
Conversation
|
@bors try |
Add a dist component for cg_gcc try-job: dist-x86_64-linux
This comment has been minimized.
This comment has been minimized.
|
You seem to be making changes to the dylibs stuff, so don't hesitate to ask me to test that this still works for cross-compiling rustc if you need me to. |
This comment has been minimized.
This comment has been minimized.
|
💔 Test for 07629c3 failed: CI. Failed jobs:
|
|
I don't think my changes should affect the multi-target libgccjit dylib building, but if you can try, that would be helpful, of course :) @bors try |
Add a dist component for cg_gcc try-job: dist-x86_64-linux
This comment has been minimized.
This comment has been minimized.
Ok. Please tell me when this is ready and I'll do the test locally. |
|
It is ready now, just waiting for #150535 to be reviewed and merged. |
I made my test and everything still seems to work. |
|
☔ The latest upstream changes (presumably #150535) made this pull request unmergeable. Please resolve the merge conflicts. |
|
☔ The latest upstream changes made this pull request unmergeable. Please resolve the merge conflicts. |
39c1817 to
04707f4
Compare
|
Some changes occurred in src/tools/opt-dist cc @Kobzol |
|
r? @clubby789 rustbot has assigned @clubby789. Use |
|
r? @jieyouxu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, one nit
|
@rustbot author |
|
@bors r+ rollup=never |
This comment has been minimized.
This comment has been minimized.
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing bca37a2 (parent) -> 32fe406 (this PR) Test differencesNo test diffs found Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 32fe406b5e71afbb0d8b95280e50e67d1549224c --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
Finished benchmarking commit (32fe406): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary -1.0%, secondary 3.6%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 475.924s -> 474.424s (-0.32%) |
Add a dist component for libgccjit Companion to #150538. try-job: dist-x86_64-linux
Add a dist component for libgccjit Companion to #150538. try-job: dist-x86_64-linux
Add a dist component for libgccjit Companion to #150538. try-job: dist-x86_64-linux
Add a dist component for libgccjit Companion to #150538. try-job: dist-x86_64-linux
Add a dist component for libgccjit Companion to #150538. try-job: dist-x86_64-linux
Add a dist component for libgccjit Companion to rust-lang/rust#150538. try-job: dist-x86_64-linux
Add a dist component for libgccjit Companion to rust-lang/rust#150538. try-job: dist-x86_64-linux
Add a dist component for libgccjit Companion to rust-lang/rust#150538. try-job: dist-x86_64-linux
try-job: dist-x86_64-linux