Skip to content

Conversation

@Kobzol
Copy link
Member

@Kobzol Kobzol commented Dec 31, 2025

try-job: dist-x86_64-linux

@rustbot rustbot added A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Dec 31, 2025
@Kobzol
Copy link
Member Author

Kobzol commented Dec 31, 2025

@bors try

rust-bors bot added a commit that referenced this pull request Dec 31, 2025
Add a dist component for cg_gcc

try-job: dist-x86_64-linux
@rust-bors

This comment has been minimized.

@antoyo
Copy link
Contributor

antoyo commented Dec 31, 2025

You seem to be making changes to the dylibs stuff, so don't hesitate to ask me to test that this still works for cross-compiling rustc if you need me to.

@rust-log-analyzer

This comment has been minimized.

@rust-bors
Copy link
Contributor

rust-bors bot commented Dec 31, 2025

💔 Test for 07629c3 failed: CI. Failed jobs:

@Kobzol
Copy link
Member Author

Kobzol commented Jan 2, 2026

I don't think my changes should affect the multi-target libgccjit dylib building, but if you can try, that would be helpful, of course :)

@bors try

rust-bors bot added a commit that referenced this pull request Jan 2, 2026
Add a dist component for cg_gcc

try-job: dist-x86_64-linux
@rust-bors

This comment has been minimized.

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 2, 2026

☀️ Try build successful (CI)
Build commit: 09e4f11 (09e4f11d243b60bb64549da0285de0c149f80c9c, parent: 1b4325211c3228dd10eea12e9b3f749f87363d95)

@antoyo
Copy link
Contributor

antoyo commented Jan 2, 2026

I don't think my changes should affect the multi-target libgccjit dylib building, but if you can try, that would be helpful, of course :)

Ok. Please tell me when this is ready and I'll do the test locally.

@Kobzol
Copy link
Member Author

Kobzol commented Jan 2, 2026

It is ready now, just waiting for #150535 to be reviewed and merged.

@antoyo
Copy link
Contributor

antoyo commented Jan 2, 2026

It is ready now, just waiting for #150535 to be reviewed and merged.

I made my test and everything still seems to work.

@bors
Copy link
Collaborator

bors commented Jan 5, 2026

☔ The latest upstream changes (presumably #150535) made this pull request unmergeable. Please resolve the merge conflicts.

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 5, 2026

☔ The latest upstream changes made this pull request unmergeable. Please resolve the merge conflicts.

@Kobzol Kobzol force-pushed the dist-cg-gcc-component branch from 39c1817 to 04707f4 Compare January 5, 2026 09:53
@Kobzol Kobzol marked this pull request as ready for review January 5, 2026 09:53
@rustbot
Copy link
Collaborator

rustbot commented Jan 5, 2026

Some changes occurred in src/tools/opt-dist

cc @Kobzol

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 5, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 5, 2026

r? @clubby789

rustbot has assigned @clubby789.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@Kobzol
Copy link
Member Author

Kobzol commented Jan 5, 2026

r? @jieyouxu

@rustbot rustbot assigned jieyouxu and unassigned clubby789 Jan 5, 2026
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jieyouxu
Copy link
Member

jieyouxu commented Jan 8, 2026

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 8, 2026
@jieyouxu
Copy link
Member

jieyouxu commented Jan 8, 2026

@bors r+ rollup=never

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 8, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 8, 2026

📌 Commit 04707f4 has been approved by jieyouxu

It is now in the queue for this repository.

@rust-bors

This comment has been minimized.

@rust-bors rust-bors bot added the merged-by-bors This PR was explicitly merged by bors. label Jan 8, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 8, 2026

☀️ Test successful - CI
Approved by: jieyouxu
Pushing 32fe406 to main...

@rust-bors rust-bors bot merged commit 32fe406 into rust-lang:main Jan 8, 2026
12 checks passed
@rustbot rustbot added this to the 1.94.0 milestone Jan 8, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2026

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing bca37a2 (parent) -> 32fe406 (this PR)

Test differences

No test diffs found

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 32fe406b5e71afbb0d8b95280e50e67d1549224c --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-x86_64-apple: 7484.6s -> 9111.1s (+21.7%)
  2. aarch64-apple: 9577.3s -> 11441.2s (+19.5%)
  3. dist-aarch64-apple: 7314.4s -> 6024.5s (-17.6%)
  4. dist-aarch64-msvc: 6344.1s -> 5425.6s (-14.5%)
  5. i686-gnu-1: 8773.0s -> 7647.4s (-12.8%)
  6. x86_64-gnu-tools: 3733.7s -> 3271.9s (-12.4%)
  7. i686-gnu-2: 6110.2s -> 5367.3s (-12.2%)
  8. x86_64-gnu-stable: 8729.2s -> 7678.5s (-12.0%)
  9. aarch64-gnu-llvm-20-2: 3047.0s -> 2697.1s (-11.5%)
  10. x86_64-gnu-gcc: 3823.6s -> 3400.8s (-11.1%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@Kobzol Kobzol deleted the dist-cg-gcc-component branch January 8, 2026 14:09
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (32fe406): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.6% [0.5%, 0.6%] 3
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary -1.0%, secondary 3.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
2.3% [2.3%, 2.3%] 1
Regressions ❌
(secondary)
3.6% [3.6%, 3.6%] 1
Improvements ✅
(primary)
-2.7% [-2.8%, -2.5%] 2
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -1.0% [-2.8%, 2.3%] 3

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 475.924s -> 474.424s (-0.32%)
Artifact size: 390.87 MiB -> 390.80 MiB (-0.02%)

rust-bors bot added a commit that referenced this pull request Jan 10, 2026
Add a dist component for libgccjit

Companion to #150538.

try-job: dist-x86_64-linux
rust-bors bot pushed a commit that referenced this pull request Jan 13, 2026
Add a dist component for libgccjit

Companion to #150538.

try-job: dist-x86_64-linux
rust-bors bot pushed a commit that referenced this pull request Jan 14, 2026
Add a dist component for libgccjit

Companion to #150538.

try-job: dist-x86_64-linux
rust-bors bot pushed a commit that referenced this pull request Jan 14, 2026
Add a dist component for libgccjit

Companion to #150538.

try-job: dist-x86_64-linux
rust-bors bot pushed a commit that referenced this pull request Jan 14, 2026
Add a dist component for libgccjit

Companion to #150538.

try-job: dist-x86_64-linux
github-actions bot pushed a commit to rust-lang/rust-analyzer that referenced this pull request Jan 15, 2026
Add a dist component for libgccjit

Companion to rust-lang/rust#150538.

try-job: dist-x86_64-linux
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Jan 15, 2026
Add a dist component for libgccjit

Companion to rust-lang/rust#150538.

try-job: dist-x86_64-linux
github-actions bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Jan 20, 2026
Add a dist component for libgccjit

Companion to rust-lang/rust#150538.

try-job: dist-x86_64-linux
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants