Skip to content

Conversation

@Zalathar
Copy link
Contributor

@Zalathar Zalathar commented Oct 27, 2025

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

Jamesbarford and others added 9 commits October 25, 2025 22:46
…able, r=oli-obk

const `select_unpredictable`

Tracking issue: rust-lang#145938
…lds-constructor, r=davidtwco

More intuitive error when using self to instantiate tuple struct with private field

Fixes rust-lang#147343
…n, r=lcnr

Add built-in `const` impls for `Clone` and `Copy`

cc `@compiler-errors`
…nathanBrouwer

Fix duplicate 'the the' typos in comments

Fix duplicate 'the the' typos in comments
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) rollup A PR which is a rollup labels Oct 27, 2025
@Zalathar
Copy link
Contributor Author

Rollup of everything.

@bors r+ rollup=never p=5

@bors
Copy link
Collaborator

bors commented Oct 27, 2025

📌 Commit 791165c has been approved by Zalathar

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 27, 2025
@bors
Copy link
Collaborator

bors commented Oct 27, 2025

⌛ Testing commit 791165c with merge 9ea8d67...

@bors
Copy link
Collaborator

bors commented Oct 27, 2025

☀️ Test successful - checks-actions
Approved by: Zalathar
Pushing 9ea8d67 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 27, 2025
@bors bors merged commit 9ea8d67 into rust-lang:master Oct 27, 2025
12 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Oct 27, 2025
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#145939 const select_unpredictable 1940cfd70ac51a1f0b54ce09835ebd6ec2f97896 (link)
#147478 More intuitive error when using self to instantiate tuple s… dd31609a61c0a3b604d92eb7994082a73c4d438e (link)
#147866 Add built-in const impls for Clone and Copy ffdb097404b100b80d8fc8ead681e44ee8058ef6 (link)
#148153 Fix duplicate 'the the' typos in comments fc133bf9ffed99526e9a8b37f09683edc2b48c92 (link)

previous master: 4b53279854

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 4b53279 (parent) -> 9ea8d67 (this PR)

Test differences

Show 165 test diffs

Stage 1

  • [ui] tests/ui/resolve/private-constructor-self-issue-147343.rs: [missing] -> pass (J1)

Stage 2

  • [ui] tests/ui/resolve/private-constructor-self-issue-147343.rs: [missing] -> pass (J0)

Additionally, 163 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 9ea8d67cc60e88ad6fffbf299a454c44227e001c --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. pr-check-1: 1438.6s -> 1852.4s (28.8%)
  2. aarch64-gnu-llvm-20-1: 3288.0s -> 3683.3s (12.0%)
  3. dist-various-1: 4179.7s -> 3730.3s (-10.8%)
  4. test-various: 6279.4s -> 6938.5s (10.5%)
  5. dist-aarch64-msvc: 5341.7s -> 5866.1s (9.8%)
  6. aarch64-apple: 10864.5s -> 9808.2s (-9.7%)
  7. x86_64-rust-for-linux: 2795.3s -> 2532.5s (-9.4%)
  8. i686-gnu-nopt-1: 7863.3s -> 8544.3s (8.7%)
  9. dist-apple-various: 3793.1s -> 4102.4s (8.2%)
  10. aarch64-msvc-2: 5241.4s -> 4816.2s (-8.1%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (9ea8d67): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary -3.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-3.2% [-3.9%, -2.5%] 2
All ❌✅ (primary) - - 0

Cycles

Results (primary 2.5%, secondary 8.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
2.5% [2.1%, 2.7%] 3
Regressions ❌
(secondary)
8.0% [6.3%, 9.6%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 2.5% [2.1%, 2.7%] 3

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 474.938s -> 474.628s (-0.07%)
Artifact size: 390.59 MiB -> 390.61 MiB (0.01%)

@Zalathar Zalathar deleted the rollup-njf167h branch October 27, 2025 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants