Skip to content

More intuitive error when using self to instantiate tuple struct with private field #147478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 27, 2025
Merged

More intuitive error when using self to instantiate tuple struct with private field #147478

merged 1 commit into from
Oct 27, 2025
+84 −44

Conversation

@Jamesbarford
Copy link
Contributor

@Jamesbarford Jamesbarford commented Oct 8, 2025 •
edited
Loading

Fixes #147343

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 8, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 8, 2025

r? @SparrowLii

rustbot has assigned @SparrowLii.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@fmease

This comment has been minimized.

Sign in to view
@Jamesbarford
Copy link
Contributor Author

r? compiler

@rustbot rustbot assigned davidtwco and unassigned SparrowLii Oct 23, 2025
davidtwco
davidtwco approved these changes Oct 25, 2025
View reviewed changes
Copy link
Member

@davidtwco davidtwco left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one nit, r=me afterwards

View changes since this review

@Jamesbarford Jamesbarford force-pushed the fix/tuple-private-fields-constructor branch from 55bc341 to 7af72e7 Compare October 25, 2025 21:46
@Jamesbarford
Copy link
Contributor Author

Jamesbarford commented Oct 26, 2025 •
edited
Loading

r=@davidtwco

@bors
Copy link
Collaborator

bors commented Oct 26, 2025

@Jamesbarford: 🔑 Insufficient privileges: Not in reviewers

@davidtwco
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Oct 27, 2025

📌 Commit 7af72e7 has been approved by davidtwco

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 27, 2025
@Zalathar Zalathar mentioned this pull request Oct 27, 2025
Merged
bors added a commit that referenced this pull request Oct 27, 2025
@bors
Auto merge of #148167 - Zalathar:rollup-njf167h, r=Zalathar
9ea8d67 
Rollup of 4 pull requests

Successful merges:

 - #145939 (const `select_unpredictable`)
 - #147478 (More intuitive error when using self to instantiate tuple struct with private field)
 - #147866 (Add built-in `const` impls for `Clone` and `Copy`)
 - #148153 (Fix duplicate 'the the' typos in comments)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 0bd2437 into rust-lang:master Oct 27, 2025
11 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Oct 27, 2025
rust-timer added a commit that referenced this pull request Oct 27, 2025
@rust-timer
Unrolled build for #147478
dd31609 
Rollup merge of #147478 - Jamesbarford:fix/tuple-private-fields-constructor, r=davidtwco

More intuitive error when using self to instantiate tuple struct with private field

Fixes #147343
@Jamesbarford Jamesbarford deleted the fix/tuple-private-fields-constructor branch October 28, 2025 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidtwco davidtwco davidtwco approved these changes

Assignees

@davidtwco davidtwco

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.93.0

Development

Successfully merging this pull request may close these issues.

Confusing error when using self to instantiate tuple struct with private field

6 participants

@Jamesbarford @rustbot @fmease @bors @davidtwco @SparrowLii