Skip to content

rustdoc search: relax rules for identifiers #147860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2025
Merged

rustdoc search: relax rules for identifiers #147860

merged 1 commit into from
Oct 21, 2025
+24 −2

Conversation

@lolbinarycat
Copy link
Contributor

fixes #147763

@rustbot
Copy link
Collaborator

rustbot commented Oct 18, 2025

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @jsha, @lolbinarycat

@rustbot rustbot added A-rustdoc-search Area: Rustdoc's search feature S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Oct 18, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 18, 2025

r? @notriddle

rustbot has assigned @notriddle.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

GuillaumeGomez
GuillaumeGomez reviewed Oct 20, 2025
View reviewed changes
notriddle
notriddle approved these changes Oct 20, 2025
View reviewed changes
Copy link
Contributor

@notriddle notriddle left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than guillaume's question, this looks reasonable to me.

View changes since this review

@lolbinarycat lolbinarycat force-pushed the rustdoc-search-relax-ident-rules branch from 97e6ef3 to a354992 Compare October 20, 2025 17:58
@lolbinarycat
Copy link
Contributor Author

Added a much more in depth comment on the test

@notriddle
Copy link
Contributor

@bors r=notriddle,GuillaumeGomez

@bors
Copy link
Collaborator

bors commented Oct 20, 2025

📌 Commit a354992 has been approved by notriddle,GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 20, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 20, 2025
@matthiaskrgr
Rollup merge of rust-lang#147860 - lolbinarycat:rustdoc-search-relax-…
46aeefb 
…ident-rules, r=notriddle,GuillaumeGomez

rustdoc search: relax rules for identifiers

fixes rust-lang#147763
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 20, 2025
Closed
bors added a commit that referenced this pull request Oct 20, 2025
@bors
Auto merge of #147920 - matthiaskrgr:rollup-b3wqqf9, r=matthiaskrgr
4d014a5 
Rollup of 3 pull requests

Successful merges:

 - #147125 (move `once` module out of `poison`)
 - #147860 (rustdoc search: relax rules for identifiers)
 - #147910 (handle spurious returns of `wait_timeout` in test)

r? `@ghost`
`@rustbot` modify labels: rollup
@lolbinarycat
Copy link
Contributor Author

This is a change to the semantics of rustdoc search, which I generally like to relnotes, but this might be too small a change to justify that.

@notriddle notriddle added the relnotes Marks issues that should be documented in the release notes of the next release. label Oct 20, 2025
@rustbot rustbot mentioned this pull request Oct 20, 2025
Open
@Zalathar Zalathar mentioned this pull request Oct 21, 2025
Merged
bors added a commit that referenced this pull request Oct 21, 2025
@bors
Auto merge of #147928 - Zalathar:rollup-2lmpajs, r=Zalathar
e821cb8 
Rollup of 5 pull requests

Successful merges:

 - #147125 (move `once` module out of `poison`)
 - #147800 (Add `Cacheable` trait alias in `rustc_public_bridge`)
 - #147860 (rustdoc search: relax rules for identifiers)
 - #147916 (Update books)
 - #147924 (rustc-dev-guide subtree update)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 68bcd90 into rust-lang:master Oct 21, 2025
11 checks passed
@rustbot rustbot added this to the 1.92.0 milestone Oct 21, 2025
rust-timer added a commit that referenced this pull request Oct 21, 2025
@rust-timer
Unrolled build for #147860
b579801 
Rollup merge of #147860 - lolbinarycat:rustdoc-search-relax-ident-rules, r=notriddle,GuillaumeGomez

rustdoc search: relax rules for identifiers

fixes #147763
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez left review comments

@notriddle notriddle notriddle approved these changes

Assignees

@notriddle notriddle

Labels

A-rustdoc-search Area: Rustdoc's search feature relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Milestone

1.92.0

Development

Successfully merging this pull request may close these issues.

Rustdoc frontend: cannot search a number

5 participants

@lolbinarycat @rustbot @notriddle @bors @GuillaumeGomez