Rollup merge of #147860 - lolbinarycat:rustdoc-search-relax-ident-rules, r=notriddle,GuillaumeGomez

rustdoc search: relax rules for identifiers

fixes #147763

Author: Zalathar

src/librustdoc/html/static/js/search.js

@@ -149,7 +149,10 @@ const ROOT_PATH = typeof window !== "undefined" ? window.rootPath : "../";
 const UNBOXING_LIMIT = 5;
 
 // used for search query verification
-const REGEX_IDENT = /\p{ID_Start}\p{ID_Continue}*|_\p{ID_Continue}+/uy;
+// because searches are often performed using substrings of identifiers,
+// and not just full identiferes, we allow them to start with chars that otherwise
+// can only appear in the middle of identifiers
+const REGEX_IDENT = /\p{ID_Continue}+/uy;
 const REGEX_INVALID_TYPE_FILTER = /[^a-z]/ui;
 
 const MAX_RESULTS = 200;

tests/rustdoc-js-std/parser-errors.js

@@ -165,7 +165,7 @@ const PARSED = [
         foundElems: 0,
         userQuery: "_:",
         returned: [],
-        error: "Unexpected `_` (not a valid identifier)",
+        error: "Unexpected `_` in type filter (before `:`)",
     },
     {
         query: "ab:",

tests/rustdoc-js-std/search-by-number.js

@@ -0,0 +1,19 @@
+// regression test for https://github.com/rust-lang/rust/issues/147763
+//
+// identifiers in search queries should not be required to follow the
+// same strict rules around ID_Start that identifers in rust code follow,
+// as searches frequently use substrings of identifers.
+//
+// for example, identifiers cannot start with digits,
+// but they can contain them, so we allow search idents to start with digits.
+
+const EXPECTED = {
+    'query': '8',
+    'others': [
+        {
+            'path': 'std',
+            'name': 'i8',
+            'href': '../std/primitive.i8.html',
+        },
+    ]
+};