Remove named lifetimes in some PartialOrd & PartialEq impls#143575
Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom Feb 15, 2026
Merged
Remove named lifetimes in some PartialOrd & PartialEq impls#143575rust-bors[bot] merged 1 commit intorust-lang:mainfrom
PartialOrd & PartialEq impls#143575rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Conversation
Collaborator
|
rustbot has assigned @Mark-Simulacrum. Use |
rustbot
added
S-waiting-on-review
| - impl PartialEq for String; | ||
| - impl PartialEq<ByteStr> for String; | ||
| - impl PartialEq<ByteString> for String; | ||
| - impl PartialEq<str> for String; |
Member
There was a problem hiding this comment.
Hm, do we know what caused this change? It seems a bit unexpected for what is (I think) supposed to be a no-op change to change the diagnostic like this?
Contributor
Author
There was a problem hiding this comment.
No idea, sadly
Mark-Simulacrum
added
S-waiting-on-author
Collaborator
Member
|
Hi, ping from triage team. In the latest commit the UI dump has been changed to the new form, looks like we can safely merge this now. @GrigorenkoPV Would you like to finish it by rebasing the branch? |
GrigorenkoPV
force-pushed
the
unused_lifetimes
branch
from
a25788f to
cd314de
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Contributor
Author
Happily! |
rustbot
added
S-waiting-on-review
Member
|
@bors r+ rollup I'm still curious on that diagnostics change but I'm not seeing any obvious reason for it. I think it's probably fine to accept this. |
Contributor
rust-bors
bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Feb 14, 2026
…ark-Simulacrum Remove named lifetimes in some `PartialOrd` & `PartialEq` `impl`s Makes [the docs](https://doc.rust-lang.org/1.88.0/std/cmp/trait.PartialOrd.html#impl-PartialOrd%3CPathBuf%3E-for-Cow%3C'a,+Path%3E) way easier to look at, gets rid of a few `#[allow(unused_lifetimes)]`, and AFAICT is completely equivalent.
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Feb 14, 2026
…ark-Simulacrum Remove named lifetimes in some `PartialOrd` & `PartialEq` `impl`s Makes [the docs](https://doc.rust-lang.org/1.88.0/std/cmp/trait.PartialOrd.html#impl-PartialOrd%3CPathBuf%3E-for-Cow%3C'a,+Path%3E) way easier to look at, gets rid of a few `#[allow(unused_lifetimes)]`, and AFAICT is completely equivalent.
This was referenced Feb 14, 2026
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 14, 2026
…uwer Rollup of 7 pull requests Successful merges: - #152622 (Update GCC subtree) - #145024 (Optimize indexing slices and strs with inclusive ranges) - #151365 (UnsafePinned: implement opsem effects of UnsafeUnpin) - #152381 (Do not require `'static` for obtaining reflection information.) - #143575 (Remove named lifetimes in some `PartialOrd` & `PartialEq` `impl`s) - #152404 (tests: adapt align-offset.rs for InstCombine improvements in LLVM 23) - #152582 (rustc_query_impl: Use `ControlFlow` in `visit_waiters` instead of nested options)
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 14, 2026
…uwer Rollup of 7 pull requests Successful merges: - #152622 (Update GCC subtree) - #145024 (Optimize indexing slices and strs with inclusive ranges) - #151365 (UnsafePinned: implement opsem effects of UnsafeUnpin) - #152381 (Do not require `'static` for obtaining reflection information.) - #143575 (Remove named lifetimes in some `PartialOrd` & `PartialEq` `impl`s) - #152404 (tests: adapt align-offset.rs for InstCombine improvements in LLVM 23) - #152582 (rustc_query_impl: Use `ControlFlow` in `visit_waiters` instead of nested options)
rust-timer
added a commit
that referenced
this pull request
Feb 15, 2026
Rollup merge of #143575 - GrigorenkoPV:unused_lifetimes, r=Mark-Simulacrum Remove named lifetimes in some `PartialOrd` & `PartialEq` `impl`s Makes [the docs](https://doc.rust-lang.org/1.88.0/std/cmp/trait.PartialOrd.html#impl-PartialOrd%3CPathBuf%3E-for-Cow%3C'a,+Path%3E) way easier to look at, gets rid of a few `#[allow(unused_lifetimes)]`, and AFAICT is completely equivalent.
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Feb 15, 2026
…uwer Rollup of 7 pull requests Successful merges: - rust-lang/rust#152622 (Update GCC subtree) - rust-lang/rust#145024 (Optimize indexing slices and strs with inclusive ranges) - rust-lang/rust#151365 (UnsafePinned: implement opsem effects of UnsafeUnpin) - rust-lang/rust#152381 (Do not require `'static` for obtaining reflection information.) - rust-lang/rust#143575 (Remove named lifetimes in some `PartialOrd` & `PartialEq` `impl`s) - rust-lang/rust#152404 (tests: adapt align-offset.rs for InstCombine improvements in LLVM 23) - rust-lang/rust#152582 (rustc_query_impl: Use `ControlFlow` in `visit_waiters` instead of nested options)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the docs way easier to look at, gets rid of a few
#[allow(unused_lifetimes)], and AFAICT is completely equivalent.