Skip to content

UnsafePinned: implement opsem effects of UnsafeUnpin#151365

Open
RalfJung wants to merge 2 commits intorust-lang:mainfrom
RalfJung:unsafe-unpin-opsem
Open

UnsafePinned: implement opsem effects of UnsafeUnpin#151365
RalfJung wants to merge 2 commits intorust-lang:mainfrom
RalfJung:unsafe-unpin-opsem

Conversation

@RalfJung
Copy link
Member

This implements the next step for #125735: actually making UnsafePinned have special opsem effects by suppressing the noalias even if the type is wrapped in an Unpin wrapper.

For backwards compatibility we also still keep the Unpin hack, i.e. a type must be both Unpin and UnsafeUnpin to get noalias.

@rustbot
Copy link
Collaborator

rustbot commented Jan 19, 2026

The Miri subtree was changed

cc @rust-lang/miri

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 19, 2026
@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Jan 19, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 19, 2026

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rustbot
Copy link
Collaborator

rustbot commented Jan 19, 2026

This PR modifies tests/auxiliary/minicore.rs.

cc @jieyouxu

@rustbot rustbot added the A-test-infra-minicore Area: `minicore` test auxiliary and `//@ add-core-stubs` label Jan 19, 2026
@rust-log-analyzer

This comment has been minimized.

@RalfJung
Copy link
Member Author

Uh, what is happening with the link checker here? I have no idea why this PR would add new links to NonZeroInner...

@jieyouxu jieyouxu self-assigned this Jan 20, 2026
@jieyouxu jieyouxu closed this Jan 21, 2026
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 21, 2026
@jieyouxu jieyouxu reopened this Jan 21, 2026
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 21, 2026
@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@jieyouxu jieyouxu removed their assignment Jan 21, 2026
@RalfJung
Copy link
Member Author

Uh, no idea what's going on, but it some sort of rustdoc weirdness... Cc @rust-lang/rustdoc

@rustbot rustbot added the T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. label Jan 21, 2026
@RalfJung
Copy link
Member Author

@davidtwco will you be fine to review this or should I go look for someone else?

Not sure who else knows their way around our LLVM attribute handling here... @nikic @workingjubilee maybe?

@rust-bors

This comment has been minimized.

@RalfJung
Copy link
Member Author

RalfJung commented Feb 5, 2026

@rustbot reroll

@rustbot rustbot assigned petrochenkov and unassigned davidtwco Feb 5, 2026
@rustbot

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@davidtwco
Copy link
Member

@davidtwco will you be fine to review this or should I go look for someone else?

Not sure who else knows their way around our LLVM attribute handling here... @nikic @workingjubilee maybe?

Sorry for the delay in getting back to you, some of this is a bit out of cache for me, so probably best to reroll.

@RalfJung
Copy link
Member Author

RalfJung commented Feb 5, 2026

@rustbot reroll

@rustbot rustbot assigned BoxyUwU and unassigned petrochenkov Feb 5, 2026
@rustbot
Copy link
Collaborator

rustbot commented Feb 12, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-test-infra-minicore Area: `minicore` test auxiliary and `//@ add-core-stubs` S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants