-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stabilize asm_goto
feature gate
#133870
Open
nbdd0121
wants to merge
1
commit into
rust-lang:master
Choose a base branch
from
nbdd0121:asm
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Stabilize asm_goto
feature gate
#133870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Dec 4, 2024
@rustbot label: -T-compiler +T-lang +A-inline-assembly +F-asm Cc @rust-lang/wg-inline-asm |
rustbot
added
A-inline-assembly
Area: Inline assembly (`asm!(…)`)
F-asm
`#![feature(asm)]` (not `llvm_asm`)
T-lang
Relevant to the language team, which will review and decide on the PR/issue.
and removed
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Dec 4, 2024
r? compiler cc @Amanieu |
rustbot
added
the
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
label
Dec 4, 2024
ehuss
added
I-lang-nominated
Nominated for discussion during a lang team meeting.
and removed
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Dec 4, 2024
The code changes look fine for stabilizing this feature, so r=me in terms of code. But I am uncertain about the stabilization process. Is any additional T-lang approval needed before this merges? Has such approval already been obtained? |
90 tasks
@nnethercote this would need a FCP. |
r? lang (for T-lang FCP) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-inline-assembly
Area: Inline assembly (`asm!(…)`)
F-asm
`#![feature(asm)]` (not `llvm_asm`)
I-lang-nominated
Nominated for discussion during a lang team meeting.
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-lang
Relevant to the language team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stabilize
asm_goto
feature (tracked by #119364). The issue will remain open and be updated to trackasm_goto_with_outputs
.Reference PR: rust-lang/reference#1693
Stabilization Report
This feature adds a
label <block>
operand type toasm!
.<block>
must be a block expression with type unit or never. The address of the block is substituted and the assembly may jump to the block. When block completes theasm!
block returns and continues execution.The block starts a new safety context and unsafe operations within must have additional
unsafe
s; the effect ofunsafe
that surroundsasm!
block is cancelled. See #119364 (comment) and #131544.It's currently forbidden to use
asm_goto
with output operands; that is still unstable underasm_goto_with_outputs
.Example:
Tests: