[AIX] create shim for lgammaf_r #133543
Merged
[AIX] create shim for lgammaf_r #133543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @cuviper (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
rustbot
added
S-waiting-on-review
|
Sounds good, and there's precedent for this kind of shim in MSVC. Thanks! @bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 28, 2024
…llaumeGomez Rollup of 12 pull requests Successful merges: - rust-lang#129409 (Expand std::os::unix::fs::chown() doc with a warning) - rust-lang#133320 (Add release notes for Rust 1.83.0) - rust-lang#133368 (Delay a bug when encountering an impl with unconstrained generics in `codegen_select`) - rust-lang#133428 (Actually use placeholder regions for trait method late bound regions in `collect_return_position_impl_trait_in_trait_tys`) - rust-lang#133512 (Add `as_array` and `as_mut_array` conversion methods to slices.) - rust-lang#133519 (Check `xform_ret_ty` for WF in the new solver to improve method winnowing) - rust-lang#133520 (Structurally resolve before applying projection in borrowck) - rust-lang#133534 (extend group-forbid-always-trumps-cli test) - rust-lang#133537 ([rustdoc] Fix new clippy lints) - rust-lang#133543 ([AIX] create shim for lgammaf_r) - rust-lang#133547 (rustc_span: Replace a `HashMap<_, ()>` with `HashSet`) - rust-lang#133550 (print generated doc paths) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 28, 2024
Rollup merge of rust-lang#133543 - mustartt:aix-lgammaf_r-shim, r=cuviper [AIX] create shim for lgammaf_r On AIX, we don't have 32bit floating point for re-entrant `lgammaf_r` but we do have the 64bit floating point re-entrant `lgamma_r` so we can use the 64bit version instead and truncate back to a 32bit float. This solves the linker missing symbol for `.lgammaf_r` when testing and using these parts of the `std`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On AIX, we don't have 32bit floating point for re-entrant
lgammaf_rbut we do have the 64bit floating point re-entrantlgamma_rso we can use the 64bit version instead and truncate back to a 32bit float.This solves the linker missing symbol for
.lgammaf_rwhen testing and using these parts of thestd.