Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand std::os::unix::fs::chown() doc with a warning #129409

Merged
merged 3 commits into from
Nov 28, 2024
Merged

Expand std::os::unix::fs::chown() doc with a warning #129409

merged 3 commits into from
Nov 28, 2024

Conversation

grinapo
Copy link
Contributor

@grinapo grinapo commented Aug 22, 2024

Include warning about losing setuid/gid when chowning, per POSIX.

It is about the underlying system call but it is rather useful to mention it in the help in case someone accidentally forgets (don't look at me :)).

@grinapo
Expand std::os::unix::fs::chown() doc with a warning
a9ecd0f 
Include warning about losing setuid/gid when chowning, per POSIX.
@rustbot
Copy link
Collaborator

rustbot commented Aug 22, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Amanieu (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added O-unix Operating system: Unix-like S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 22, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@grinapo
Update chown help with a link and adding cap warning
3408dc1 
Linked to chown(2) manpage on the web which expands on chown call behaviour.
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Dylan-DPC Dylan-DPC added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 13, 2024
@Dylan-DPC
Copy link
Member

@grinapo if you can bless the tests we can push this forward

@grinapo
Copy link
Contributor Author

grinapo commented Nov 14, 2024

@grinapo if you can bless the tests we can push this forward

Oh, but I'm just a humble servant, I am not familar with the mighty CI, and I am also not authorized for anything. I can't even tell why the test fails, whether I need to do something about it, or if it's good (since that's a trivial change) tell me what magic shall I cast, and I will.

I thought it's @jieyouxu who's to the Powers™.

@Amanieu
Copy link
Member

Amanieu commented Nov 14, 2024

CI tests are failing because there is trailing whitespace in your change. You can fix it by running ./x.py fmt.

@grinapo
Copy link
Contributor Author

grinapo commented Nov 14, 2024

@Amanieu Tests are all green now, do I need to do anything else?

@Dylan-DPC Dylan-DPC added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 15, 2024
@Dylan-DPC
Copy link
Member

normally you can run @rustbot ready but i've already switched the labels so there's no need for that

@Amanieu
Copy link
Member

Amanieu commented Nov 18, 2024

@bors r+ rollup

@Amanieu Amanieu closed this Nov 28, 2024
@Amanieu Amanieu reopened this Nov 28, 2024
@Amanieu
Copy link
Member

Amanieu commented Nov 28, 2024

Seems bors lost track of the PR.

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Nov 28, 2024

📌 Commit 451c8cd has been approved by Amanieu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 28, 2024
@GuillaumeGomez GuillaumeGomez mentioned this pull request Nov 28, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 28, 2024
@bors
Auto merge of rust-lang#133561 - GuillaumeGomez:rollup-g4upmv4, r=Gui…
f005c74 
…llaumeGomez

Rollup of 12 pull requests

Successful merges:

 - rust-lang#129409 (Expand std::os::unix::fs::chown() doc with a warning)
 - rust-lang#133320 (Add release notes for Rust 1.83.0)
 - rust-lang#133368 (Delay a bug when encountering an impl with unconstrained generics in `codegen_select`)
 - rust-lang#133428 (Actually use placeholder regions for trait method late bound regions in `collect_return_position_impl_trait_in_trait_tys`)
 - rust-lang#133512 (Add `as_array` and `as_mut_array` conversion methods to slices.)
 - rust-lang#133519 (Check `xform_ret_ty` for WF in the new solver to improve method winnowing)
 - rust-lang#133520 (Structurally resolve before applying projection in borrowck)
 - rust-lang#133534 (extend group-forbid-always-trumps-cli test)
 - rust-lang#133537 ([rustdoc] Fix new clippy lints)
 - rust-lang#133543 ([AIX] create shim for lgammaf_r)
 - rust-lang#133547 (rustc_span: Replace a `HashMap<_, ()>` with `HashSet`)
 - rust-lang#133550 (print generated doc paths)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 10193a3 into rust-lang:master Nov 28, 2024
12 checks passed
@rustbot rustbot added this to the 1.85.0 milestone Nov 28, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Nov 28, 2024
@rust-timer
Unrolled build for rust-lang#129409
63e6ea3 
Rollup merge of rust-lang#129409 - grinapo:patch-1, r=Amanieu

Expand std::os::unix::fs::chown() doc with a warning

Include warning about losing setuid/gid when chowning, per POSIX.

It is about the underlying system call but it is rather useful to mention it in the help in case someone accidentally forgets (don't look at me :)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieyouxu jieyouxu jieyouxu left review comments

Assignees

@Amanieu Amanieu

Labels
O-unix Operating system: Unix-like S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.85.0
Development

Successfully merging this pull request may close these issues.
7 participants
@grinapo @rustbot @rust-log-analyzer @Dylan-DPC @Amanieu @bors @jieyouxu