Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subpart8 for async drop (major2) - dropline in scopes for potentially async drops #129744

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

azhogin
Copy link
Contributor

@azhogin azhogin commented Aug 29, 2024

This is subpart 8 PR of #123948, just for review purposes.

Scopes processing for generate async drop preparations.
In scopes processing we need to consider potentially async drops as a hidden Yield and prepare dropline in the similar way as for Yield terminator.

Review only last commit, based on previous PR #129742

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 29, 2024
@rustbot
Copy link
Collaborator

rustbot commented Aug 29, 2024

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

Some changes occurred to the CTFE / Miri engine

cc @rust-lang/miri

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

This PR changes Stable MIR

cc @oli-obk, @celinval, @ouz-a

This PR changes MIR

cc @oli-obk, @RalfJung, @JakobDegen, @davidtwco, @celinval, @vakaras

@rustbot rustbot added T-libs Relevant to the library team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative labels Aug 29, 2024
@RalfJung
Copy link
Member

@azhogin please read what I wrote in one of your other PRs. You're spamming tons of people here.

Can you please mark these PRs as "draft" (before creating them, i.e. in the PR creation dialog), so that the bot doesn't ping dozens of people for each of them? :)

@azhogin azhogin force-pushed the azhogin/async-drop-subpart8-scopes branch from b755978 to 31bf8a4 Compare September 8, 2024 18:04
@azhogin azhogin force-pushed the azhogin/async-drop-subpart8-scopes branch from 31bf8a4 to 2e77402 Compare September 8, 2024 23:01
@bors
Copy link
Contributor

bors commented Sep 9, 2024

☔ The latest upstream changes (presumably #130165) made this pull request unmergeable. Please resolve the merge conflicts.

@davidtwco
Copy link
Member

r? @nikomatsakis is going to look into this

@rustbot rustbot assigned nikomatsakis and unassigned davidtwco Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants