Subpart7 for async drop (major1) - library changes #129742
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Some changes occurred to the CTFE / Miri engine cc @rust-lang/miri Some changes occurred in compiler/rustc_codegen_cranelift cc @bjorn3 This PR changes Stable MIR cc @oli-obk, @celinval, @ouz-a This PR changes MIR cc @oli-obk, @RalfJung, @JakobDegen, @davidtwco, @celinval, @vakaras Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
rustbot
added
the
WG-trait-system-refactor
This was referenced Aug 29, 2024
Comment on lines
+363
to
+369
| /// Allows implementing `AsyncDrop`. | ||
| (incomplete, async_drop, "CURRENT_RUSTC_VERSION", Some(126482)), |
There was a problem hiding this comment.
I don't see feature gates in the compiler being tested. If this all hinges on the library feature gate, then let it hinge on the library feature gate, and remove the compiler gate.
Suggested change
| /// Allows implementing `AsyncDrop`. | |
| (incomplete, async_drop, "CURRENT_RUSTC_VERSION", Some(126482)), |
azhogin
force-pushed
the
azhogin/async-drop-subpart7-major1-library-changes
branch
from
2199d76
to
cc9bedd
Compare
azhogin
force-pushed
the
azhogin/async-drop-subpart7-major1-library-changes
branch
from
cc9bedd
to
8d974b6
Compare
…p from previous async drop glue implementation
azhogin
force-pushed
the
azhogin/async-drop-subpart7-major1-library-changes
branch
from
8d974b6
to
bdbfcd7
Compare
azhogin
force-pushed
the
azhogin/async-drop-subpart7-major1-library-changes
branch
from
bdbfcd7
to
f2fdd69
Compare
|
☔ The latest upstream changes (presumably #130165) made this pull request unmergeable. Please resolve the merge conflicts. |
|
r? @nikomatsakis is going to look into this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is subpart 7 PR of #123948, just for review purposes.
Library changes:
async fn async_drop_in_place<T>(dropee)declaration etc.Review only last commit, based on previous PR #129741