Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 11 pull requests #129391

Closed
wants to merge 30 commits into from
Closed

Commits on Jul 4, 2024

  1. Configuration menu
    Copy the full SHA
    07481b9 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2024

  1. Configuration menu
    Copy the full SHA
    0b87af9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    608901b View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2024

  1. Enable f16 on x86 and x86-64

    Since the `compiler_builtins` update [1], ABI bugs on x86 should be
    resolved. Enable tests for f16 on these platforms now.
    
    [1]: rust-lang#125016
    tgross35 committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    e518451 View commit details
    Browse the repository at this point in the history
  2. Change f16 doctests in core to run on x86-64

    Since `f16` now works on x86 and x86-64, change doctests to use this
    instead of aarch64. This is to make sure any changes get run in PR CI.
    tgross35 committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    0a5d5ff View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2024

  1. Configuration menu
    Copy the full SHA
    8a61674 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2024

  1. Configuration menu
    Copy the full SHA
    6899f5a View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2024

  1. Configuration menu
    Copy the full SHA
    10ef666 View commit details
    Browse the repository at this point in the history
  2. untranslatable_diagnostic lint: point at the untranslated thing

    and not the function/method call
    GrigorenkoPV committed Aug 10, 2024
    Configuration menu
    Copy the full SHA
    3cc2a6f View commit details
    Browse the repository at this point in the history
  3. Refactor: diagnostic_outside_of_impl, untranslatable_diagnostic

    1. Decouple them.
    2. Make logic around `diagnostic_outside_of_impl`'s early exits simpler.
    3. Make `untranslatable_diagnostic` run one loop instead of two
       and not allocate an intermediate vec.
    4. Overall, reduce the amount of code executed
       when the lints do not end up firing.
    GrigorenkoPV committed Aug 10, 2024
    Configuration menu
    Copy the full SHA
    e94a4ee View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2024

  1. Configuration menu
    Copy the full SHA
    76fbf0a View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2024

  1. rustdoc: animate the :target highlight

    This approach is, roughly, based on how Discourse does it.
    It came up while discussing some other possible sidebar changes,
    as a design that made rapid scanning easier while avoiding the
    inherent trade-offs in summarizing.
    notriddle committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    9d7574f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    40af214 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2024

  1. Configuration menu
    Copy the full SHA
    c836739 View commit details
    Browse the repository at this point in the history
  2. Add const_cell_into_inner to OnceCell

    `Cell` and `RefCell` have their `into_inner` methods const unstable.
    `OnceCell` has the same logic, so add it under the same gate.
    
    Tracking issue: rust-lang#78729
    tgross35 committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    81c00dd View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2024

  1. Configuration menu
    Copy the full SHA
    7232a07 View commit details
    Browse the repository at this point in the history
  2. Rename foo.py to my_gdb_script.py

    This makes it easier for maintainers to see what the Python script is for.
    Zalathar committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    5fc562c View commit details
    Browse the repository at this point in the history
  3. Advise against removing run-make/libtest-junit/validate_junit.py

    Trying to get rid of this Python script looks tempting, because it's currently
    the only Python script in the whole `run-make` suite that we actually run.
    
    But getting rid of it would require pulling in a Rust crate to parse XML
    instead, and that's probably not worth the extra hassle for a relatively-minor
    test.
    Zalathar committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    34cdfc9 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ca7c55f View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#126985 - Mrmaxmeier:dwarf-embed-source, r=d…

    …avidtwco
    
    Implement `-Z embed-source` (DWARFv5 source code embedding extension)
    
    Implement rust-lang/compiler-team#764 MCP which adds an unstable flag that exposes LLVM's [DWARFv5 source code embedding](https://dwarfstd.org/issues/180201.1.html) support.
    jieyouxu authored Aug 22, 2024
    Configuration menu
    Copy the full SHA
    0dbfe1b View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#127279 - bvanjoi:fix-112680, r=petrochenkov

    use old ctx if has same expand environment during decode span
    
    Fixes rust-lang#112680
    
    The root reason why rust-lang#112680 failed with incremental compilation on the second attempt is the difference in `opaque` between the span of the field [`ident`](https://github.com/rust-lang/rust/blob/master/compiler/rustc_hir_typeck/src/expr.rs#L2348) and the span in the incremental cache at `tcx.def_ident_span(field.did)`.
    
    -  Let's call the span of `ident` as `span_a`, which is generated by [`apply_mark_internal`](https://github.com/rust-lang/rust/blob/master/compiler/rustc_span/src/hygiene.rs#L553-L554). Its content is similar to:
    
    ```rs
    span_a_ctx -> SyntaxContextData {
          opaque: span_a_ctx,
          opaque_and_semitransparent: span_a_ctx,
          // ....
    }
    ```
    
    - And call the span of `tcx.def_ident_span` as `span_b`, which is generated by [`decode_syntax_context`](https://github.com/rust-lang/rust/blob/master/compiler/rustc_span/src/hygiene.rs#L1390). Its content is:
    
    ```rs
    span_b_ctx -> SyntaxContextData {
          opaque: span_b_ctx,
          // note `span_b_ctx` is not same as `span_a_ctx`
          opaque_and_semitransparent: span_b_ctx,
          // ....
    }
    ```
    
    Although they have the same `parent` (both refer to the root) and `outer_expn`, I cannot find the specific connection between them. Therefore, I chose a solution that may not be the best: give up the incremental compile cache to ensure we can use `span_a` in this case.
    
    r?  ``@petrochenkov`` Do you have any advice on this? Or perhaps this solution is acceptable?
    jieyouxu authored Aug 22, 2024
    Configuration menu
    Copy the full SHA
    35d6344 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#128349 - tgross35:x86-f16, r=Noratrieb

    Enable `f16` on x86 and x86-64
    
    Since the `compiler_builtins` update [1], ABI bugs on x86 should be resolved. Enable tests for f16 on these platforms now.
    
    [1]: rust-lang#125016
    
    try-job: i686-gnu
    try-job: dist-i586-gnu-i586-i686-musl
    jieyouxu authored Aug 22, 2024
    Configuration menu
    Copy the full SHA
    c7afff3 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#128432 - g0djan:godjan/wasi_prohibit_implic…

    …it_unsafe, r=tgross35
    
    WASI: forbid `unsafe_op_in_unsafe_fn` for `std::{os, sys}`
    
    Part of rust-lang#127747 for WASI
    
    try-job: test-various
    jieyouxu authored Aug 22, 2024
    Configuration menu
    Copy the full SHA
    765a045 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#128941 - GrigorenkoPV:internal-diagnostic-l…

    …ints, r=davidtwco
    
     Improve diagnostic-related lints: `untranslatable_diagnostic` & `diagnostic_outside_of_impl`
    
    Summary:
    - Made `untranslatable_diagnostic` point to problematic arguments instead of the function call
      (I found this misleading while working on some `A-translation` PRs: my first impression was that
      the methods themselves were not translation-aware and needed to be changed,
      while in reality the problem was with the hardcoded strings passed as arguments).
    - Made the shared pass of `untranslatable_diagnostic` & `diagnostic_outside_of_impl` more efficient.
    
    ``@rustbot`` label D-imprecise-spans A-translation
    jieyouxu authored Aug 22, 2024
    Configuration menu
    Copy the full SHA
    126a5c2 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#129257 - ChrisDenton:rename-null-descriptor…

    …, r=jieyouxu
    
    Allow rust staticlib to work with MSVC's /WHOLEARCHIVE
    
    This fixes rust-lang#129020 by renaming the `__NULL_IMPORT_DESCRIPTOR` to prevent conflicts.
    
    try-job: dist-i686-msvc
    jieyouxu authored Aug 22, 2024
    Configuration menu
    Copy the full SHA
    f24be46 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#129284 - notriddle:notriddle/animate-target…

    …=light, r=GuillaumeGomez
    
    rustdoc: animate the `:target` highlight
    
    This approach is, roughly, based on how Discourse does it. It came up while discussing [some other possible sidebar changes](https://rust-lang.zulipchat.com/#narrow/stream/266220-t-rustdoc/topic/Moving.20deprecated.20items.20out.20of.20the.20way), as a design that made rapid scanning easier while avoiding the inherent trade-offs in summarizing.
    
    https://github.com/user-attachments/assets/f7a8fec3-70a5-40a1-92ea-bfdffbd61c22
    jieyouxu authored Aug 22, 2024
    Configuration menu
    Copy the full SHA
    ccdaea7 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#129376 - ChaiTRex:assert_unsafe_preconditio…

    …n_check_language_ub, r=workingjubilee,the8472
    
    Change `assert_unsafe_precondition` docs to refer to `check_language_ub`
    jieyouxu authored Aug 22, 2024
    Configuration menu
    Copy the full SHA
    738014a View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#129382 - tgross35:once-cell-const-into-inne…

    …r, r=Noratrieb
    
    Add `const_cell_into_inner` to `OnceCell`
    
    `Cell` and `RefCell` have their `into_inner` methods const unstable. `OnceCell` has the same logic, so add it under the same gate.
    
    Tracking issue: rust-lang#78729
    jieyouxu authored Aug 22, 2024
    Configuration menu
    Copy the full SHA
    18d4e5b View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#129387 - Zalathar:python-apologia, r=jieyouxu

    Advise against removing the remaining Python scripts from `tests/run-make`
    
    After some recent PRs (e.g. rust-lang#129185), there are only two Python scripts left in `tests/run-make`.
    
    Having come so far, it's tempting to try to get rid of the remaining ones. But after trying that myself, I've come to the conclusion that it's not worth the extra hassle, especially if it means pulling in an XML-parsing crate just for one test.
    
    This PR therefore leaves behind a few signpost comments to explain why getting rid of these particular scripts has low value.
    jieyouxu authored Aug 22, 2024
    Configuration menu
    Copy the full SHA
    a75f9b9 View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#129388 - cjgillot:region-def-id, r=compiler…

    …-errors
    
    Do not rely on names to find lifetimes.
    
    For some reason, we were trying to find the lifetime parameter from its name, instead of using the def_id we have.
    
    This PR uses it instead. This changes some ui tests, I think to be more sensible.
    jieyouxu authored Aug 22, 2024
    Configuration menu
    Copy the full SHA
    24e7d69 View commit details
    Browse the repository at this point in the history