Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add -Z embed-source (DWARFv5 source code embedding extension) #764

Closed
3 tasks done
Mrmaxmeier opened this issue Jun 26, 2024 · 3 comments
Closed
3 tasks done

Add -Z embed-source (DWARFv5 source code embedding extension) #764

Mrmaxmeier opened this issue Jun 26, 2024 · 3 comments
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team

Comments

@Mrmaxmeier
Copy link

Mrmaxmeier commented Jun 26, 2024 •
edited
Loading

Proposal

DWARFv5 has an extension for embedding program source code directly into the debug info sections: https://dwarfstd.org/issues/180201.1.html

LLVM implements this extension, though it currently uses a custom pre-standardization attribute opcode.

Clang supports it through a -gembed-source flag but Rust does not expose this feature at the moment.

Implementing this seems straight-forward (rust-lang/rust#126985) but I'm not entirely sure how to deal with unsupported platforms.

  • Should -Z embed-source=yes fail the build on non-DWARF or non-LLVM platforms?
  • Should -Z embed-source=yes automatically bump the DWARF version to v5 or should it require an explicit -Z dwarf-version=5? Clang currently defaults to v4 and requires setting the DWARF version explicitly.
  • Should -Z embed-source=yes fail the build if -g was not provided?

Process

The main points of the Major Change Process are as follows:

  • File an issue describing the proposal.
  • A compiler team member or contributor who is knowledgeable in the area can second by writing @rustbot second.
    • Finding a "second" suffices for internal changes. If however, you are proposing a new public-facing feature, such as a -C flag, then full team check-off is required.
    • Compiler team members can initiate a check-off via @rfcbot fcp merge on either the MCP or the PR.
  • Once an MCP is seconded, the Final Comment Period begins. If no objections are raised after 10 days, the MCP is considered approved.

You can read more about Major Change Proposals on forge.
@Mrmaxmeier Mrmaxmeier added major-change A proposal to make a major change to rustc T-compiler Add this label so rfcbot knows to poll the compiler team labels Jun 26, 2024
@rustbot
Copy link
Collaborator

rustbot commented Jun 26, 2024

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

Concerns or objections to the proposal should be discussed on Zulip and formally registered here by adding a comment with the following syntax:

@rustbot concern reason-for-concern 
<description of the concern>

Concerns can be lifted with:

@rustbot resolve reason-for-concern

See documentation at https://forge.rust-lang.org

cc @rust-lang/compiler @rust-lang/compiler-contributors

@rustbot rustbot added the to-announce Announce this issue on triage meeting label Jun 26, 2024
@Mrmaxmeier Mrmaxmeier mentioned this issue Jun 26, 2024
Merged
@Mrmaxmeier Mrmaxmeier changed the title Add -C embed-source (DWARFv5 source code embedding extension) Add -Z embed-source (DWARFv5 source code embedding extension) Jun 26, 2024
@davidtwco
Copy link
Member

@rustbot second

@rustbot rustbot added the final-comment-period The FCP has started, most (if not all) team members are in agreement label Jul 4, 2024
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Jul 4, 2024
@apiraino
Copy link
Contributor

@rustbot label -final-comment-period +major-change-accepted

@rustbot rustbot added major-change-accepted A major change proposal that was accepted to-announce Announce this issue on triage meeting and removed final-comment-period The FCP has started, most (if not all) team members are in agreement labels Jul 15, 2024
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Jul 22, 2024
jieyouxu added a commit to jieyouxu/rust that referenced this issue Aug 22, 2024
@jieyouxu
Rollup merge of rust-lang#126985 - Mrmaxmeier:dwarf-embed-source, r=d…
0dbfe1b 
…avidtwco

Implement `-Z embed-source` (DWARFv5 source code embedding extension)

Implement rust-lang/compiler-team#764 MCP which adds an unstable flag that exposes LLVM's [DWARFv5 source code embedding](https://dwarfstd.org/issues/180201.1.html) support.
tgross35 added a commit to tgross35/rust that referenced this issue Aug 22, 2024
@tgross35
Rollup merge of rust-lang#126985 - Mrmaxmeier:dwarf-embed-source, r=d…
c6d3a99 
…avidtwco

Implement `-Z embed-source` (DWARFv5 source code embedding extension)

Implement rust-lang/compiler-team#764 MCP which adds an unstable flag that exposes LLVM's [DWARFv5 source code embedding](https://dwarfstd.org/issues/180201.1.html) support.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Aug 22, 2024
@matthiaskrgr
Rollup merge of rust-lang#126985 - Mrmaxmeier:dwarf-embed-source, r=d…
0e53bbb 
…avidtwco

Implement `-Z embed-source` (DWARFv5 source code embedding extension)

Implement rust-lang/compiler-team#764 MCP which adds an unstable flag that exposes LLVM's [DWARFv5 source code embedding](https://dwarfstd.org/issues/180201.1.html) support.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Aug 22, 2024
@matthiaskrgr
Rollup merge of rust-lang#126985 - Mrmaxmeier:dwarf-embed-source, r=d…
b2be758 
…avidtwco

Implement `-Z embed-source` (DWARFv5 source code embedding extension)

Implement rust-lang/compiler-team#764 MCP which adds an unstable flag that exposes LLVM's [DWARFv5 source code embedding](https://dwarfstd.org/issues/180201.1.html) support.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Aug 22, 2024
@matthiaskrgr
Rollup merge of rust-lang#126985 - Mrmaxmeier:dwarf-embed-source, r=d…
51e5cf7 
…avidtwco

Implement `-Z embed-source` (DWARFv5 source code embedding extension)

Implement rust-lang/compiler-team#764 MCP which adds an unstable flag that exposes LLVM's [DWARFv5 source code embedding](https://dwarfstd.org/issues/180201.1.html) support.
tgross35 added a commit to tgross35/rust that referenced this issue Aug 23, 2024
@tgross35
Rollup merge of rust-lang#126985 - Mrmaxmeier:dwarf-embed-source, r=d…
0e6d8b5 
…avidtwco

Implement `-Z embed-source` (DWARFv5 source code embedding extension)

Implement rust-lang/compiler-team#764 MCP which adds an unstable flag that exposes LLVM's [DWARFv5 source code embedding](https://dwarfstd.org/issues/180201.1.html) support.
jieyouxu added a commit to jieyouxu/rust that referenced this issue Aug 23, 2024
@jieyouxu
Rollup merge of rust-lang#126985 - Mrmaxmeier:dwarf-embed-source, r=d…
c680426 
…avidtwco

Implement `-Z embed-source` (DWARFv5 source code embedding extension)

Implement rust-lang/compiler-team#764 MCP which adds an unstable flag that exposes LLVM's [DWARFv5 source code embedding](https://dwarfstd.org/issues/180201.1.html) support.
jieyouxu added a commit to jieyouxu/rust that referenced this issue Aug 23, 2024
@jieyouxu
Rollup merge of rust-lang#126985 - Mrmaxmeier:dwarf-embed-source, r=d…
6d08619 
…avidtwco

Implement `-Z embed-source` (DWARFv5 source code embedding extension)

Implement rust-lang/compiler-team#764 MCP which adds an unstable flag that exposes LLVM's [DWARFv5 source code embedding](https://dwarfstd.org/issues/180201.1.html) support.
tgross35 added a commit to tgross35/rust that referenced this issue Aug 25, 2024
@tgross35
Rollup merge of rust-lang#126985 - Mrmaxmeier:dwarf-embed-source, r=d…
a3dc909 
…avidtwco

Implement `-Z embed-source` (DWARFv5 source code embedding extension)

Implement rust-lang/compiler-team#764 MCP which adds an unstable flag that exposes LLVM's [DWARFv5 source code embedding](https://dwarfstd.org/issues/180201.1.html) support.
workingjubilee added a commit to workingjubilee/rustc that referenced this issue Aug 27, 2024
@workingjubilee
Rollup merge of rust-lang#126985 - Mrmaxmeier:dwarf-embed-source, r=d…
9d08d04 
…avidtwco

Implement `-Z embed-source` (DWARFv5 source code embedding extension)

Implement rust-lang/compiler-team#764 MCP which adds an unstable flag that exposes LLVM's [DWARFv5 source code embedding](https://dwarfstd.org/issues/180201.1.html) support.
tgross35 added a commit to tgross35/rust that referenced this issue Aug 27, 2024
@tgross35
Rollup merge of rust-lang#126985 - Mrmaxmeier:dwarf-embed-source, r=d…
9c26ebe 
…avidtwco

Implement `-Z embed-source` (DWARFv5 source code embedding extension)

Implement rust-lang/compiler-team#764 MCP which adds an unstable flag that exposes LLVM's [DWARFv5 source code embedding](https://dwarfstd.org/issues/180201.1.html) support.
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Aug 27, 2024
@rust-timer
Unrolled build for rust-lang#126985
3f992f9 
Rollup merge of rust-lang#126985 - Mrmaxmeier:dwarf-embed-source, r=davidtwco

Implement `-Z embed-source` (DWARFv5 source code embedding extension)

Implement rust-lang/compiler-team#764 MCP which adds an unstable flag that exposes LLVM's [DWARFv5 source code embedding](https://dwarfstd.org/issues/180201.1.html) support.
github-actions bot pushed a commit to rust-lang/miri that referenced this issue Aug 28, 2024
@tgross35
Rollup merge of #126985 - Mrmaxmeier:dwarf-embed-source, r=davidtwco
87e950b 
Implement `-Z embed-source` (DWARFv5 source code embedding extension)

Implement rust-lang/compiler-team#764 MCP which adds an unstable flag that exposes LLVM's [DWARFv5 source code embedding](https://dwarfstd.org/issues/180201.1.html) support.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@davidtwco @Mrmaxmeier @apiraino @rustbot